Bug 106684

Summary:	Initial Konsole tab is too big, but changes when new tabs are created
Product:	[Applications] konsole	Reporter:	monstermunch
Component:	general	Assignee:	Konsole Developer <konsole-devel>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	1.5.1
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	This is what konsole looks like when I first launch it. This is what konsole looks like after I create a new tab. This is what konsole looks like after I remove the tab I just created. This is my .kde/share/config/konsolerc file

Description monstermunch 2005-06-02 18:00:16 UTC

Version:           1.5.1 (using KDE 3.4.1%20Level%20%22a%22%20,%20SUSE%209.2%20UNSUPPORTED)
Compiler:          gcc%20version%203.3.4%20(pre%203.3.5%2020040809)
OS:                Linux%20(i686)%20release%202.6.8-24.14-default

My Konsole is set to always show the tab bar, where the tabs only show an icon on them with no text. When I start Konsole, I see one tab on the tab bar, a little green monitor icon and then a blank space next to it (about the size of the icon) filling up the tab, making it look too big and ugly.

If I then create a new tab, the first tab size is corrected (so it is just big enough to contain the icon) and the second one looks fine too. If I close the second tab, the first tab retains it's (correct looking) size.

Comment 1 monstermunch 2005-06-02 18:05:48 UTC

Created attachment 11295 [details]
This is what konsole looks like when I first launch it.

Comment 2 monstermunch 2005-06-02 18:07:02 UTC

Created attachment 11296 [details]
This is what konsole looks like after I create a new tab.

Comment 3 monstermunch 2005-06-02 18:07:53 UTC

Created attachment 11297 [details]
This is what konsole looks like after I remove the tab I just created.

Comment 4 monstermunch 2005-06-02 18:09:54 UTC

Created attachment 11298 [details]
This is my .kde/share/config/konsolerc file

Comment 5 Albert Astals Cid 2005-06-05 18:18:04 UTC

SVN commit 422487 by aacid: 
 
 Fix bug 106679 
 To konsole developers: hope you don't mind i commited without asking you first but this is a one liner so i doubt i can screw it up, would you like that i backport it? 
 BUGS: 106679 
 
 
  M  +2 -1      konsole.cpp   
 
 
 --- trunk/KDE/kdebase/konsole/konsole/konsole.cpp #422486:422487 
 @@ -2066,7 +2066,8 @@ 
    KRadioAction *ra = session2action.find(se); 
    if (ra && (ra->icon() != icon)) 
      ra->setIcon(icon); 
 -  if (b_matchTabWinTitle && m_tabViewMode != ShowIconOnly) 
 +  if (m_tabViewMode == ShowIconOnly) tabwidget->changeTab( se->widget(), QString::null ); 
 +  else if (b_matchTabWinTitle) 
      tabwidget->changeTab( se->widget(), se->fullTitle() ); 
  }

Comment 6 Albert Astals Cid 2005-06-05 18:19:05 UTC

i meant bug 106684 of course, was a typo :-/

Comment 7 Kurt Hindenburg 2005-06-05 23:40:20 UTC

SVN commit 422596 by hindenburg:

Backport to fix extra space for Icon Only tabs.

CCBUGS: 106684


 M  +3 -0      konsole.cpp  


--- branches/KDE/3.4/kdebase/konsole/konsole/konsole.cpp #422595:422596
@@ -2137,6 +2137,9 @@
   KRadioAction *ra = session2action.find(se);
   if (ra && (ra->icon() != icon))
     ra->setIcon(icon);
+
+  if (m_tabViewMode == ShowIconOnly)
+    tabwidget->changeTab( se->widget(), QString::null );
 }
 
 void Konsole::initSessionFont(int fontNo) {