| Summary: | 3.4.1 fish know detects directories ending in ".cc" as c++ files instead of actually directories | ||
|---|---|---|---|
| Product: | [Unmaintained] kio | Reporter: | Joseph Roback <joe.roback> |
| Component: | fish | Assignee: | Jörg Walter <trouble> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | filip, hsyl20, linuzonix, nicolasg, patrick, rafal.przemyslaw.malinowski, rgpublic, smileaf, stefano.fornari, thomaslanquetin, toralf.foerster, wiedi |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Joseph Roback
2005-06-02 02:06:20 UTC
*** Bug 107219 has been marked as a duplicate of this bug. *** *** Bug 108105 has been marked as a duplicate of this bug. *** Indeed this problem affects any directory with a name that is recognised as an known extension. A lot of the directories on my server end in .au and this opens as a Sun audio file. Seems only to affect the fish:/ slave. Using Arch Linux with KDE 3.4.1 *** Bug 108272 has been marked as a duplicate of this bug. *** After thinking more, I am reverting the status of duplication of bug #108272. The reason is that #106648 can be solved in another way by testing that the filenmae check should be careful about not finding an extension when its is the only file name. However bug #1 *** Bug 108272 has been marked as a duplicate of this bug. *** *** Bug 110646 has been marked as a duplicate of this bug. *** Confirming (3.5 r440440) and raising severity. *** Bug 112347 has been marked as a duplicate of this bug. *** *** Bug 116707 has been marked as a duplicate of this bug. *** Happens for me using fish on 3.4.2, compiled from Gentoo ebuilds. Specifically with directories called .qt and .java... *** Bug 121773 has been marked as a duplicate of this bug. *** See alo bug #122455 (I am not sure that it is exactly the same problem but it is a imilar symptom). *** Bug 122455 has been marked as a duplicate of this bug. *** *** Bug 124421 has been marked as a duplicate of this bug. *** *** Bug 131953 has been marked as a duplicate of this bug. *** SVN commit 570332 by kling:
If remote says it's a directory, go with that instead of guessing the mimetype based on filename.
BUG: 106648
M +12 -5 fish.cpp
--- branches/KDE/3.5/kdebase/kioslave/fish/fish.cpp #570331:570332
@@ -962,18 +962,25 @@
errorCount--;
break;
- case 'M':
+ case 'M': {
+ QString type = line.mid(1);
+
+ // First thing's first. If remote says this is a directory, throw out any
+ // name-based file type guesses.
+ if (type == "inode/directory" && mimeAtom.m_str != type) {
+ mimeAtom.m_str = type;
+ typeAtom.m_long = S_IFDIR;
+ }
// This is getting ugly. file(1) makes some uneducated
// guesses, so we must try to ignore them (#51274)
- if (mimeAtom.m_str.isEmpty() && line.right(8) != "/unknown" &&
+ else if (mimeAtom.m_str.isEmpty() && line.right(8) != "/unknown" &&
(thisFn.find('.') < 0 || (line.left(8) != "Mtext/x-"
&& line != "Mtext/plain"))) {
- mimeAtom.m_str = line.mid(1);
- if ( mimeAtom.m_str == "inode/directory" ) // a symlink to a dir is a dir
- typeAtom.m_long = S_IFDIR;
+ mimeAtom.m_str = type;
}
errorCount--;
break;
+ }
case 'L':
atom.m_uds = UDS_LINK_DEST;
*** Bug 137834 has been marked as a duplicate of this bug. *** |