Bug 106015

Summary:	kfmclient required for external links in Context Browser
Product:	[Applications] amarok	Reporter:	Jonathan Riddell <jr>
Component:	general	Assignee:	Amarok Developers <amarok-bugs-dist>
Status:	RESOLVED FIXED
Severity:	normal	CC:	moixa
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Jonathan Riddell 2005-05-20 12:39:22 UTC

Version:            (using KDE KDE 3.4.0)
Installed from:    Compiled From Sources

If Konqueror is not installed when a user tries to use musicbrainz the error message is

Could not launch the
browser: Could not find service 'kfmclient

A more user friendly message would be

"Konqueror does not seem to be installed, it is required for musicbrainz."

https://bugzilla.ubuntu.com/show_bug.cgi?id=10448

Comment 1 Ian Monroe 2005-05-20 19:35:43 UTC

There's no reason Konqueror should be required for musicbrainz. Its possible the user was clicking the wrong button. I'm on a new computer so didn't have musicbrainz yet, compiling amarok with it now, I'll chmod a-x kfmclient and investigate.

Comment 2 Alexandre Oliveira 2005-05-25 21:15:42 UTC

The problem is not konqueror, it's kfmclient. kfmclient is called by the invokeBrowser function, that will run whatever browser you set as default in kde: http://developer.kde.org/documentation/library/3.3-api/kdecore/html/kapplication_8cpp-source.html#l02272

Comment 3 Philip Brink 2005-09-16 23:13:27 UTC

OTOH, wouldn't it be just as easy to let the user pick which browser they want to use from within amarok? It would allow those without KDE to actually launch a browser.

Comment 4 Peter 2005-09-29 23:33:40 UTC

I like Philip Brink's idea, but:

I'm wondering if the KDE function invokeBrowser is
meant to be hard coded to use kfmclient, or should it check the [General]
BrowserApplication setting in the ~/.kde/share/config/kdeglobals file?

If not, can Amarok do this (check the BrowserApplication setting), rather than
simply using invokeBrowser?

This should also allow Amarok to work without KDE, and without adding an extra option to Amarok.

Comment 5 Mark Kretschmann 2005-12-20 20:20:43 UTC

SVN commit 490088 by markey:

Added option for selecting the external web browser used by amarok. Now, kfmclient and kdebase is no longer required for browser invocation, instead we use amaroK::invokeBrowser().

Currently, konqueror is the default browser. Ideally I would like to use the global kde setting bs default, but I can't figure out how to access it.

BUG: 106015



 M  +2 -0      ChangeLog  
 M  +87 -33    src/Options1.ui  
 M  +6 -3      src/Options1.ui.h  
 M  +1 -0      src/amarokcore/amarok.kcfg  
 M  +12 -1     src/configdialog.cpp  
 M  +8 -8      src/contextbrowser.cpp  
 M  +4 -1      src/firstrunwizard.ui.h  
 M  +1 -3      src/tagdialog.cpp