Bug 105632

Summary: cimg crashes digikam
Product: [Applications] digikam Reporter: Carsten Lohrke <carstenlohrke>
Component: Plugin-Editor-GmicQtAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: crash CC: caulier.gilles
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed In: 5.8.0
Sentry Crash Report:
Attachments: inpainting.settings

Description Carsten Lohrke 2005-05-13 23:45:23 UTC 
Version:           7.3 beta 1,2 (using KDE KDE 3.4.0)
Installed from:    Gentoo Packages
Compiler:          gcc-3.4.3-20050110 C[XX]FLAGS="-O2 -march=athlon-xp -pipe -fforce-addr -mfpmath=sse,387"
OS:                Linux

With both beta versions invoking of any cimg function leads to a crash. 


Using host libthread_db library "/lib/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread 16384 (LWP 5739)]
[New Thread 32769 (LWP 5887)]
[New Thread 16386 (LWP 5888)]
[KCrash handler]
#6  0x42d32582 in cimg_library::CImg<float>::deriche ()
   from /usr/lib/kde3/digikamimageplugin_inpainting.so
#7  0x42d250ac in DigikamImagePlugins::CimgIface::prepare_inpaint ()
   from /usr/lib/kde3/digikamimageplugin_inpainting.so
#8  0x42d25fcb in DigikamImagePlugins::CimgIface::prepare ()
   from /usr/lib/kde3/digikamimageplugin_inpainting.so
#9  0x42d26468 in DigikamImagePlugins::CimgIface::process ()
   from /usr/lib/kde3/digikamimageplugin_inpainting.so
#10 0x42d28af8 in DigikamImagePlugins::CimgIface::startComputation ()
   from /usr/lib/kde3/digikamimageplugin_inpainting.so
#11 0x42d2909d in DigikamImagePlugins::CimgIface::run ()
   from /usr/lib/kde3/digikamimageplugin_inpainting.so
#12 0x40f58de5 in QThreadInstance::start () from /usr/qt/3/lib/libqt-mt.so.3
#13 0x4173918f in pthread_start_thread () from /lib/libpthread.so.0
#14 0x4190b3aa in clone () from /lib/libc.so.6
Comment 1 caulier.gilles 2005-05-24 07:22:45 UTC 
Have you try without gcc optimisations ?

Witch inpainting area size you try to use ?

Thanks in advance.

Gilles Caulier
Comment 2 caulier.gilles 2005-05-24 16:32:34 UTC 
Can you give me the current settings. You can send me a settings file using SaveAs button in plugin dialog.

Thanks in advance.

Gilles Caulier.
Comment 3 Carsten Lohrke 2005-05-24 17:02:09 UTC 
Created attachment 11181 [details]
inpainting.settings

> Have you try without gcc optimisations ? 

No, but Krita's included cimg works without crashes.


> Witch inpainting area size you try to use ? 

Oh, I did not use large images for testing. Not more than a few hundred pixels.
And this bug is not about inpainting - _all_ cimg functions crash digikam.


btw. The "save as" dialog save button has "open" as text on it.
Comment 4 Carsten Lohrke 2005-05-24 17:25:25 UTC 
I have to correct myself. Only inpainting and restoration results in crashes.
Comment 5 caulier.gilles 2005-05-25 08:20:07 UTC 
==> No, but Krita's included cimg works without crashes. 

Warning : Krita do not use exactly the same implementation, espacially i'm use threading, krita no. Too, Greystoration algorithm have been fixed by me using a recent backport from cimg project (fix = speed optimizations). This algorithm is used in Restoration, inpainting and blowup plugins.

Krita do not have backported this fix.

==>  inpainting.settings 
 
Tested on 2 computers (PIV-1.6Ghz and PIV-3Ghz). No crash for me.

Please recompile digikamimageplugins without gcc optimizations, especially '-pipe' and '-fforce-addr', and try again ! 

==> btw. The "save as" dialog save button has "open" as text on it. 

Fixed in SVN.

Gilles Caulier
Comment 6 Carsten Lohrke 2005-05-31 20:51:52 UTC 
He, interestingly an earlier krita cvs build did not crash, beta 2 does.

I tracked the problem down to -mfpmath=sse,387. Either sse or 387 works fine. I have the sse,387 flag combination just enabled for testing, but e.g. on a amd64 (enough registers) with 1 MB Cache it can make sense to use both units.
Comment 7 caulier.gilles 2005-05-31 22:14:41 UTC 
Right, well close this file if the problem isn't relevant of current implementation. Thanks...

Gilles Caulier
Comment 8 caulier.gilles 2005-06-27 07:32:43 UTC 
bug report closed because it relevant of unadapted compilation options.

Gilles Caulier
Comment 9 caulier.gilles 2017-09-05 05:25:37 UTC 
With 5.8.0, in-painting image editor tool was been replaced by a Clone tool.

More details here :

https://community.kde.org/GSoC/2017/StatusReports/shazaismailkaoud

Gilles Caulier