Bug 105455

Summary: the latest mldonkey core responds with "parsing http url" instead of "ok" when sending it a http link to a torrent file, resulting in an error message from kmldonkey_submit
Product: [Applications] kmldonkey Reporter: Mathias Homann <Mathias.Homann>
Component: generalAssignee: Petter Stokke <ummo>
Status: CLOSED FIXED    
Severity: normal    
Priority: NOR    
Version: 0.10   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Mathias Homann 2005-05-11 13:04:39 UTC 
Version:           0.10 (using KDE 3.4.0 Level "b" , SUSE 9.2 UNSUPPORTED)
Compiler:          gcc version 3.3.4 (pre 3.3.5 20040809)
OS:                Linux (i686) release 2.6.8-24.14-default

When i use kmldonkey_submit to send a http link to a torrent file to my mldonkey core (self-compiled MLNet 2.5-30.15), it responds like this:

dllink http://a.scarywater.net/db/[DB]_Naruto_Movie_Intro_Konoha_Sports_Festival_[75057FF3].avi.torrent

----------------------------------
Eval command: dllink http://a.scarywater.net/db/[DB]_Naruto_Movie_Intro_Konoha_Sports_Festival_[75057FF3].avi.torrent

Parsing HTTP url...


instead of the "done" kmldonkey_submit is expecting, leading to an error message. the download works fine, though.
Comment 1 Petter Stokke 2005-07-03 20:32:55 UTC 
*** Bug has been marked as fixed ***.
Comment 2 Elan Ruusamäe 2005-12-18 01:00:28 UTC 
i've got similiar bug, but with ed2k links (proposed patch below)

$ cat ../SOURCES/kmldonkey-submit.patch
my core reports different message back

kmldonkey: Connecting to 1.1.1.1:4001
kmldonkey: CoreProtocol message, version 32
kmldonkey: Using protocol 32
kmldonkey: Authenticating...
kmldonkey: Core reported version 2.5.30.17
kmldonkey: Donkey authenticated.
kmldonkey: Callback count incremented: 1
kmldonkey: Submitted URL: ed2k://|file|
kmldonkey: Callback cmd: dllink "ed2k://|file|
kmldonkey: Callback result: Added link : ed2k://|file|
kmldonkey: Callback count decremented: 0
kmldonkey: Socket closed.
kmldonkey: Donkey disconnected: 0

--- kmldonkey-0.10.1/src/scripts/submit.cpp~    2005-07-26 19:40:40.000000000 +0300
+++ kmldonkey-0.10.1/src/scripts/submit.cpp     2005-12-18 01:53:57.000000000 +0200
@@ -48,7 +48,7 @@
 {
     kdDebug() << "Callback cmd: " << cmd << endl;
     kdDebug() << "Callback result: " << res << endl;
-    if (res.lower() != "done" && !res.contains("parsing http url", false)) {
+    if (res.lower() != "done" && !res.contains("parsing http url", false) && !res.contains("Added link")) {
        /*
        if (res.contains("force_download")) {
            if (KMessageBox::warningYesNo(0, i18n("Failed to submit URL %1\n\nForce download?")
Comment 3 Petter Stokke 2005-12-18 12:04:46 UTC 
I think I fixed that already, will check later.
Comment 4 Petter Stokke 2005-12-18 15:49:13 UTC 
Yes, I've already fixed it. Thanks for the report, though. :)