Bug 105086

Summary:	Display Samba shares' comment fields
Product:	[Applications] dolphin	Reporter:	Stefan Borggraefe <Stefan.Borggraefe>
Component:	general	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	CONFIRMED ---
Severity:	wishlist	CC:	bugseforuns, kfm-devel, nate, sitter, yg
Priority:	NOR	Keywords:	usability
Version:	19.12.2
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Stefan Borggraefe 2005-05-04 13:39:04 UTC

Version:            (using KDE KDE 3.4.0)
Installed from:    Debian testing/unstable Packages
OS:                Linux

Currently there is no way to see the comment of a smb share when using kio-smb. It would be nice if there was a way to see it since these comments tend to include useful information for users.

Comment 1 Harald Sitter 2020-02-13 11:31:34 UTC

https://cgit.kde.org/kio-extras.git/commit/?id=dddafae55363f5d9c51263b4c8a741287dd986c5

This should now be set in KIO::UDS_COMMENT by smb. Unfortunately UDS_COMMENT is not modeled anywhere in dolphin from what I can tell, so it still won't be displayed anywhere.

Bouncing the bug to dolphin.

Comment 2 Harald Sitter 2020-02-13 11:39:28 UTC

Git commit dddafae55363f5d9c51263b4c8a741287dd986c5 by Harald Sitter.
Committed on 13/02/2020 at 11:17.
Pushed by sitter into branch 'master'.

smb: set the share comment as UDS_COMMENT for the UI to display

Summary:
currently this seems to not really have any visibility through dolphin
so concluding the fix also requires changes to dolphin to enable the
comment somewhere. it is technically a column in the details view but
that doesn't actually seem to work

Test Plan: hoping for the best in absence of a UI!

Reviewers: ngraham

Subscribers: kde-frameworks-devel, kfm-devel

Tags: #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D27292

M  +1    -0    smb/kio_smb_browse.cpp

https://commits.kde.org/kio-extras/dddafae55363f5d9c51263b4c8a741287dd986c5