Bug 103941

Summary:	Konqueror does not understand unchecked 'URLs expire after' while loading preferences (Maximum age of History entries=0)
Product:	[Applications] konqueror	Reporter:	Piotr Budny <piotr.budny+bugskde>
Component:	general	Assignee:	Konqueror Bugs <konqueror-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Patch that fixes that bug

Description Piotr Budny 2005-04-15 11:05:35 UTC

Version:            (using KDE KDE 3.4.0)
Installed from:    Unlisted Binary Package
Compiler:          gcc-3.3.5-2 
OS:                Linux

When I uncheck checkbox 'URLs expire after', konqueror saves in konquerorrc the state as Do not expire URLs: Maximum age of History entries=0, that's OK.

But when I open the history preferences dialog again, the checkbox is checked, the number of days is enabled, and it's value is set to 1.
When I do changes on this dialog (even not touching URLs expire after) and I click OK, the preferences dialog saves the new Maximum age to 1. Whilst it should read the state 0 as unckecked URLs expiration age (not to expire) and disabled spinbox.

Comment 1 Piotr Budny 2005-04-16 15:40:02 UTC

Created attachment 10671 [details]
Patch that fixes that bug

I don't know if it is done right, keep in mind I'm the beginner as a developer
in Qt/KDE

Comment 2 Pascal Létourneau 2005-04-19 22:47:59 UTC

CVS commit by pletourn: 

Allow the history to be disabled

BUG:103941


  M +2 -2      kcmhistory.cpp   1.16.2.2


--- kdebase/konqueror/sidebar/trees/history_module/kcmhistory.cpp  #1.16.2.1:1.16.2.2
@@ -60,6 +60,6 @@ HistorySidebarConfig::HistorySidebarConf
     dialog = new KonqSidebarHistoryDlg(this);
 
-    dialog->spinEntries->setRange( 1, INT_MAX, 1, false );
-    dialog->spinExpire->setRange(  1, INT_MAX, 1, false );
+    dialog->spinEntries->setRange( 0, INT_MAX, 1, false );
+    dialog->spinExpire->setRange(  0, INT_MAX, 1, false );
 
     dialog->spinNewer->setRange( 0, INT_MAX, 1, false );