Bug 103769

Summary: tries to send some pastes as commands instead of text
Product: [Applications] konversation Reporter: Michael Gabilondo <eno>
Component: generalAssignee: Konversation Bugs <konversation-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Debian testing   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Michael Gabilondo 2005-04-13 04:46:59 UTC 
Version:           0.17 #3011 (using KDE KDE 3.3.2)
Installed from:    Debian testing/unstable Packages
Compiler:          gcc (GCC) 3.3.5 (Debian 1:3.3.5-8) 
OS:                Linux

To reproduce it:

Try this:
hold down left click to the right of a line of text, passed the text.
then drag the mouse up a bit so the line gets selected.
middle click and press enter.

Example:
so if the line is:
[10:24 pm] <Eno_> do you guys know about the paste bug?

hold down left mouse button to the right of "text" and move the mouse up so the line gets selected

now paste the line and press enter. should get something like this:
[10:43 pm] <Eno_> [10:24 pm] <Eno_> do you guys know about the paste bug?
[10:43 pm] [412] No text to send
[10:43 pm] [421] [10:24 Unknown command

and the actual text doesn't send...

Cause?
if you just double click the line of text to copy it works fine.

the difference seems to be that the broken method copies a new line char before the start of the line... that seems to mess konversation up :)
Comment 1 Ismail Donmez 2005-04-13 21:52:56 UTC 
CVS commit by cartman: 

Don't interpret new lines
BUG:103769


  M +4 -0      outputfilter.cpp   1.151


--- kdeextragear-2/konversation/konversation/outputfilter.cpp  #1.150:1.151
@@ -96,4 +96,8 @@ namespace Konversation {
 
         QString inputLine(originalLine);
+        inputLine.remove("\n");
+
+        if(inputLine.isEmpty())
+          return result;
 
         if(!KonversationApplication::preferences.getDisableExpansion())
Comment 2 Ismail Donmez 2010-07-01 16:03:07 UTC 
commit a46ee581ff5a379575374cecb6c99a1748c90885
Author: İsmail Dönmez <ismail@kde.org>
Date:   Wed Apr 13 19:52:49 2005 +0000

    Don't interpret new lines
    BUG:103769
    
    svn path=/trunk/kdeextragear-2/konversation/; revision=405418

diff --git a/konversation/outputfilter.cpp b/konversation/outputfilter.cpp
index 02fab77..34a1489 100644
--- a/konversation/outputfilter.cpp
+++ b/konversation/outputfilter.cpp
@@ -95,6 +95,10 @@ namespace Konversation {
         destination=name;
 
         QString inputLine(originalLine);
+	inputLine.remove("\n");
+
+	if(inputLine.isEmpty())
+	  return result;
 
         if(!KonversationApplication::preferences.getDisableExpansion())
         {