Bug 103112

Summary:	kmailcvt: lost 'From'-line on import from mbox
Product:	[Unmaintained] kmail	Reporter:	Danny Kukawka <danny.kukawka>
Component:	kmailcvt	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	major
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Danny Kukawka 2005-04-03 06:42:05 UTC

Version:            (using KDE KDE 3.4.0)
Installed from:    Unspecified

If you import a sent-folder/mbox e.g. evolution, mbox or thunderbird kmail display only the first message from the mbox with the correct Sender. For all following messages there is no From-line in the message. 

Looks like we loose the two first lines. This is only a really problem if both lines starts with 'From ' and/or 'From: '.

Comment 1 Danny Kukawka 2005-04-03 06:54:01 UTC

CVS commit by dkukawka: 

fixed bug, lost the first line of every message in a mbox (or similar file
format) because a line was read but newer written to tmpfile. Removed this
unneeded line.

BUGS: 103112


  M +0 -1      filter_evolution.cxx   1.13
  M +0 -1      filter_evolution_v2.cxx   1.11
  M +0 -1      filter_mailapp.cxx   1.8
  M +0 -1      filter_mbox.cxx   1.15
  M +0 -1      filter_opera.cxx   1.8
  M +0 -1      filter_thunderbird.cxx   1.12


--- kdepim/kmailcvt/filter_evolution.cxx  #1.12:1.13
@@ -159,5 +159,4 @@ void FilterEvolution::importMBox(FilterI
       QByteArray input(MAX_LINE);
       QCString seperate;
-      mbox.readLine(input.data(),MAX_LINE);
         
       long l = mbox.readLine( input.data(),MAX_LINE); // read the first line, prevent "From "

--- kdepim/kmailcvt/filter_evolution_v2.cxx  #1.10:1.11
@@ -188,5 +188,4 @@ void FilterEvolution_v2::importMBox(Filt
       QByteArray input(MAX_LINE);
       QCString seperate;
-      mbox.readLine(input.data(),MAX_LINE);
         
       long l = mbox.readLine( input.data(),MAX_LINE); // read the first line, prevent "From "

--- kdepim/kmailcvt/filter_mailapp.cxx  #1.7:1.8
@@ -81,5 +81,4 @@ void FilterMailApp::import(FilterInfo *i
       QByteArray input(MAX_LINE);
       QCString seperate;
-      mbox.readLine(input.data(),MAX_LINE);
         
       long l = mbox.readLine( input.data(),MAX_LINE); // read the first line, prevent "From "

--- kdepim/kmailcvt/filter_mbox.cxx  #1.14:1.15
@@ -75,5 +75,4 @@ void FilterMBox::import(FilterInfo *info
         QByteArray input(MAX_LINE);
         QCString seperate;
-        mbox.readLine(input.data(),MAX_LINE);
         
         long l = mbox.readLine( input.data(),MAX_LINE); // read the first line, prevent "From "

--- kdepim/kmailcvt/filter_opera.cxx  #1.7:1.8
@@ -108,5 +108,4 @@ void FilterOpera::import(FilterInfo *inf
                   QByteArray input(MAX_LINE);
                   QCString seperate;
-                  operaArchiv.readLine(input.data(),MAX_LINE);
          
                   long l = operaArchiv.readLine( input.data(),MAX_LINE); // read the first line, prevent "From "

--- kdepim/kmailcvt/filter_thunderbird.cxx  #1.11:1.12
@@ -185,5 +185,4 @@ void FilterThunderbird::importMBox(Filte
       QByteArray input(MAX_LINE);
       QCString seperate;
-      mbox.readLine(input.data(),MAX_LINE);
         
       long l = mbox.readLine( input.data(),MAX_LINE); // read the first line, prevent "From "

Comment 2 Danny Kukawka 2005-04-04 11:55:08 UTC

CVS commit by dkukawka: 

additional fix for problem with import mails from mbox-files (see
bug# 103112), now we also don't loose the first line of a message

CCBUGS: 103112


  M +9 -3      filter_evolution.cxx   1.14
  M +9 -4      filter_evolution_v2.cxx   1.12
  M +9 -4      filter_mailapp.cxx   1.9
  M +10 -4     filter_mbox.cxx   1.16
  M +8 -2      filter_opera.cxx   1.9
  M +8 -2      filter_thunderbird.cxx   1.13