| Summary: | build error in KDE 3.4 branch | ||
|---|---|---|---|
| Product: | [Unmaintained] kpdf | Reporter: | Ferdinand Gassauer <gassauer> |
| Component: | general | Assignee: | Albert Astals Cid <aacid> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | jb |
| Priority: | NOR | ||
| Version First Reported In: | 0.4.1 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kdenlive/42701f3986ee99f4be470ddd4ab5d2fc8e731fc2 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Ferdinand Gassauer
2005-03-27 11:20:05 UTC
CVS commit by aacid:
Complete the backport to parse width, thanks Ferdinand for reporting
BUG: 102591
M +4 -4 GlobalParams.cc 1.6.4.4
--- kdegraphics/kpdf/xpdf/xpdf/GlobalParams.cc #1.6.4.3:1.6.4.4
@@ -1046,5 +1046,5 @@ FILE *GlobalParams::findToUnicodeFile(GS
// Helvetica-BoldOblique => name=Helvetica, weight=Bold, slant=Oblique
-void parseStyle(QString& name, int& weight, int& slant)
+void parseStyle(QString& name, int& weight, int& slant, int& width)
{
if (!name.contains('-') && !name.contains(',')) return;
@@ -1072,8 +1072,8 @@ DisplayFontParam *GlobalParams::getDispl
// KPDF: try to find font using Xft
if (!dfp) {
- int weight=FC_WEIGHT_MEDIUM, slant=FC_SLANT_ROMAN;
+ int weight=FC_WEIGHT_MEDIUM, slant=FC_SLANT_ROMAN, width=FC_WIDTH_NORMAL;
QString name(fontName->getCString());
- parseStyle(name,weight,slant);
- p = FcPatternBuild(0,FC_FAMILY,FcTypeString, name.ascii(), FC_SLANT, FcTypeInteger, slant, FC_WEIGHT, FcTypeInteger, weight, (char*)0);
+ parseStyle(name,weight,slant,width);
+ p = FcPatternBuild(0,FC_FAMILY,FcTypeString, name.ascii(), FC_SLANT, FcTypeInteger, slant, FC_WEIGHT, FcTypeInteger, weight, FC_WIDTH, FcTypeInteger, width, (char*)0);
if (!p) goto fin;
m = XftFontMatch(qt_xdisplay(),qt_xscreen(),p,&res);
this is not compatible with older fontconfigs that ship with xfree86 4.4 (and maybe 4.5) on mac os x, I get this error: /bin/sh ../../../libtool --mode=compile --tag=CXX g++-3.3 -DHAVE_CONFIG_H -I. -I. -I../../.. -I/sw/lib/freetype219/include/freetype2 -I/sw/lib/freetype219/include -I/usr/X11R6/include -I/usr/X11R6/include/freetype2 -I/usr/X11R6/include -I/usr/X11R6/include -I./.. -I./../fofi -I./../splash -I./../goo -I/sw/include -I/sw/include/qt -I/usr/X11R6/include -I/sw/include -I/usr/X11R6/include -I/sw/include/qt -DQT_THREAD_SUPPORT -I/sw/lib/freetype219/include/freetype2 -I/sw/lib/freetype219/include -I/sw/lib/flex/include -fno-common -no-cpp-precomp -DMACOSX -DARTS_NO_ALARM -I/sw/include -I/usr/X11R6/include -Wnon-virtual-dtor -Wno-long-long -Wundef -Wall -W -Wpointer-arith -Wwrite-strings -Os -Os -fPIC -fno-exceptions -fno-check-new -fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -c -o GlobalParams.lo `test -f 'GlobalParams.cc' || echo './'`GlobalParams.cc g++-3.3 -DHAVE_CONFIG_H -I. -I. -I../../.. -I/sw/lib/freetype219/include/freetype2 -I/sw/lib/freetype219/include -I/usr/X11R6/include -I/usr/X11R6/include/freetype2 -I/usr/X11R6/include -I/usr/X11R6/include -I./.. -I./../fofi -I./../splash -I./../goo -I/sw/include -I/sw/include/qt -I/usr/X11R6/include -I/sw/include -I/usr/X11R6/include -I/sw/include/qt -DQT_THREAD_SUPPORT -I/sw/lib/freetype219/include/freetype2 -I/sw/lib/freetype219/include -I/sw/lib/flex/include -fno-common -no-cpp-precomp -DMACOSX -DARTS_NO_ALARM -I/sw/include -I/usr/X11R6/include -Wnon-virtual-dtor -Wno-long-long -Wundef -Wall -W -Wpointer-arith -Wwrite-strings -Os -Os -fPIC -fno-exceptions -fno-check-new -fno-common -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -c GlobalParams.cc -fno-common -DPIC -o .libs/GlobalParams.o GlobalParams.cc: In function `void parseStyle(QString&, int&, int&, int&)': GlobalParams.cc:1058: error: `FC_WIDTH_CONDENSED' undeclared (first use this function) GlobalParams.cc:1058: error: (Each undeclared identifier is reported only once for each function it appears in.) GlobalParams.cc: In member function `DisplayFontParam* GlobalParams::getDisplayFont(GString*)': GlobalParams.cc:1075: error: `FC_WIDTH_NORMAL' undeclared (first use this function) GlobalParams.cc:1078: error: `FC_WIDTH' undeclared (first use this function) make: *** [GlobalParams.lo] Error 1 From what i see from your compilation line, you are using freetype 2.1.9 that is the same i are using so that is not the problem. I have just encountered what is described in comment #2 using Konstruct on a RH9 machine. kde 3.4 branch? kde 3.4.1? or kde trunk? Re: comment #3, I believe comment #2 is referring to older versions of fontconfig, not freetype. Right, he even said it in his comment, gonna look when that symbols got introduced in fontconfig Well, fontconfig-2.2.0 from 21 April 2003 has support for that symbols, update your fontconfig. Git commit 42701f3986ee99f4be470ddd4ab5d2fc8e731fc2 by Jean-Baptiste Mardelle. Committed on 04/12/2016 at 16:44. Pushed by mardelle into branch 'Applications/16.12'. Disable stem audio export if export audio is disabled M +2 -1 src/dialogs/renderwidget.cpp https://commits.kde.org/kdenlive/42701f3986ee99f4be470ddd4ab5d2fc8e731fc2 Oops, sorry I messed up a copy/paste. My fix was indeed for bug #358450 (Kdenlive) |