Summary: | Rectangular selection and sequence line extension in Sequence Diags. | ||
---|---|---|---|
Product: | [Applications] umbrello | Reporter: | Anton G. Alvedro <galvedro> |
Component: | general | Assignee: | Umbrello Development Group <umbrello-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | NatanaelA |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/umbrello/e7f9fa68d6c4d03e0c2751031b3378ff20fae476 | Version Fixed In: | |
Sentry Crash Report: | |||
Attachments: |
'rectselect.png' - Selecting rectangular area selects messages outside the area.
'rectmove' - message jump to the top after moving a rectangular selection selmove - moving shift-selected messages doesn't move all selected messages rectselect - Selecting rectangular area selects emssages outside the area. |
Description
Anton G. Alvedro
2005-03-15 14:39:52 UTC
This is a pretty serious bug. Because of this bugs it becomes difficult to maintain sequence diagrams. Try inserting a new message in the middle. You'd have to painstakingly select and move each message individually because otherwise your diagram gets totally messed up. 1.3.92 is "ancient" in terms of Umbrello development speed, please use at least 1.4.1 (or better yet, 1.5beta2) Hola, not so quick closing that bug. Shouldn't you verify it first? Anyway, I'm using 1.4.1. This problem is not resolved. Hm, well I tried with the branches/KDE/3.5 of the KDE Subversion repository and it works if you select the *object boxes* (not the messages). However, as far as I recall the corresponding bug was already fixed in 1.4.1. Thanks for checking Oliver. This error report consists of three issues. Let me clarify my findings with each of them. 1. Moving messages after a rectangular select gives unpredicted result As soon as you try to move them the selected messages jump to the top of the diagram, messing it up. This is the biggest problem for me. See attached 'rectmove.png' 2. The rectangular selects messages outside the rectangular area. This is slightly different behavior from the original bug report because it does now select messages (1.4.1). The reason I mention it is that it still doesn't select the intended messages. See attached 'rectselect.png'. The selection area is highlighted red. 'terminate' and '__auditAccounts' are outside the selection rectangle but still selected. 3. Moving messages after shift-selecting. Doesn't move all the selected messages, only the one you happen to have the cursor over. In addition, you cannot move lower beyond the point the object bar reaches down, even if other objects have bars reaching down further. See attached 'shiftmove.png' - Moving 'createModel' down does not move 'hasModel', although both are selected. - 'createModel' cannot be moved further down than shown here. (eg, the object bar runs out of rope :). It really should be able to move down further. Created attachment 13621 [details]
'rectselect.png' - Selecting rectangular area selects messages outside the area.
Created attachment 13622 [details]
'rectmove' - message jump to the top after moving a rectangular selection
Created attachment 13623 [details]
selmove - moving shift-selected messages doesn't move all selected messages
In addition, it doesn't allow you to move beyond the available length of the
object bar.
Created attachment 13624 [details]
rectselect - Selecting rectangular area selects emssages outside the area.
Thanks for providing more info. I confirm your findings. In fact, one of them I've already fixed a few minutes ago - > 3. Moving messages after shift-selecting. > Doesn't move all the selected messages, only the one you > happen to have the cursor over. I found a bug in ToolBarState::setSelectedWidget() that caused not all object boxes to be selectable. This is fixed by the following patch: http://lists.kde.org/?l=kde-commits&m=113277294919534&w=2 SVN commit 482672 by okellogg: setSelectedWidget(): Increment the messages iterator only once. CCMAIL:coolo@kde.org M +0 -1 toolbarstate.cpp --- branches/KDE/3.5/kdesdk/umbrello/umbrello/toolbarstate.cpp #482671:482672 @@ -193,7 +193,6 @@ m_bWidgetSelected = true; return true; } - ++mit; } Git commit e7f9fa68d6c4d03e0c2751031b3378ff20fae476 by Joris Steyn. Committed on 24/02/2014 at 17:40. Pushed by jorissteyn into branch 'master'. Messages can be selected using the mouse Selecting and moving multiple messages was already possible using Control-click. This commit adds mouse support. Related: bug 106915 M +59 -43 umbrello/umlscene.cpp M +1 -1 umbrello/umlscene.h http://commits.kde.org/umbrello/e7f9fa68d6c4d03e0c2751031b3378ff20fae476 |