Summary: | Support for window.frameElement in DOM | ||
---|---|---|---|
Product: | [Applications] konqueror | Reporter: | Juan Carlos Estibariz <leon_es00-kde> |
Component: | khtml ecma | Assignee: | Konqueror Developers <konq-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Juan Carlos Estibariz
2005-03-13 21:20:10 UTC
Any uses in actual webpages? We use it in a product that our company (Quest Software) is developing, it is very helpful when the scripts should work with multiple frames. Google use it in Google Suggest http://www.google.com/webhp?complete=1&hl=en CVS commit by carewolf: Implement frame.contentWindow and window.frameElement. FEATURE: 99318, 101442 Notes: Fixes Google Suggest again. It seems the new GMail also uses them, but this alone appears to fix nothing. M +5 -0 ChangeLog 1.415 M +16 -0 ecma/kjs_html.cpp 1.281 M +4 -2 ecma/kjs_html.h 1.84 M +3 -0 ecma/kjs_window.cpp 1.400 M +1 -1 ecma/kjs_window.h 1.111 CVS commit by carewolf: Implement window.frameElement correctly CCBUG:101442 M +4 -1 kjs_window.cpp 1.402 --- kdelibs/khtml/ecma/kjs_window.cpp #1.401:1.402 @@ -574,5 +574,8 @@ Value Window::get(ExecState *exec, const return getDOMNode(exec,part->document()); case FrameElement: - return retrieve(m_frame->m_part); + if (m_frame->m_frame) + return getDOMNode(exec,m_frame->m_frame->element()); + else + return Undefined(); case Node: return getNodeConstructor(exec); |