Bug 101413

Summary: User closing a khtmlpart tab before the page is loaded crashes akregator
Product: [Applications] akregator Reporter: Joonas Koivunen <joonas.koivunen>
Component: akregator konqueror pluginAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: crash CC: amitshah, cerebro84, lderkacz, symbiont
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Joonas Koivunen 2005-03-13 08:57:20 UTC 
Version:            (using KDE KDE 3.4.0)
Installed from:    Compiled From Sources
OS:                Linux

I just had a quite long delay, perhaps the delay affected http kioslave and the creation of browser was delayed too. I decided to close down the tab as nothing was happening.

A few seconds later the slave connected the host and khtmlpart started opening the page to an nonexistant tab and widget..

I think that this is pretty trivial to fix, ask me if I explained this too complexly.

Backtrace:
Using host libthread_db library "/lib/libthread_db.so.1".
[Thread debugging using libthread_db enabled]
[New Thread 16384 (LWP 1424)]
[KCrash handler]
#4  0x4155c8ea in QTimer::stop () from /usr/lib/qt/lib/libqt-mt.so.3
#5  0x40115f1f in KHTMLPart::openURL ()
   from /home/rzei/kdecvs/lib/libkhtml.so.4
#6  0x420d30a5 in Akregator::BrowserRun::foundMimeType ()
   from /home/rzei/kdecvs/lib/kde3/libakregatorpart.so
#7  0x40940660 in KParts::BrowserRun::slotBrowserMimetype ()
   from /home/rzei/kdecvs/lib/libkparts.so.2
#8  0x409437d2 in KParts::BrowserRun::qt_invoke ()
   from /home/rzei/kdecvs/lib/libkparts.so.2
#9  0x420d3224 in Akregator::BrowserRun::qt_invoke ()
   from /home/rzei/kdecvs/lib/kde3/libakregatorpart.so
#10 0x4153b11c in QObject::activate_signal ()
   from /usr/lib/qt/lib/libqt-mt.so.3
#11 0x40ab0444 in KIO::TransferJob::mimetype ()
   from /home/rzei/kdecvs/lib/libkio.so.4
#12 0x40a9a2e3 in KIO::TransferJob::slotMimetype ()
   from /home/rzei/kdecvs/lib/libkio.so.4
#13 0x40ab05f1 in KIO::TransferJob::qt_invoke ()
   from /home/rzei/kdecvs/lib/libkio.so.4
#14 0x4153b11c in QObject::activate_signal ()
   from /usr/lib/qt/lib/libqt-mt.so.3
#15 0x4153b5bd in QObject::activate_signal ()
   from /usr/lib/qt/lib/libqt-mt.so.3
#16 0x40a87a6b in KIO::SlaveInterface::mimeType ()
   from /home/rzei/kdecvs/lib/libkio.so.4
#17 0x40a8355e in KIO::SlaveInterface::dispatch ()
   from /home/rzei/kdecvs/lib/libkio.so.4
#18 0x40a83067 in KIO::SlaveInterface::dispatch ()
   from /home/rzei/kdecvs/lib/libkio.so.4
#19 0x40a7fe37 in KIO::Slave::gotInput ()
   from /home/rzei/kdecvs/lib/libkio.so.4
#20 0x40a82599 in KIO::Slave::qt_invoke ()
   from /home/rzei/kdecvs/lib/libkio.so.4
#21 0x4153b11c in QObject::activate_signal ()
   from /usr/lib/qt/lib/libqt-mt.so.3
#22 0x4153b27d in QObject::activate_signal ()
   from /usr/lib/qt/lib/libqt-mt.so.3
#23 0x4185d972 in QSocketNotifier::activated ()
   from /usr/lib/qt/lib/libqt-mt.so.3
#24 0x415578e0 in QSocketNotifier::event () from /usr/lib/qt/lib/libqt-mt.so.3
#25 0x414de7df in QApplication::internalNotify ()
   from /usr/lib/qt/lib/libqt-mt.so.3
#26 0x414dddde in QApplication::notify () from /usr/lib/qt/lib/libqt-mt.so.3
#27 0x41081c0b in KApplication::notify ()
   from /home/rzei/kdecvs/lib/libkdecore.so.4
#28 0x414ce1ea in QEventLoop::activateSocketNotifiers ()
   from /usr/lib/qt/lib/libqt-mt.so.3
#29 0x414888c3 in QEventLoop::processEvents ()
   from /usr/lib/qt/lib/libqt-mt.so.3
#30 0x414f0b38 in QEventLoop::enterLoop () from /usr/lib/qt/lib/libqt-mt.so.3
#31 0x414f09e8 in QEventLoop::exec () from /usr/lib/qt/lib/libqt-mt.so.3
#32 0x414dea31 in QApplication::exec () from /usr/lib/qt/lib/libqt-mt.so.3
#33 0x080504f9 in main ()
Comment 1 Teemu Rytilahti 2005-03-19 13:59:48 UTC 
*** Bug 101789 has been marked as a duplicate of this bug. ***
Comment 2 Teemu Rytilahti 2005-03-19 18:43:21 UTC 
CVS commit by rytilahti: 

Okay, finally. Make BrowserRun to delete itself when Viewer got destroyed...
BUGS:101413


  M +7 -0      akregator_run.cpp   1.8
  M +3 -0      akregator_run.h   1.5


--- kdepim/akregator/src/akregator_run.cpp  #1.7:1.8
@@ -35,4 +35,5 @@ BrowserRun::BrowserRun(Viewer *viewer, Q
 {
     m_viewer=viewer;
+    connect(m_viewer, SIGNAL(destroyed()), this, SLOT(killMyself()));
 }
 
@@ -50,4 +51,10 @@ void BrowserRun::foundMimeType( const QS
 }
 
+void BrowserRun::killMyself()
+{
+    kdDebug() << "BrowserRun::killMyself()" << endl;
+    delete this;
+}
+
 #include "akregator_run.moc"
 

--- kdepim/akregator/src/akregator_run.h  #1.4:1.5
@@ -43,4 +43,7 @@ namespace Akregator
             virtual void foundMimeType( const QString & _type );
 
+    private slots:
+        void killMyself();
+
     private:
         Viewer *m_viewer;
Comment 3 Teemu Rytilahti 2005-03-19 18:54:40 UTC 
CVS commit by rytilahti: 

backport for bug 101413
CCBUGS:101413


  M +7 -0      akregator_run.cpp   1.5.6.3
  M +3 -0      akregator_run.h   1.3.6.2


--- kdepim/akregator/src/akregator_run.cpp  #1.5.6.2:1.5.6.3
@@ -35,4 +35,5 @@ BrowserRun::BrowserRun(Viewer *viewer, Q
 {
     m_viewer=viewer;
+    connect(m_viewer, SIGNAL(destroyed()), this, SLOT(killMyself()));
 }
 
@@ -50,4 +51,10 @@ void BrowserRun::foundMimeType( const QS
 }
 
+void BrowserRun::killMyself()
+{
+    kdDebug() << "BrowserRun::killMyself()" << endl;
+    delete this;
+}
+
 #include "akregator_run.moc"
 

--- kdepim/akregator/src/akregator_run.h  #1.3.6.1:1.3.6.2
@@ -43,4 +43,7 @@ namespace Akregator
             virtual void foundMimeType( const QString & _type );
 
+    private slots:
+        void killMyself();
+
     private:
         Viewer *m_viewer;
Comment 4 Teemu Rytilahti 2005-03-19 18:57:30 UTC 
*** Bug 100405 has been marked as a duplicate of this bug. ***
Comment 5 Teemu Rytilahti 2005-03-24 09:20:22 UTC 
*** Bug 102346 has been marked as a duplicate of this bug. ***
Comment 6 Teemu Rytilahti 2005-03-24 12:28:17 UTC 
Oh, and 1.0.2 fixes this bug, don't know how it should made available to KDE 3.4 users, but it'll be in 3.4.1 at least...
Comment 7 Frank Osterfeld 2005-03-24 13:04:32 UTC 
> Oh, and 1.0.2 fixes this bug

No, 1.0.2 is 1.0 + forms + notification in kontact + delete articles older than/disable archiving fixes, nothing else
Comment 8 Teemu Rytilahti 2005-03-24 17:26:52 UTC 
*** Bug 102360 has been marked as a duplicate of this bug. ***