| Summary: | doesn't compile on KDE 3.3 | ||
|---|---|---|---|
| Product: | [Unmaintained] kopete | Reporter: | Jan Ritzerfeld <kde> |
| Component: | general | Assignee: | Kopete Developers <kopete-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | ||
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
I've committed this fix. with regard to your jabber message, "why not KDE_IS_VERSION(3,9,0)?", 3,9,0 means 3.4beta1, whereas 3.4.0 is 3.4rc1 and later. How many people are still using beta1? It's not worth changing the code now for them. |
Version: 0.10.90 from CVS (using KDE KDE 3.3.2) Installed from: SuSE RPMs There is only one method of KDE 3.4 used: jan@linux:~/Dev/kdenetwork/kopete> cvs diff kopete/chatwindow/kopetechatwindow.cpp Index: kopete/chatwindow/kopetechatwindow.cpp =================================================================== RCS file: /home/kde/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp,v retrieving revision 1.103 diff -u -3 -p -r1.103 kopetechatwindow.cpp --- kopete/chatwindow/kopetechatwindow.cpp 7 Mar 2005 21:47:04 -0000 1.103 +++ kopete/chatwindow/kopetechatwindow.cpp 12 Mar 2005 15:26:13 -0000 @@ -545,7 +545,9 @@ void KopeteChatWindow::createTabBar() m_tabBar->setSizePolicy( QSizePolicy( QSizePolicy::Expanding, QSizePolicy::Expanding ) ); m_tabBar->setHoverCloseButton(KGlobal::config()->readBoolEntry( QString::fromLatin1("HoverClose"), false )); m_tabBar->setTabReorderingEnabled(true); +#if KDE_IS_VERSION(3,4,0) m_tabBar->setAutomaticResizeTabs(true); +#endif connect( m_tabBar, SIGNAL( closeRequest( QWidget* )), this, SLOT( slotCloseChat( QWidget* ) ) ); QToolButton* m_rightWidget = new QToolButton( m_tabBar );