Bug 100991

Summary: improper image count after delete
Product: [Applications] digikam Reporter: M. Asselstine <masse_74>
Component: Albums-TrashAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Debian testing   
OS: Linux   
Latest Commit: Version Fixed In: 7.5.0
Sentry Crash Report:
Attachments: possible fix

Description M. Asselstine 2005-03-06 20:03:36 UTC 
Version:           cvs (using KDE KDE 3.3.2)
Installed from:    Debian testing/unstable Packages
Compiler:          gcc 3.3.5 
OS:                Linux

If you "Move to Trash" an image or delete an image in konqueror with the associated album selected in digikam the image thumbnail is removed but the album banner displays the old count still.
Comment 1 Renchi Raju 2005-03-06 20:10:48 UTC 
CVS commit by pahlibar: 



update image count after file removal
BUGS: 100991


  M +1 -0      albumiconview.cpp   1.110


--- kdeextragear-3/digikam/digikam/albumiconview.cpp  #1.109:1.110
@@ -1955,4 +1955,5 @@ void AlbumIconView::slotRearrange()
         return;
 
+    updateBanner();
     slotUpdate();
 }
Comment 2 M. Asselstine 2005-03-06 21:32:03 UTC 
Created attachment 10005 [details]
possible fix

I am not very familiar with the digikam source but the attached patch might
help. You are deleting the item but not updating the banner.
Comment 3 Joern Ahrens 2005-03-07 09:52:21 UTC 
Thanks for your Patch, but sadly Renchi was a little bit faster with his his patch. Actually this patch was done three times - you, renchi and me :)

But patches are always welcome, so go ahead and pick up the next one :-)
Comment 4 M. Asselstine 2005-03-07 14:58:20 UTC 
Not as quick as I used to be now that I have offspring. Noticed that Renchi already fixed this AFTER I submitted my fix. I plan on making a plugin to add the date based on the exif info to a photo. So you might see more from me. I would recommend that the call to updateBanner() be consolidated so that it is not called too often, just a thought. As well on a curious note, why is there no documentation?? other than only a few comments in the code.

Anyhow love the app, keep up the good work.

Mark