Bug 100990

Summary:	digikam: loading curves does not update preview
Product:	[Applications] digikam	Reporter:	missive
Component:	Plugin-Editor-Curves	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	0.7.1
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:	7.6.0
Sentry Crash Report:

Description missive 2005-03-06 19:52:00 UTC

Version:           0.7.1 (using KDE 3.3.2, Gentoo)
Compiler:          gcc version 3.3.5 (Gentoo Linux 3.3.5-r1, ssp-3.3.2-3, pie-8.7.7.1)
OS:                Linux (i686) release 2.6.10

when using Fix->Colors->Curves Adjust, I can load my saved gimp curve files (works perfectly, thank you very much), but the "Target" display is not updated until I make a change to the curve.

Also, if I then load another curve from my gimp curve files the load starts over from my home folder instead of going back to the .gimp/curves folder where I was working.

Digikam is looking amazing recently. Keep up the great work!

Comment 1 caulier.gilles 2005-03-07 10:00:18 UTC

CVS commit by cgilles: 

AdjustCurves digiKam image editor plugin fixed in CVS.
BUGS:100990
CCBUGS:100990


  M +6 -9      adjustcurves.cpp   1.15
  M +1 -1      adjustcurves.h   1.5


--- kdeextragear-3/digikamimageplugins/adjustcurves/adjustcurves.cpp  #1.14:1.15
@@ -5,5 +5,5 @@
  * Description : image histogram adjust curves.
  *
- * Copyright 2004 by Gilles Caulier
+ * Copyright 2004-2005 by Gilles Caulier
  *
  * This program is free software; you can redistribute it
@@ -329,9 +329,7 @@ void AdjustCurveDialog::slotPositionChan
 void AdjustCurveDialog::slotEffect()
 {
-    Digikam::ImageIface* ifaceOrg =
-        m_previewOriginalWidget->imageIface();
+    Digikam::ImageIface* ifaceOrg = m_previewOriginalWidget->imageIface();
 
-    Digikam::ImageIface* ifaceDest =
-        m_previewTargetWidget->imageIface();
+    Digikam::ImageIface* ifaceDest = m_previewTargetWidget->imageIface();
 
     uint* orgData = ifaceOrg->getPreviewData();
@@ -357,9 +355,7 @@ void AdjustCurveDialog::slotEffect()
 void AdjustCurveDialog::slotOk()
 {
-    Digikam::ImageIface* ifaceOrg =
-        m_previewOriginalWidget->imageIface();
+    Digikam::ImageIface* ifaceOrg = m_previewOriginalWidget->imageIface();
 
-    Digikam::ImageIface* ifaceDest =
-        m_previewTargetWidget->imageIface();
+    Digikam::ImageIface* ifaceDest = m_previewTargetWidget->imageIface();
 
     uint* orgData = ifaceOrg->getOriginalData();
@@ -468,4 +464,5 @@ void AdjustCurveDialog::slotLoadCurves()
     // Refresh the current curves config.
     slotChannelChanged(m_channelCB->currentItem());
+    slotEffect();
 }
 

--- kdeextragear-3/digikamimageplugins/adjustcurves/adjustcurves.h  #1.4:1.5
@@ -5,5 +5,5 @@
  * Description : image histogram adjust curves. 
  * 
- * Copyright 2004 by Gilles Caulier
+ * Copyright 2004-2005 by Gilles Caulier
  *
  * This program is free software; you can redistribute it

Comment 2 caulier.gilles 2005-03-07 10:00:19 UTC

CVS commit by cgilles: 

AdjustCurves digiKam image editor plugin fixed in CVS.
BUGS:100990
CCBUGS:100990


  M +6 -9      adjustcurves.cpp   1.15
  M +1 -1      adjustcurves.h   1.5


--- kdeextragear-3/digikamimageplugins/adjustcurves/adjustcurves.cpp  #1.14:1.15
@@ -5,5 +5,5 @@
  * Description : image histogram adjust curves.
  *
- * Copyright 2004 by Gilles Caulier
+ * Copyright 2004-2005 by Gilles Caulier
  *
  * This program is free software; you can redistribute it
@@ -329,9 +329,7 @@ void AdjustCurveDialog::slotPositionChan
 void AdjustCurveDialog::slotEffect()
 {
-    Digikam::ImageIface* ifaceOrg =
-        m_previewOriginalWidget->imageIface();
+    Digikam::ImageIface* ifaceOrg = m_previewOriginalWidget->imageIface();
 
-    Digikam::ImageIface* ifaceDest =
-        m_previewTargetWidget->imageIface();
+    Digikam::ImageIface* ifaceDest = m_previewTargetWidget->imageIface();
 
     uint* orgData = ifaceOrg->getPreviewData();
@@ -357,9 +355,7 @@ void AdjustCurveDialog::slotEffect()
 void AdjustCurveDialog::slotOk()
 {
-    Digikam::ImageIface* ifaceOrg =
-        m_previewOriginalWidget->imageIface();
+    Digikam::ImageIface* ifaceOrg = m_previewOriginalWidget->imageIface();
 
-    Digikam::ImageIface* ifaceDest =
-        m_previewTargetWidget->imageIface();
+    Digikam::ImageIface* ifaceDest = m_previewTargetWidget->imageIface();
 
     uint* orgData = ifaceOrg->getOriginalData();
@@ -468,4 +464,5 @@ void AdjustCurveDialog::slotLoadCurves()
     // Refresh the current curves config.
     slotChannelChanged(m_channelCB->currentItem());
+    slotEffect();
 }
 

--- kdeextragear-3/digikamimageplugins/adjustcurves/adjustcurves.h  #1.4:1.5
@@ -5,5 +5,5 @@
  * Description : image histogram adjust curves. 
  * 
- * Copyright 2004 by Gilles Caulier
+ * Copyright 2004-2005 by Gilles Caulier
  *
  * This program is free software; you can redistribute it