Bug 100105

Summary: insertRow does not work if a caption has been appended to a table
Product: [Applications] konqueror Reporter: Kae Verens <kae>
Component: khtmlAssignee: Maksim Orlovich <maksim>
Status: RESOLVED FIXED    
Severity: normal CC: maksim
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: RedHat Enterprise Linux   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Kae Verens 2005-02-23 18:29:58 UTC 
Version:            (using KDE KDE 3.3.1)
Installed from:    RedHat RPMs
OS:                Linux

I have created a test-case here: http://kae.verens.com/bugs/konqueror.3.3.1.insertRow.html

Once a caption has been created dynamically, insertRow causes an error in Konqueror.
Comment 1 Kae Verens 2005-02-23 18:32:20 UTC 
I'm not sure how this got assigned to Ark - I chose the kjs component while submitting it! Maybe this is a bug in Bugzilla?
Comment 2 Harri Porten 2005-05-07 14:51:34 UTC 
The bug must be somewhere in the html implementation.
Comment 3 Kae Verens 2005-12-07 15:04:12 UTC 
just noticed the example URL is no longer correct. here is a more uptodate one:
http://kae.verens.com/bugs/konqueror.3.3.1.insertRow.html 

the problem is still there - KDE 3.5 built with Konstruct.
Comment 4 Kae Verens 2005-12-07 15:04:52 UTC 
damn... here's the right address:
http://verens.com/bugs/konqueror.3.3.1.insertRow.html
Comment 5 Maksim Orlovich 2006-03-05 00:43:45 UTC 
SVN commit 515817 by orlovich:

Some signficant fixes in the table DOM code:
1. Properly keep track of alterations to DOM structure
so we do not end up with dangling or stale pointers
2. Properly implement logical order in insert/deleteRow.
   Also fix implicit body creation code for insertRow. 
   Essentially, improperly nested tr's are invisible to the DOM code
   (and in IE, they're even invisible on the screen!)
   
3. Be more robust, compatible with other browsers,
in handling of malformed dom-created tables:
    -Ignore <tr>'s directly under table in the rows collection
    -In tsection code do not assume only <tr>'s will be there
    
BUG: 119697
BUG: 100105


 M  +28 -46    html/html_miscimpl.cpp  
 M  +4 -2      html/html_miscimpl.h  
 M  +200 -161  html/html_tableimpl.cpp  
 M  +90 -8     html/html_tableimpl.h  
 M  +3 -3      xml/dom_nodeimpl.cpp  
 M  +2 -1      xml/dom_nodeimpl.h