88369 2004-08-29 11:08:27 +0000 when delivery-method is renamed this is not populated 2007-09-14 12:17:01 +0000 1 1 10 Unmaintained kmail general unspecified unspecified Linux RESOLVED FIXED NOR normal --- 0 sven.burmeister pim-bugs-null 20 oldest_to_newest 263853 0 sven.burmeister 2004-08-29 11:08:27 +0000 Version: (using KDE KDE 3.3.0) OS: Linux When renaming a delivery-method this is not done for the identities that use it, as a result these use invalid delivery-methods. 264746 1 sanders 2004-09-01 09:21:00 +0000 I find this report to be unintelligible. Maybe if I spent 10 minutes trying to figure out what it meant I might be able to do it, but instead I will look/wait for a more intelligible report. I don't mean to be rude here. It's just that I spent an hour working my way through 170 reports without finding a single one with any useful information. 264834 2 sven.burmeister 2004-09-01 15:16:49 +0000 Am Mittwoch, 1. September 2004 09:21 schrieb Don Sanders: > ------- Additional Comments From sanders kde org 2004-09-01 09:21 ------- > I find this report to be unintelligible. Maybe if I spent 10 minutes trying > to figure out what it meant I might be able to do it, but instead I will > look/wait for a more intelligible report. 1. Go to kmail configuration 1.1 In case you do not have set up a delivery method, do so, name it xyz 2. Go to identities configuration 3. Create an identity, name it itsme 4. Edit that identity 5. Go to its advanced tab 6. Find box for special delivery-method at the bottom of the tab 7. Activate special-delivery using the delivery-profile xyz 8. Close configuration 2nd Part 1. Open kmail configuration 2. Go to network 3. Rename delivery-method xyz to 000 3rd Part 1. Go to identities in kmail configuration 2. Edit the itsme identity 3. Go to the advanced tab 4. Look at that special-delivery method config at the bottom of the tab 5. Notice that it still states xyz although that delivery-method was renamed, hence this identity uses a non-existent delivery-method! 4th Part Solution 1: (IMHO best) When setting a delivery-method for an identity, kmail should not save its name but an ID. This way when renaming the delivery-method the ID stays the same and only the attribute name is changed. I think Mozilla does it this way. Solution 2: If a delivery-mehtod is renamed, mediate this to the identity using it, making it rename its setting too. Solution 3: Complain about identities using a non-existent delivery-method. The reason why this bug is a problem is that if you send an email with kmail using a non-existing delivery-method, it does not send the email but does not complain either, so the user does not know why the emai is not send. 265145 3 sanders 2004-09-02 11:26:58 +0000 Thanks I can understand this now. 344114 4 mdouhan 2005-05-21 22:38:35 +0000 In current HEAD / Trunk there is a sanity checker that automatically removes transports that no longer exists and resets them to useful values. Can you please test if this problem still remains with current trunk/HEAD? 484333 5 18422 mdouhan 2006-11-05 19:51:39 +0000 Created attachment 18422 Patch to update idents with renamed transports This patch updates all transports that used the original transport and sets it to the new name thus keeping the integrity. 488673 6 winter 2006-11-21 16:54:30 +0000 SVN commit 606743 by winterz: Patch from Matt, fixes "when delivery-method is renamed this is not populated". Approved by Till. Thanks Matt. CCMAIL: matt.douhan@kdemail.net BUGS: 88369 M +20 -0 configuredialog.cpp --- branches/KDE/3.5/kdepim/kmail/configuredialog.cpp #606742:606743 @@ -841,6 +841,8 @@ QListViewItem *item = mTransportList->selectedItem(); if ( !item ) return; + const QString& originalTransport = item->text(0); + QPtrListIterator<KMTransportInfo> it( mTransportInfoList ); for ( it.toFirst() ; it.current() ; ++it ) if ( (*it)->name == item->text(0) ) break; @@ -869,6 +871,24 @@ // and insert the new name at the position of the old in the list of // strings; then broadcast the new list: transportNames.insert( transportNames.at( entryLocation ), (*it)->name ); + const QString& newTransportName = (*it)->name; + + QStringList changedIdents; + KPIM::IdentityManager * im = kmkernel->identityManager(); + for ( KPIM::IdentityManager::Iterator it = im->modifyBegin(); it != im->modifyEnd(); ++it ) { + if ( originalTransport == (*it).transport() ) { + (*it).setTransport( newTransportName ); + changedIdents += (*it).identityName(); + } + } + + if ( !changedIdents.isEmpty() ) { + QString information = i18n( "This identity has been changed to use the modified transport:", + "These %n identities have been changed to use the modified transport:", + changedIdents.count() ); + KMessageBox::informationList( this, information, changedIdents ); + } + emit transportListChanged( transportNames ); emit changed( true ); } 18422 2006-11-05 19:51:39 +0000 2006-11-05 19:51:39 +0000 Patch to update idents with renamed transports transportbug_88369.diff text/plain 1545 mdouhan SW5kZXg6IGNvbmZpZ3VyZWRpYWxvZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gY29uZmlndXJlZGlhbG9n LmNwcAkocmV2aXNpb24gNjAyMzQ3KQorKysgY29uZmlndXJlZGlhbG9nLmNwcAkod29ya2luZyBj b3B5KQpAQCAtODU0LDYgKzg1NCw4IEBACiAgIFFMaXN0Vmlld0l0ZW0gKml0ZW0gPSBtVHJhbnNw b3J0TGlzdC0+c2VsZWN0ZWRJdGVtKCk7CiAgIGlmICggIWl0ZW0gKSByZXR1cm47CiAKKyAgY29u c3QgUVN0cmluZyYgb3JpZ2luYWxUcmFuc3BvcnQgPSBpdGVtLT50ZXh0KDApOworCiAgIFFQdHJM aXN0SXRlcmF0b3I8S01UcmFuc3BvcnRJbmZvPiBpdCggbVRyYW5zcG9ydEluZm9MaXN0ICk7CiAg IGZvciAoIGl0LnRvRmlyc3QoKSA7IGl0LmN1cnJlbnQoKSA7ICsraXQgKQogICAgIGlmICggKCpp dCktPm5hbWUgPT0gaXRlbS0+dGV4dCgwKSApIGJyZWFrOwpAQCAtODgyLDYgKzg4NCwyNCBAQAog ICAvLyBhbmQgaW5zZXJ0IHRoZSBuZXcgbmFtZSBhdCB0aGUgcG9zaXRpb24gb2YgdGhlIG9sZCBp biB0aGUgbGlzdCBvZgogICAvLyBzdHJpbmdzOyB0aGVuIGJyb2FkY2FzdCB0aGUgbmV3IGxpc3Q6 CiAgIHRyYW5zcG9ydE5hbWVzLmluc2VydCggdHJhbnNwb3J0TmFtZXMuYXQoIGVudHJ5TG9jYXRp b24gKSwgKCppdCktPm5hbWUgKTsKKyAgY29uc3QgUVN0cmluZyYgbmV3VHJhbnNwb3J0TmFtZSA9 ICgqaXQpLT5uYW1lOworCisgIFFTdHJpbmdMaXN0IGNoYW5nZWRJZGVudHM7CisgIEtQSU06Oklk ZW50aXR5TWFuYWdlciAqIGltID0ga21rZXJuZWwtPmlkZW50aXR5TWFuYWdlcigpOworICBmb3Ig KCBLUElNOjpJZGVudGl0eU1hbmFnZXI6Okl0ZXJhdG9yIGl0ID0gaW0tPm1vZGlmeUJlZ2luKCk7 IGl0ICE9IGltLT5tb2RpZnlFbmQoKTsgKytpdCApIHsKKyAgICBpZiAoIG9yaWdpbmFsVHJhbnNw b3J0ID09ICgqaXQpLnRyYW5zcG9ydCgpICkgeworICAgICAgKCppdCkuc2V0VHJhbnNwb3J0KCBu ZXdUcmFuc3BvcnROYW1lICk7CisgICAgICBjaGFuZ2VkSWRlbnRzICs9ICgqaXQpLmlkZW50aXR5 TmFtZSgpOworICAgIH0KKyAgfQorCisgIGlmICggIWNoYW5nZWRJZGVudHMuaXNFbXB0eSgpICkg eworICAgIFFTdHJpbmcgaW5mb3JtYXRpb24gPSBpMThuKCAiVGhpcyBpZGVudGl0eSBoYXMgYmVl biBjaGFuZ2VkIHRvIHVzZSB0aGUgbW9kaWZpZWQgdHJhbnNwb3J0OiIsCisgICAgICAgICAgICAg ICAgICAgICAgICAgICJUaGVzZSAlbiBpZGVudGl0aWVzIGhhdmUgYmVlbiBjaGFuZ2VkIHRvIHVz ZSB0aGUgbW9kaWZpZWQgdHJhbnNwb3J0OiIsCisgICAgICAgICAgICAgICAgICAgICAgICAgIGNo YW5nZWRJZGVudHMuY291bnQoKSApOworICAgIEtNZXNzYWdlQm94OjppbmZvcm1hdGlvbkxpc3Qo IHRoaXMsIGluZm9ybWF0aW9uLCBjaGFuZ2VkSWRlbnRzICk7CisgIH0KKwogICBlbWl0IHRyYW5z cG9ydExpc3RDaGFuZ2VkKCB0cmFuc3BvcnROYW1lcyApOwogICBlbWl0IGNoYW5nZWQoIHRydWUg KTsKIH0K