87274 2004-08-15 23:14:35 +0000 Cycling trough konsole tabs with keyboard (shift arrow) causes terminal size to be printed on screen every time. 2004-09-16 23:09:21 +0000 1 1 2 Applications konsole general unspecified Debian testing Linux RESOLVED FIXED NOR normal --- 1 galen konsole-bugs-null michal news 0 oldest_to_newest 259064 0 galen 2004-08-15 23:14:35 +0000 Version: (using KDE KDE 3.3.0) Installed from: Debian testing/unstable Packages OS: Linux Switching between konsole tabs with keyboard shortcuts makes it show its window size every time which is kind of annoying. It does not happen when swiching between tabs with mouse. 259102 1 binner 2004-08-16 07:30:37 +0000 *** Bug 87066 has been marked as a duplicate of this bug. *** 259877 2 khindenburg 2004-08-18 18:27:11 +0000 Disable Settings->Configure Konsole->General->Show terminal size after resizing 259881 3 khindenburg 2004-08-18 18:35:48 +0000 Perhaps the config text should read 'Show terminal size after resizing or changing tabs via shortcuts' Hmm, that's kinda long... 259884 4 bastian 2004-08-18 18:51:41 +0000 Switching tabs shouldn't cause a resize. It's a bug if it does. That you get the window size indicator is a symptom of the problem, it's not the cause. 259903 5 khindenburg 2004-08-18 20:26:30 +0000 On the surface, it appears that setFont is the cause of this in void Konsole::activateSession(TESession *s) konsole: Konsole::activateSession before setFont konsole: TEWidget::setVTfont() konsole: TEWidget::fontChange() konsole: TEWidget::propagateSize() konsole: TEWidget::updateImageSize() konsole: TESession::onContentSizeChange 531 804 konsole: TEmulation::onImageSizeChange() konsole: Konsole::activateSession after setFont konsole: Konsole::activateSession before setFont konsole: TEWidget::setVTfont() konsole: TEWidget::fontChange() konsole: TEWidget::propagateSize() konsole: TEWidget::updateImageSize() konsole: TESession::onContentSizeChange 531 804 konsole: TEmulation::onImageSizeChange() konsole: Konsole::activateSession after setFont void TEWidget::setImage is where the resizing/info window popups from. I'll look at this later. 260131 6 7182 khindenburg 2004-08-19 17:28:53 +0000 Created attachment 7182 disallow 'resize' when switching tabs When switching tabs, skip: selectBell->setCurrentItem(te->bellMode()); setFont(se->fontNo()); updateSchemaMenu(); 260141 7 bastian 2004-08-19 17:49:56 +0000 Why do you think these calls *need* to be skipped? And why do you think these calls *can* be skipped? Seems to me that without e.g. the setFont(...) call, the menu does not indicate the currently active font correctly. 260145 8 khindenburg 2004-08-19 18:07:23 +0000 Yepper, well the problem is when setFont is called it causes the resize image/window. See comment #5. So basically, we should update menus for schema/bell/font without actually changing/configuring any of these... This was the only approach that I could come up with; it seems like there should be a better way of doing this. 260160 9 7183 khindenburg 2004-08-19 19:27:50 +0000 Created attachment 7183 When switching tabs only update font menu Having to compensate for menu separators is ridiculous... that needs fixed!! 267974 10 binner 2004-09-12 16:55:13 +0000 *** Bug 89341 has been marked as a duplicate of this bug. *** 268380 11 binner 2004-09-13 23:51:41 +0000 What about this? --- TEWidget.cpp 1 Jun 2004 12:31:20 -0000 1.216 +++ TEWidget.cpp 13 Sep 2004 21:51:22 -0000 @@ -1011,7 +1011,7 @@ void TEWidget::updateImageSize() //NOTE: control flows from the back through the chest right into the eye. // `emu' will call back via `setImage'. - resizing = true; + resizing = (oldlin!=lines) || (oldcol!=columns); emit changedContentSizeSignal(contentHeight, contentWidth); // expose resizeEvent resizing = false; } 269309 12 binner 2004-09-16 23:09:21 +0000 *** Bug has been marked as fixed ***. 7182 2004-08-19 17:28:53 +0000 2004-08-19 19:27:50 +0000 disallow 'resize' when switching tabs BR87274.diff text/plain 2387 khindenburg SW5kZXg6IGtvbnNvbGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL2tkZS9rZGViYXNl L2tvbnNvbGUva29uc29sZS9rb25zb2xlLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS40NzUK ZGlmZiAtdSAtcCAtcjEuNDc1IGtvbnNvbGUuY3BwCi0tLSBrb25zb2xlLmNwcAkxNyBBdWcgMjAw NCAxODozNTo0MSAtMDAwMAkxLjQ3NQorKysga29uc29sZS5jcHAJMTkgQXVnIDIwMDQgMTU6MjM6 MzMgLTAwMDAKQEAgLTI1NSw2ICsyNTUsNyBAQCBLb25zb2xlOjpLb25zb2xlKGNvbnN0IGNoYXIq IG5hbWUsIGNvbnN0CiAsYl9iaWRpRW5hYmxlZChmYWxzZSkKICxiX2Z1bGxTY3JpcHRpbmcoZmFs c2UpCiAsYl9zaG93c3RhcnR1cHRpcCh0cnVlKQorLGJfc3dpdGNoVGFiKGZhbHNlKQogLG1faGlz dFNpemUoREVGQVVMVF9ISVNUT1JZX1NJWkUpCiAsbV9zZXBhcmF0b3JfaWQoLTEpCiAsbV9uZXdT ZXNzaW9uQnV0dG9uKDApCkBAIC0yNDc1LDcgKzI0NzYsMTEgQEAgdm9pZCBLb25zb2xlOjphY3Rp dmF0ZVNlc3Npb24oKQogICAgIGlmIChyYS0+aXNDaGVja2VkKCkpIHsgcyA9IGl0LmN1cnJlbnQo KTsgYnJlYWs7IH0KICAgICArK2l0OwogICB9Ci0gIGlmIChzIT1OVUxMKSBhY3RpdmF0ZVNlc3Np b24ocyk7CisgIGlmIChzIT1OVUxMKSB7CisgICAgYl9zd2l0Y2hUYWIgPSB0cnVlOworICAgIGFj dGl2YXRlU2Vzc2lvbihzKTsKKyAgICBiX3N3aXRjaFRhYiA9IGZhbHNlOworICB9CiB9CiAKIHZv aWQgS29uc29sZTo6YWN0aXZhdGVTZXNzaW9uKFRFU2Vzc2lvbiAqcykKQEAgLTI1MDIsNyArMjUw Nyw3IEBAIHZvaWQgS29uc29sZTo6YWN0aXZhdGVTZXNzaW9uKFRFU2Vzc2lvbiAKICAgaWYgKHRh YndpZGdldCkgewogICAgIHRhYndpZGdldC0+c2hvd1BhZ2UoIHNlLT53aWRnZXQoKSApOwogICAg IHRlID0gc2UtPndpZGdldCgpOwotICAgIGlmIChtX21lbnVDcmVhdGVkKSB7CisgICAgaWYgKG1f bWVudUNyZWF0ZWQgJiYgIWJfc3dpdGNoVGFiKSB7CiAgICAgICBzZWxlY3RCZWxsLT5zZXRDdXJy ZW50SXRlbSh0ZS0+YmVsbE1vZGUoKSk7CiAgICAgICBzZXRGb250KHNlLT5mb250Tm8oKSk7CiAg ICAgICB1cGRhdGVTY2hlbWFNZW51KCk7CkBAIC0yOTAxLDcgKzI5MDYsMTEgQEAgdm9pZCBLb25z b2xlOjpwcmV2U2Vzc2lvbigpCiB7CiAgIHNlc3Npb25zLmZpbmQoc2UpOyBzZXNzaW9ucy5wcmV2 KCk7CiAgIGlmICghc2Vzc2lvbnMuY3VycmVudCgpKSBzZXNzaW9ucy5sYXN0KCk7Ci0gIGlmIChz ZXNzaW9ucy5jdXJyZW50KCkpIGFjdGl2YXRlU2Vzc2lvbihzZXNzaW9ucy5jdXJyZW50KCkpOwor ICBpZiAoc2Vzc2lvbnMuY3VycmVudCgpKSB7CisgICAgYl9zd2l0Y2hUYWIgPSB0cnVlOworICAg IGFjdGl2YXRlU2Vzc2lvbihzZXNzaW9ucy5jdXJyZW50KCkpOworICAgIGJfc3dpdGNoVGFiID0g ZmFsc2U7CisgIH0KIH0KIAogLyohIEN5Y2xlIHRvIG5leHQgc2Vzc2lvbiAoaWYgYW55KSAqLwpA QCAtMjkxMCw3ICsyOTE5LDExIEBAIHZvaWQgS29uc29sZTo6bmV4dFNlc3Npb24oKQogewogICBz ZXNzaW9ucy5maW5kKHNlKTsgc2Vzc2lvbnMubmV4dCgpOwogICBpZiAoIXNlc3Npb25zLmN1cnJl bnQoKSkgc2Vzc2lvbnMuZmlyc3QoKTsKLSAgaWYgKHNlc3Npb25zLmN1cnJlbnQoKSkgYWN0aXZh dGVTZXNzaW9uKHNlc3Npb25zLmN1cnJlbnQoKSk7CisgIGlmIChzZXNzaW9ucy5jdXJyZW50KCkp IHsKKyAgICBiX3N3aXRjaFRhYiA9IHRydWU7CisgICAgYWN0aXZhdGVTZXNzaW9uKHNlc3Npb25z LmN1cnJlbnQoKSk7CisgICAgYl9zd2l0Y2hUYWIgPSBmYWxzZTsKKyAgfQogfQogCiB2b2lkIEtv bnNvbGU6OnNsb3RNb3ZlZFRhYihpbnQgZnJvbSwgaW50IHRvKQpJbmRleDoga29uc29sZS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL2tkZS9rZGViYXNlL2tvbnNvbGUva29uc29sZS9rb25z b2xlLmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTgzCmRpZmYgLXUgLXAgLXIxLjE4MyBrb25z b2xlLmgKLS0tIGtvbnNvbGUuaAkxNiBBdWcgMjAwNCAxNjo1MDoxMCAtMDAwMAkxLjE4MworKysg a29uc29sZS5oCTE5IEF1ZyAyMDA0IDE1OjIzOjM1IC0wMDAwCkBAIC0zOTksNiArMzk5LDcgQEAg cHJpdmF0ZToKICAgYm9vbCAgICAgICAgYl9zaG93c3RhcnR1cHRpcDoxOwogCiAgIGJvb2wgICAg ICAgIGJfc291bmRTeXN0ZW1FbmFibGVkOworICBib29sICAgICAgICBiX3N3aXRjaFRhYjsKIAog ICB1bnNpZ25lZCBpbnQgbV9oaXN0U2l6ZTsKICAgaW50IG1fc2VwYXJhdG9yX2lkOwo= 7183 2004-08-19 19:27:50 +0000 2004-08-19 19:27:50 +0000 When switching tabs only update font menu BR87274-2.diff text/plain 2595 khindenburg SW5kZXg6IGtvbnNvbGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL2tkZS9rZGViYXNl L2tvbnNvbGUva29uc29sZS9rb25zb2xlLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS40NzUK ZGlmZiAtdSAtcCAtcjEuNDc1IGtvbnNvbGUuY3BwCi0tLSBrb25zb2xlLmNwcAkxNyBBdWcgMjAw NCAxODozNTo0MSAtMDAwMAkxLjQ3NQorKysga29uc29sZS5jcHAJMTkgQXVnIDIwMDQgMTc6MjI6 NDMgLTAwMDAKQEAgLTI1NSw2ICsyNTUsNyBAQCBLb25zb2xlOjpLb25zb2xlKGNvbnN0IGNoYXIq IG5hbWUsIGNvbnN0CiAsYl9iaWRpRW5hYmxlZChmYWxzZSkKICxiX2Z1bGxTY3JpcHRpbmcoZmFs c2UpCiAsYl9zaG93c3RhcnR1cHRpcCh0cnVlKQorLGJfc3dpdGNoVGFiKGZhbHNlKQogLG1faGlz dFNpemUoREVGQVVMVF9ISVNUT1JZX1NJWkUpCiAsbV9zZXBhcmF0b3JfaWQoLTEpCiAsbV9uZXdT ZXNzaW9uQnV0dG9uKDApCkBAIC0yNDc1LDcgKzI0NzYsMTEgQEAgdm9pZCBLb25zb2xlOjphY3Rp dmF0ZVNlc3Npb24oKQogICAgIGlmIChyYS0+aXNDaGVja2VkKCkpIHsgcyA9IGl0LmN1cnJlbnQo KTsgYnJlYWs7IH0KICAgICArK2l0OwogICB9Ci0gIGlmIChzIT1OVUxMKSBhY3RpdmF0ZVNlc3Np b24ocyk7CisgIGlmIChzIT1OVUxMKSB7CisgICAgYl9zd2l0Y2hUYWIgPSB0cnVlOworICAgIGFj dGl2YXRlU2Vzc2lvbihzKTsKKyAgICBiX3N3aXRjaFRhYiA9IGZhbHNlOworICB9CiB9CiAKIHZv aWQgS29uc29sZTo6YWN0aXZhdGVTZXNzaW9uKFRFU2Vzc2lvbiAqcykKQEAgLTI1MDQsNyArMjUw OSwxNSBAQCB2b2lkIEtvbnNvbGU6OmFjdGl2YXRlU2Vzc2lvbihURVNlc3Npb24gCiAgICAgdGUg PSBzZS0+d2lkZ2V0KCk7CiAgICAgaWYgKG1fbWVudUNyZWF0ZWQpIHsKICAgICAgIHNlbGVjdEJl bGwtPnNldEN1cnJlbnRJdGVtKHRlLT5iZWxsTW9kZSgpKTsKLSAgICAgIHNldEZvbnQoc2UtPmZv bnRObygpKTsKKyAgICAgIGlmIChiX3N3aXRjaFRhYikgeyAgIC8vIFVwZGF0ZSBtZW51IGl0ZW0g b25seQorICAgICAgICBpbnQgaXRlbSA9IHNlLT5mb250Tm8oKTsKKyAgICAgICAgaWYoIGl0ZW0g PiA3ICkgLy8gY29tcGVuc2F0ZSBmb3IgdGhlIHR3byBzZXBhcmF0b3JzCisgICAgICAgICAgaXRl bSsrOworICAgICAgICBpZiggaXRlbSA+IDUgKQorICAgICAgICAgIGl0ZW0rKzsKKyAgICAgICAg c2VsZWN0Rm9udC0+c2V0Q3VycmVudEl0ZW0oaXRlbSk7CisgICAgICB9IGVsc2UKKyAgICAgICAg c2V0Rm9udChzZS0+Zm9udE5vKCkpOwogICAgICAgdXBkYXRlU2NoZW1hTWVudSgpOwogICAgIH0K ICAgfQpAQCAtMjkwMSw3ICsyOTE0LDExIEBAIHZvaWQgS29uc29sZTo6cHJldlNlc3Npb24oKQog ewogICBzZXNzaW9ucy5maW5kKHNlKTsgc2Vzc2lvbnMucHJldigpOwogICBpZiAoIXNlc3Npb25z LmN1cnJlbnQoKSkgc2Vzc2lvbnMubGFzdCgpOwotICBpZiAoc2Vzc2lvbnMuY3VycmVudCgpKSBh Y3RpdmF0ZVNlc3Npb24oc2Vzc2lvbnMuY3VycmVudCgpKTsKKyAgaWYgKHNlc3Npb25zLmN1cnJl bnQoKSkgeworICAgIGJfc3dpdGNoVGFiID0gdHJ1ZTsKKyAgICBhY3RpdmF0ZVNlc3Npb24oc2Vz c2lvbnMuY3VycmVudCgpKTsKKyAgICBiX3N3aXRjaFRhYiA9IGZhbHNlOworICB9CiB9CiAKIC8q ISBDeWNsZSB0byBuZXh0IHNlc3Npb24gKGlmIGFueSkgKi8KQEAgLTI5MTAsNyArMjkyNywxMSBA QCB2b2lkIEtvbnNvbGU6Om5leHRTZXNzaW9uKCkKIHsKICAgc2Vzc2lvbnMuZmluZChzZSk7IHNl c3Npb25zLm5leHQoKTsKICAgaWYgKCFzZXNzaW9ucy5jdXJyZW50KCkpIHNlc3Npb25zLmZpcnN0 KCk7Ci0gIGlmIChzZXNzaW9ucy5jdXJyZW50KCkpIGFjdGl2YXRlU2Vzc2lvbihzZXNzaW9ucy5j dXJyZW50KCkpOworICBpZiAoc2Vzc2lvbnMuY3VycmVudCgpKSB7CisgICAgYl9zd2l0Y2hUYWIg PSB0cnVlOworICAgIGFjdGl2YXRlU2Vzc2lvbihzZXNzaW9ucy5jdXJyZW50KCkpOworICAgIGJf c3dpdGNoVGFiID0gZmFsc2U7CisgIH0KIH0KIAogdm9pZCBLb25zb2xlOjpzbG90TW92ZWRUYWIo aW50IGZyb20sIGludCB0bykKSW5kZXg6IGtvbnNvbGUuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAv aG9tZS9rZGUva2RlYmFzZS9rb25zb2xlL2tvbnNvbGUva29uc29sZS5oLHYKcmV0cmlldmluZyBy ZXZpc2lvbiAxLjE4MwpkaWZmIC11IC1wIC1yMS4xODMga29uc29sZS5oCi0tLSBrb25zb2xlLmgJ MTYgQXVnIDIwMDQgMTY6NTA6MTAgLTAwMDAJMS4xODMKKysrIGtvbnNvbGUuaAkxOSBBdWcgMjAw NCAxNzoyMjo0NSAtMDAwMApAQCAtMzk5LDYgKzM5OSw3IEBAIHByaXZhdGU6CiAgIGJvb2wgICAg ICAgIGJfc2hvd3N0YXJ0dXB0aXA6MTsKIAogICBib29sICAgICAgICBiX3NvdW5kU3lzdGVtRW5h YmxlZDsKKyAgYm9vbCAgICAgICAgYl9zd2l0Y2hUYWI7CiAKICAgdW5zaWduZWQgaW50IG1faGlz dFNpemU7CiAgIGludCBtX3NlcGFyYXRvcl9pZDsK