77669 2004-03-15 13:28:00 +0000 Extraneous message in admin/Makefile.common using --prefix 2004-03-15 20:10:53 +0000 1 1 10 Unmaintained configure general unspecified unspecified FreeBSD RESOLVED FIXED VLO wishlist --- 1 webmaster faure 0 oldest_to_newest 215697 0 webmaster 2004-03-15 13:28:00 +0000 Version: unknown (using KDE 3.2.1, compiled sources) Compiler: gcc version 3.3.3 [FreeBSD] 20031106 OS: FreeBSD (i386) release 5.2-RELEASE When using --prefix, I got the following message from admin/Makefile.common: Warning: you chose to install this package in /home/cap/install, but KDE was found in /usr/local. For this to work, you will need to tell KDE about the new prefix, by ensuring that KDEDIRS contains it, e.g. export KDEDIRS=/home/cap/install:/usr/local Then restart KDE. Kind of extraneous, because the prefixed path *is* in KDEDIRS for me. Would be nice to omit this message when the prefix path is already there, to avoid confusion. 215704 1 coolo 2004-03-15 13:42:19 +0000 I think, reminding the user of the importance is still ok 215782 2 5228 faure 2004-03-15 17:46:31 +0000 Created attachment 5228 patch This should do it. Can you test it? 215794 3 webmaster 2004-03-15 18:15:42 +0000 Doesn't work, because you prefixed and postfixed the grep with ":", so this would only work if there are other dirs before *and* behind the prefix in KDEDIRS. 215817 4 faure 2004-03-15 19:25:31 +0000 > Doesn't work, because you prefixed and postfixed the grep with ":", so this would only work if there are other dirs before *and* behind the prefix in KDEDIRS. No, I also prefixed and postfixed the output of kde-config with ":".... 215830 5 webmaster 2004-03-15 20:01:01 +0000 Ah. Hm, I used $HOME/install which expands to /home/cap/install while I put /usr/home/cap/install in KDEDIRS. Works fine now. :-) 215836 6 faure 2004-03-15 20:10:52 +0000 CVS commit by faure: Don't warn about using a different prefix than kde(libs)'s prefix, if kde already knows about the prefix (e.g. via KDEDIRS). CCMAIL: 77669-done@bugs.kde.org M +11 -7 configure.in.bot.end 1.4 --- kde-common/admin/configure.in.bot.end #1.3:1.4 @@ -3,11 +3,15 @@ # And if so, warn when they don't match if test "$kde_libs_prefix" != "$given_prefix"; then - echo "" - echo "Warning: you chose to install this package in $given_prefix," - echo "but KDE was found in $kde_libs_prefix." - echo "For this to work, you will need to tell KDE about the new prefix, by ensuring" - echo "that KDEDIRS contains it, e.g. export KDEDIRS=$given_prefix:$kde_libs_prefix" - echo "Then restart KDE." - echo "" + # And if kde doesn't know about the prefix yet + echo ":"`kde-config --path exe`":" | grep ":$given_prefix/bin/:" 2>&1 >/dev/null + if test $? -ne 0; then + echo "" + echo "Warning: you chose to install this package in $given_prefix," + echo "but KDE was found in $kde_libs_prefix." + echo "For this to work, you will need to tell KDE about the new prefix, by ensuring" + echo "that KDEDIRS contains it, e.g. export KDEDIRS=$given_prefix:$kde_libs_prefix" + echo "Then restart KDE." + echo "" + fi fi fi 5228 2004-03-15 17:46:31 +0000 2004-03-15 17:46:31 +0000 patch configure.in.bot.end.diff text/plain 1419 faure SW5kZXg6IGNvbmZpZ3VyZS5pbi5ib3QuZW5kCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL2tk ZS9rZGUtY29tbW9uL2FkbWluL2NvbmZpZ3VyZS5pbi5ib3QuZW5kLHYKcmV0cmlldmluZyByZXZp c2lvbiAxLjMKZGlmZiAtdSAtcCAtcjEuMyBjb25maWd1cmUuaW4uYm90LmVuZAotLS0gY29uZmln dXJlLmluLmJvdC5lbmQJMjYgRmViIDIwMDQgMjE6MTM6NTcgLTAwMDAJMS4zCisrKyBjb25maWd1 cmUuaW4uYm90LmVuZAkxNSBNYXIgMjAwNCAxNjo0NjowNCAtMDAwMApAQCAtMiwxMyArMiwxNyBA QAogaWYgdGVzdCAtbiAiJGtkZV9saWJzX3ByZWZpeCIgLWEgLW4gIiRnaXZlbl9wcmVmaXgiOyB0 aGVuCiAgICMgQW5kIGlmIHNvLCB3YXJuIHdoZW4gdGhleSBkb24ndCBtYXRjaAogICBpZiB0ZXN0 ICIka2RlX2xpYnNfcHJlZml4IiAhPSAiJGdpdmVuX3ByZWZpeCI7IHRoZW4KLSAgICBlY2hvICIi Ci0gICAgZWNobyAiV2FybmluZzogeW91IGNob3NlIHRvIGluc3RhbGwgdGhpcyBwYWNrYWdlIGlu ICRnaXZlbl9wcmVmaXgsIgotICAgIGVjaG8gImJ1dCBLREUgd2FzIGZvdW5kIGluICRrZGVfbGli c19wcmVmaXguIgotICAgIGVjaG8gIkZvciB0aGlzIHRvIHdvcmssIHlvdSB3aWxsIG5lZWQgdG8g dGVsbCBLREUgYWJvdXQgdGhlIG5ldyBwcmVmaXgsIGJ5IGVuc3VyaW5nIgotICAgIGVjaG8gInRo YXQgS0RFRElSUyBjb250YWlucyBpdCwgZS5nLiBleHBvcnQgS0RFRElSUz0kZ2l2ZW5fcHJlZml4 OiRrZGVfbGlic19wcmVmaXgiCi0gICAgZWNobyAiVGhlbiByZXN0YXJ0IEtERS4iCi0gICAgZWNo byAiIgorICAgICMgQW5kIGlmIGtkZSBkb2Vzbid0IGtub3cgYWJvdXQgdGhlIHByZWZpeCB5ZXQK KyAgICBlY2hvICI6ImBrZGUtY29uZmlnIC0tcGF0aCBleGVgIjoiIHwgZ3JlcCAiOiRnaXZlbl9w cmVmaXgvYmluLzoiIDI+JjEgPi9kZXYvbnVsbAorICAgIGlmIHRlc3QgJD8gLW5lIDA7IHRoZW4K KyAgICAgIGVjaG8gIiIKKyAgICAgIGVjaG8gIldhcm5pbmc6IHlvdSBjaG9zZSB0byBpbnN0YWxs IHRoaXMgcGFja2FnZSBpbiAkZ2l2ZW5fcHJlZml4LCIKKyAgICAgIGVjaG8gImJ1dCBLREUgd2Fz IGZvdW5kIGluICRrZGVfbGlic19wcmVmaXguIgorICAgICAgZWNobyAiRm9yIHRoaXMgdG8gd29y aywgeW91IHdpbGwgbmVlZCB0byB0ZWxsIEtERSBhYm91dCB0aGUgbmV3IHByZWZpeCwgYnkgZW5z dXJpbmciCisgICAgICBlY2hvICJ0aGF0IEtERURJUlMgY29udGFpbnMgaXQsIGUuZy4gZXhwb3J0 IEtERURJUlM9JGdpdmVuX3ByZWZpeDoka2RlX2xpYnNfcHJlZml4IgorICAgICAgZWNobyAiVGhl biByZXN0YXJ0IEtERS4iCisgICAgICBlY2hvICIiCisgICAgZmkKICAgZmkKIGZpCiAK