74399 2004-02-06 20:47:26 +0000 Superscript links rendered wrong 2004-06-26 15:09:15 +0000 1 1 2 Applications konqueror general unspecified unspecified Linux RESOLVED FIXED NOR normal --- 0 arne.schmitz konqueror-bugs-null gallir 0 oldest_to_newest 202474 0 arne.schmitz 2004-02-06 20:47:26 +0000 Version: 3.2.0 (using KDE 3.2.0, SuSE) Compiler: gcc version 3.3 20030226 (prerelease) (SuSE Linux) OS: Linux (i686) release 2.4.20-4GB-athlon Check out the following page: http://www.mmweg.rwth-aachen.de/~arne.schmitz/download/test.html The superscripted links don't get superscripted, but the normal text does. Seems wrong to me. 202659 1 coolo 2004-02-07 08:57:40 +0000 it's been this way for a while already :) *** This bug has been marked as a duplicate of 45548 *** 244086 2 germain 2004-06-26 14:57:04 +0000 not a dupe of 45548. 244088 3 germain 2004-06-26 14:57:31 +0000 *** Bug 73232 has been marked as a duplicate of this bug. *** 244089 4 germain 2004-06-26 15:09:13 +0000 CVS commit by ggarand: - polish inline-block/inline-tables - fix some vertical-align issues CCMAIL: 74399-done@bugs.kde.org M +16 -0 ChangeLog 1.263 M +3 -2 css/html4.css 1.133 M +5 -3 rendering/render_object.cpp 1.266 M +1 -3 rendering/render_table.h 1.105 --- kdelibs/khtml/ChangeLog #1.262:1.263 @@ -1,2 +1,18 @@ +2004-06-26 Germain Garand <germain@ebooksfrance.org> + + * css/html4.css: + - do not set vertical-align on the table: it breaks inline-table's + default (baseline). cf.webcore/fast/inline-block/001.html + - default all of tbody/tfoot/thead to 'vertical-align: middle' + as per specification. + + * rendering/render_object.cpp: + (getVerticalPosition): fix inverted logic. cf.unsorted/74399.html + (lineHeight/baselinePosition): inline-blocks behaves like replaced elements + only after they are layouted. + + * rendering/render_table.h (position): remove empty reimplementation: + inline-tables need positioning. cf.webcore/fast/inline-block/001.html + 2004-06-22 Zack Rusin <zack@kde.org> --- kdelibs/khtml/rendering/render_table.h #1.104:1.105 @@ -114,6 +114,4 @@ public: virtual void setCellWidths( ); - virtual void position(InlineBox *, int, int, bool) {} - virtual void calcWidth(); --- kdelibs/khtml/rendering/render_object.cpp #1.265:1.266 @@ -1601,5 +1601,5 @@ short RenderObject::getVerticalPosition( vpos = -style()->verticalAlignLength().width( lineHeight( firstLine ) ); } else { - bool checkParent = parent()->isInline() && parent()->isReplacedBlock(); + bool checkParent = parent()->isInline() && !parent()->isReplacedBlock(); vpos = checkParent ? parent()->verticalPositionHint( firstLine ) : 0; // don't allow elements nested inside text-top to have a different valignment. @@ -1644,5 +1644,6 @@ short RenderObject::lineHeight( bool fir // box, then the fact that we're an inline-block is irrelevant, and we behave // just like a block. - if (isReplaced()) + + if (isReplaced() && (!isInlineBlockOrInlineTable() || layouted())) return height()+marginTop()+marginBottom(); @@ -1673,5 +1674,6 @@ short RenderObject::baselinePosition( bo // box, then the fact that we're an inline-block is irrelevant, and we behave // just like a block. - if (isReplaced()) + + if (isReplaced() && (!isInlineBlockOrInlineTable() || layouted())) return height()+marginTop()+marginBottom(); --- kdelibs/khtml/css/html4.css #1.132:1.133 @@ -182,5 +182,4 @@ display: table; border-collapse: separate; - vertical-align: middle; text-align: -khtml-auto; border-spacing: 2px; @@ -196,10 +195,11 @@ display: table-header-group; border-color: inherit; + vertical-align: middle; } TBODY { display: table-row-group; - vertical-align: inherit; border-color: inherit; + vertical-align: middle; } @@ -207,4 +207,5 @@ display: table-footer-group; border-color: inherit; + vertical-align: middle; }