74269 2004-02-05 19:27:48 +0000 FIXME/Patch: sorting Settings/Keyboard entires 2004-02-05 23:50:29 +0000 1 1 2 Applications konsole general unspecified Compiled Sources Linux RESOLVED FIXED NOR wishlist --- 0 khindenburg konsole-bugs-null 0 oldest_to_newest 202055 0 khindenburg 2004-02-05 19:27:48 +0000 Version: (using KDE Devel) Installed from: Compiled sources Compiler: gcc version 3.2.3 20030422 (Gentoo Linux 1.4 3.2.3-r3, propolice) OS: Linux FIXME in konsole/konsole.cpp asks for sorting of Keyboard menu entires. New layout: linux console vt100 (historical) VT420PC XTerm (XFree 3.x.x) XTerm (XFree 4.x.x) 202056 1 4526 khindenburg 2004-02-05 19:28:46 +0000 Created attachment 4526 Patch to sort KeyBoard menu entires 202159 2 bastian 2004-02-05 23:50:29 +0000 Subject: KDE_3_2_BRANCH: kdebase/konsole/konsole CVS commit by waba: Sort Settings/Keyboard entries (BR74269) Patch by Kurt V.Hindenburg CCMAIL: 74269-done@bugs.kde.org M +15 -1 konsole.cpp 1.441.2.4 --- kdebase/konsole/konsole/konsole.cpp #1.441.2.3:1.441.2.4 @@ -769,12 +769,26 @@ void Konsole::makeGUI() // insert keymaps into menu - //FIXME: sort + // This sorting seems a bit cumbersome; but it is not called often. + QStringList kt_titles; + typedef QMap<QString,KeyTrans*> QStringKeyTransMap; + QStringKeyTransMap kt_map; + for (int i = 0; i < KeyTrans::count(); i++) { KeyTrans* ktr = KeyTrans::find(i); assert( ktr ); + QString title=ktr->hdr().lower(); + kt_titles << title; + kt_map[title] = ktr; + } + kt_titles.sort(); + for ( QStringList::Iterator it = kt_titles.begin(); it != kt_titles.end(); ++it ) { + KeyTrans* ktr = kt_map[*it]; + assert( ktr ); QString title=ktr->hdr(); m_keytab->insertItem(title.replace('&',"&&"),ktr->numb()); + //KONSOLEDEBUG << *it << "---" << title << "---" << ktr->numb() << endl; } + applySettingsToGUI(); isRestored = false; 4526 2004-02-05 19:28:46 +0000 2004-02-05 19:28:46 +0000 Patch to sort KeyBoard menu entires sortKeyMaps.diff text/plain 1164 khindenburg LS0tIGtvbnNvbGUuY3BwLm9yaWcJMjAwNC0wMi0wNSAxMzowNjowOC4wODQ2Njc1NjggLTA1MDAK KysrIGtvbnNvbGUuY3BwCTIwMDQtMDItMDUgMTM6MTg6MDAuNjMwMzQ0MTYwIC0wNTAwCkBAIC03 NjgsMTQgKzc2OCwzMCBAQAogICAgc2UtPnNldFNjaGVtYU5vKGN1cnJfc2NoZW1hKTsKIAogICAg Ly8gaW5zZXJ0IGtleW1hcHMgaW50byBtZW51Ci0gICAvL0ZJWE1FOiBzb3J0CisgICAvLyBUaGlz IHNvcnRpbmcgc2VlbXMgYSBiaXQgY3VtYmVyc29tZTsgYnV0IGl0IGlzIG5vdCBjYWxsZWQgb2Z0 ZW4uCisgICBRU3RyaW5nTGlzdCBrdF90aXRsZXM7CisgICB0eXBlZGVmIFFNYXA8UVN0cmluZyxL ZXlUcmFucyo+IFFTdHJpbmdLZXlUcmFuc01hcDsKKyAgIFFTdHJpbmdLZXlUcmFuc01hcCBrdF9t YXA7CisKICAgIGZvciAoaW50IGkgPSAwOyBpIDwgS2V5VHJhbnM6OmNvdW50KCk7IGkrKykKICAg IHsKICAgICAgIEtleVRyYW5zKiBrdHIgPSBLZXlUcmFuczo6ZmluZChpKTsKICAgICAgIGFzc2Vy dCgga3RyICk7CisgICAgICBRU3RyaW5nIHRpdGxlPWt0ci0+aGRyKCkubG93ZXIoKTsKKyAgICAg IGt0X3RpdGxlcyA8PCB0aXRsZTsKKyAgICAgIGt0X21hcFt0aXRsZV0gPSBrdHI7CisgICAgICAv L21fa2V5dGFiLT5pbnNlcnRJdGVtKHRpdGxlLnJlcGxhY2UoJyYnLCImJiIpLGt0ci0+bnVtYigp KTsKKyAgICAgIC8vS09OU09MRURFQlVHIDw8IHRpdGxlIDw8ICItLS0iIDw8IGt0ci0+bnVtYigp IDw8IGVuZGw7CisgICB9CisgICBrdF90aXRsZXMuc29ydCgpOworICAgZm9yICggUVN0cmluZ0xp c3Q6Okl0ZXJhdG9yIGl0ID0ga3RfdGl0bGVzLmJlZ2luKCk7IGl0ICE9IGt0X3RpdGxlcy5lbmQo KTsgKytpdCApIHsKKyAgICAgIEtleVRyYW5zKiBrdHIgPSBrdF9tYXBbKml0XTsKKyAgICAgIGFz c2VydCgga3RyICk7CiAgICAgICBRU3RyaW5nIHRpdGxlPWt0ci0+aGRyKCk7CiAgICAgICBtX2tl eXRhYi0+aW5zZXJ0SXRlbSh0aXRsZS5yZXBsYWNlKCcmJywiJiYiKSxrdHItPm51bWIoKSk7Cisg ICAgICAvL0tPTlNPTEVERUJVRyA8PCAqaXQgPDwgIi0tLSIgPDwgdGl0bGUgPDwgIi0tLSIgPDwg a3RyLT5udW1iKCkgPDwgZW5kbDsKICAgIH0KKwogICAgYXBwbHlTZXR0aW5nc1RvR1VJKCk7CiAg ICBpc1Jlc3RvcmVkID0gZmFsc2U7CiAK