71866 2004-01-05 00:00:47 +0000 conversion of pop filter settings dangerous 2007-09-14 12:17:01 +0000 1 1 10 Unmaintained kmail general 1.6 unspecified Linux RESOLVED FIXED NOR critical --- 1 list pim-bugs-null 20 oldest_to_newest 191511 0 list 2004-01-05 00:00:47 +0000 Version: 1.5.94 (using KDE 3.1.94 (3.2 Beta 2), SuSE) Compiler: gcc version 3.3 20030226 (prerelease) (SuSE Linux) OS: Linux (i686) release 2.4.23 In KMail from KDE 3.1.4 I had a filter to delay downloading of emails that exceed 50000 bytes (and to show the dialogue). After installing 3.2B2 the filter was set to delete those emails on the server! 201596 1 kloecker 2004-02-04 17:16:33 +0000 Confirmed. 201599 2 4511 kloecker 2004-02-04 17:29:57 +0000 Created attachment 4511 This fixes the bug That's a prime example for why it's bad to store the value of an enum as a number in a config file. The reason for this bug is a reordering of the enum values in the code. This changed the meaning of the value which is stored in the config file. With the patch KMail stores the enum as a string representing the enum value. As a consequence all POP filters will be reset to NoAction. But there is no other fix possible because it's impossible to find out whether the pop filter configuration was saved with KMail 1.6 or with a previous version of KMail. 201824 3 kloecker 2004-02-05 11:09:10 +0000 This bug has been fixed. The fix will be in KDE 3.2.1. Note that all POP filters will be reset to "Download later" because we now store the filter actions in a safe way in order to prevent further bugs caused by misinterpretations of values in the configuration file. 201827 4 pfeiffer 2004-02-05 11:27:19 +0000 > But there is no other fix possible because it's impossible to find out > whether the pop filter configuration was saved with KMail 1.6 or with a > previous version of KMail. I suggest adding a 'version' attribute to the config file. 202645 5 caio_sm 2004-02-07 06:46:44 +0000 It would like to know where place I apply patche: kdepim-3.2.0-HOT_FIX_FOR_KMAIL.patch which is the directory? Remembering that I use Slackware 9.1 202908 6 caio_sm 2004-02-07 20:03:38 +0000 I installing the following packages: kdegraphics-3.2.0-i486-2.tgz - kdemultimedia-3.2.0-i486-2.tgz - kdepim-3.2.0-i486-2.tgz I solve this bug? 4511 2004-02-04 17:29:57 +0000 2004-02-04 17:29:57 +0000 This fixes the bug kmfilter.cpp.patch text/plain 1516 kloecker SW5kZXg6IGttZmlsdGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvaG9tZS9rZGUva2RlcGlt L2ttYWlsL2ttZmlsdGVyLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS41OApkaWZmIC11IC0z IC1wIC1yMS41OCBrbWZpbHRlci5jcHAKLS0tIGttZmlsdGVyLmNwcAkyOSBOb3YgMjAwMyAxNTo0 Njo0MyAtMDAwMAkxLjU4CisrKyBrbWZpbHRlci5jcHAJNCBGZWIgMjAwNCAxNjoxNjowMSAtMDAw MApAQCAtMTQ3LDkgKzE0NywxOCBAQCB2b2lkIEtNRmlsdGVyOjpyZWFkQ29uZmlnKEtDb25maWcq IGNvbmZpCiAgIC8vIHRoYXQgdGhlIHBhdHRlcm4gaXMgcHVyaWZpZWQuCiAgIG1QYXR0ZXJuLnJl YWRDb25maWcoY29uZmlnKTsKIAotICBpZiAoYlBvcEZpbHRlcikKKyAgaWYgKGJQb3BGaWx0ZXIp IHsKICAgICAvLyBnZXQgdGhlIGFjdGlvbiBkZXNjcmlwdGlvbi4uLgotICAgIG1BY3Rpb24gPSAo S01Qb3BGaWx0ZXJBY3Rpb24pIGNvbmZpZy0+cmVhZE51bUVudHJ5KCAiYWN0aW9uIiApOworICAg IFFTdHJpbmcgYWN0aW9uID0gY29uZmlnLT5yZWFkRW50cnkoICJhY3Rpb24iICk7CisgICAgaWYg KCBhY3Rpb24gPT0gImRvd24iICkKKyAgICAgIG1BY3Rpb24gPSBEb3duOworICAgIGVsc2UgaWYg KCBhY3Rpb24gPT0gImxhdGVyIiApCisgICAgICBtQWN0aW9uID0gTGF0ZXI7CisgICAgZWxzZSBp ZiAoIGFjdGlvbiA9PSAiZGVsZXRlIiApCisgICAgICBtQWN0aW9uID0gRGVsZXRlOworICAgIGVs c2UKKyAgICAgIG1BY3Rpb24gPSBOb0FjdGlvbjsKKyAgfQogICBlbHNlIHsKICAgICBRU3RyaW5n TGlzdCBzZXRzID0gY29uZmlnLT5yZWFkTGlzdEVudHJ5KCJhcHBseS1vbiIpOwogICAgIGlmICgg c2V0cy5pc0VtcHR5KCkgJiYgIWNvbmZpZy0+aGFzS2V5KCJhcHBseS1vbiIpICkgewpAQCAtMjEw LDcgKzIxOSwxOSBAQCB2b2lkIEtNRmlsdGVyOjp3cml0ZUNvbmZpZyhLQ29uZmlnKiBjb25mCiAg IG1QYXR0ZXJuLndyaXRlQ29uZmlnKGNvbmZpZyk7CiAKICAgaWYgKGJQb3BGaWx0ZXIpIHsKLSAg ICBjb25maWctPndyaXRlRW50cnkoICJhY3Rpb24iLCBtQWN0aW9uICk7CisgICAgc3dpdGNoICgg bUFjdGlvbiApIHsKKyAgICBjYXNlIERvd246CisgICAgICBjb25maWctPndyaXRlRW50cnkoICJh Y3Rpb24iLCAiZG93biIgKTsKKyAgICAgIGJyZWFrOworICAgIGNhc2UgTGF0ZXI6CisgICAgICBj b25maWctPndyaXRlRW50cnkoICJhY3Rpb24iLCAibGF0ZXIiICk7CisgICAgICBicmVhazsKKyAg ICBjYXNlIERlbGV0ZToKKyAgICAgIGNvbmZpZy0+d3JpdGVFbnRyeSggImFjdGlvbiIsICJkZWxl dGUiICk7CisgICAgICBicmVhazsKKyAgICBkZWZhdWx0OgorICAgICAgY29uZmlnLT53cml0ZUVu dHJ5KCAiYWN0aW9uIiwgIiIgKTsKKyAgICB9CiAgIH0gZWxzZSB7CiAgICAgUVN0cmluZ0xpc3Qg c2V0czsKICAgICBpZiAoIGJBcHBseU9uSW5ib3VuZCApCg==