68399 2003-11-17 00:24:44 +0000 No check for print file names given by the rename dialog 2008-12-31 13:23:50 +0000 1 1 10 Unmaintained kdeprint general unspecified Compiled Sources Linux CLOSED DUPLICATE 59796 NOR grave --- 1 kossebau kdeprint_bugs jlayt 0 oldest_to_newest 177279 0 kossebau 2003-11-17 00:24:45 +0000 Version: (using KDE Devel) Installed from: Compiled sources Problem: There is no check whether the filename returned from RenameDlg is already existing when "Rename" was selected. Reproduce: 1. Create some files in your home dir: $ touch print.ps; touch print_1.ps; touch print_2.ps 2. Open a file in Kate and reach for the printing dialog 3. Select "print to file": default is ~/print.ps 4. Click "Ok" 5. Smart printer dialog detects there already is such a file and calls for the RenameDlg. 6. Click "Suggest" button and get a new name proposed: "print_1.ps" 7. Click "Rename" which is now activated. 8. Lucky you. Get your existing "print_1.ps" overwritten, without any warning. 177280 1 3252 kossebau 2003-11-17 00:28:26 +0000 Created attachment 3252 This works for me. 181473 2 kossebau 2003-11-29 23:00:47 +0000 Due, this works for me was meant for the patch. And as there is a possible loss of data (overwritten files) the bug should be marked grave surely. Please, anyone to review that really simple patch? 205540 3 binner 2004-02-13 21:45:30 +0000 The patch looks fine. Why didn't you apply it already? 205661 4 kossebau 2004-02-14 12:05:26 +0000 Because I felt unsure if I understood the code around correctly. I sent the patch to kde-devel (okay, should perhaps have been kde-core-devel) and kde-print for review but got no reaction. So I put it here to rest until finally someone comes along. What should have I done else? :) 206201 5 kdeprint_bugs 2004-02-16 10:36:25 +0000 *** This bug has been marked as a duplicate of 59796 *** 206203 6 kdeprint_bugs 2004-02-16 10:36:31 +0000 The patch is OK, however a more generic solution has been implemented at KIO::RenameDlg level (see revision 1.71 of kdelibs/kio/kio/renamedlg.cpp). This should solve the problem. I'll close the bug. (sorry for not taking your previous posts into consideration, I remember it but it looks like I lost it and unfortunately forgot about it) Michael. > ------- Additional Comments From friedrich w h kossebau de > 2004-02-14 12:05 ------- > Because I felt unsure if I understood the code around > correctly. I sent the > patch to kde-devel (okay, should perhaps have been > kde-core-devel) and > kde-print for review but got no reaction. So I put it here to > rest until > finally someone comes along. > > What should have I done else? :) > 206255 7 kossebau 2004-02-16 12:45:43 +0000 > ------- Additional Comments From goffioul imec be 2004-02-16 10:36 ------- > The patch is OK, however a more generic solution has been implemented > at KIO::RenameDlg level (see revision 1.71 of > kdelibs/kio/kio/renamedlg.cpp). This should solve the problem. I'll close > the bug. The fix at KIO::RenameDlg level fixes only half of the problem. Change my example to a manually inserted new name. This one should be checked for existance, too, until "Overwrite" was explicitly choosen. So IMO the patch still should be applied. And pleased backported. Friedrich 206263 8 kdeprint_bugs 2004-02-16 13:02:54 +0000 Then please commit it, if possible. Michael. > The fix at KIO::RenameDlg level fixes only half of the > problem. Change my > example to a manually inserted new name. This one should be > checked for > existance, too, until "Overwrite" was explicitly choosen. > > So IMO the patch still should be applied. And pleased backported. > > Friedrich > 206318 9 kossebau 2004-02-16 15:34:58 +0000 > ------- Additional Comments From goffioul imec be 2004-02-16 13:02 ------- > Then please commit it, if possible. Sorry, could you or someone else do it, my cvs copy is broken ATM and a recompile takes a day on my 233 MHz computer (and is not planned for the next few weeks, due to exams) :/ Friedrich PS: And after having once again a look at the code of KPrintDialog::checkOutputFile() I think that most of this functionality should be in KIO itself anyway (and needs a way to prevent file name race conditions). But I haven't the time to care for. 689948 10 jlayt 2008-12-31 13:23:50 +0000 Closing old Resolved status bug. 3252 2003-11-17 00:28:26 +0000 2003-11-17 00:28:26 +0000 This works for me. kprintdialog-15.11.03.patch text/plain 1015 kossebau SW5kZXg6IGtwcmludGRpYWxvZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2hvbWUva2RlL2tk ZWxpYnMva2RlcHJpbnQva3ByaW50ZGlhbG9nLmNwcCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS43 MwpkaWZmIC11IC0zIC1wIC1yMS43MyBrcHJpbnRkaWFsb2cuY3BwCi0tLSBrcHJpbnRkaWFsb2cu Y3BwCTI1IE9jdCAyMDAzIDIxOjE4OjMzIC0wMDAwCTEuNzMKKysrIGtwcmludGRpYWxvZy5jcHAJ MTUgTm92IDIwMDMgMTY6NDQ6NTQgLTAwMDAKQEAgLTcwMCw2ICs3MDAsMTAgQEAgYm9vbCBLUHJp bnREaWFsb2c6OmNoZWNrT3V0cHV0RmlsZSgpCiAJCWlmICggIXVybC5pc0xvY2FsRmlsZSgpICkK IAkJCXJldHVybiB0cnVlOwogCisJCWJvb2wJYW5vdGhlckNoZWNrOworCQlkbworCQl7CisJCWFu b3RoZXJDaGVjayA9IGZhbHNlOwogCQlRRmlsZUluZm8JZih1cmwucGF0aCgpKTsKIAkJaWYgKGYu ZXhpc3RzKCkpCiAJCXsKQEAgLTcyMCw4ICs3MjQsMTAgQEAgYm9vbCBLUHJpbnREaWFsb2c6OmNo ZWNrT3V0cHV0RmlsZSgpCiAJCQkJCQl2YWx1ZSA9IGZhbHNlOwogCQkJCQkJYnJlYWs7CiAJCQkJ CWNhc2UgS0lPOjpSX1JFTkFNRToKLQkJCQkJCWQtPm1fZmlsZS0+bGluZUVkaXQoKS0+c2V0VGV4 dCggZGxnLm5ld0Rlc3RVUkwoKS5wYXRoKCkgKTsKKwkJCQkJCXVybCA9IGRsZy5uZXdEZXN0VVJM KCk7CisJCQkJCQlkLT5tX2ZpbGUtPmxpbmVFZGl0KCktPnNldFRleHQoIHVybC5wYXRoKCkgKTsK IAkJCQkJCXZhbHVlID0gdHJ1ZTsKKwkJCQkJCWFub3RoZXJDaGVjayA9IHRydWU7CiAJCQkJCQli cmVhazsKIAkJCQl9CiAJCQl9CkBAIC03MzgsNiArNzQ0LDcgQEAgYm9vbCBLUHJpbnREaWFsb2c6 OmNoZWNrT3V0cHV0RmlsZSgpCiAJCQllbHNlCiAJCQkJdmFsdWUgPSB0cnVlOwogCQl9CisJCX0g d2hpbGUoIGFub3RoZXJDaGVjayApOwogCX0KIAlyZXR1cm4gdmFsdWU7CiB9Cg==