68068 2003-11-12 21:46:58 +0000 [test case] clear:both not handled correctly (regression) 2004-01-25 22:12:12 +0000 1 1 2 Applications konqueror khtml renderer 4.0 unspecified Linux RESOLVED FIXED NOR grave --- 1 shift konqueror-bugs-null bulk marcus stephane 40 oldest_to_newest 175858 0 shift 2003-11-12 21:46:58 +0000 Version: 4.0 (using KDE 3.1.93 (CVS >= 20031028), Mandrake Linux Cooker i586 - Cooker) Compiler: gcc version 3.3.1 (Mandrake Linux 9.2 3.3.1-4mdk) OS: Linux (i686) release 2.4.22-16mdk There is a regression in the CVS khtml engine. The clear:both is broken. Try http://perso.wanadoo.fr/shift/kde-bug/clear-both.html The BOTTOM box will be under the level of the TOP-RIGHT. It is a very important regression :( 175896 1 shift 2003-11-12 23:36:13 +0000 Another example : http://perso.wanadoo.fr/shift/kde-bug/clear-both2.html Here you can see that the box 3 "believe" that the floating box 2 is on the left of it. This bug completely broke the layout of my website : http://shift.free.fr/ Please help !!!! :) Thanks, Franck 192048 2 marcus 2004-01-06 15:55:25 +0000 This breaks quite a few layouts that use floated images - but only those that try the clear _outside_ the containing element: <p> <img style="float:left" src="/some/image"> some small paragraph such that the image hangs out of the paragraph bounding box by a few ems... </p> <div style="clear:both"></div> <p> <img style="float:left" src="/some/image"> some small paragraph such that the image hangs out of the paragraph bounding box by a few ems... </p> <div style="clear:both"></div> The second paragraph should be below the image, not to the right of it. 193523 3 patrick 2004-01-11 05:12:40 +0000 I hope I have correctly identified this as "the same bug"... This bug also breaks the node entry form in Drupal (http://www.drupal.org) as the textarea for the body is shifted to the right off the screen. No scrollbar is displayed... I have reduced the page into a (IMO) minimal testcase: <div style="float:left; border:blue thin solid;">float: left</div> <div style="clear:both; border:red thin solid;">clear: both</div> The "clear: both" text should be exactly below the "float:left", not indented to the right... 193679 4 coolo 2004-01-11 16:20:26 +0000 Shift: please attach your test cases here - test cases get lost just too easy otherwise 193685 5 4099 shift 2004-01-11 16:35:59 +0000 Created attachment 4099 First testcase Here is the first testcase in attachement 193686 6 4100 shift 2004-01-11 16:36:43 +0000 Created attachment 4100 Second testcase Here is the second testcase in attachement 198330 7 shift 2004-01-24 08:19:24 +0000 The second test case seems to be OK now. 198738 8 coolo 2004-01-25 17:27:32 +0000 *** Bug 73462 has been marked as a duplicate of this bug. *** 198743 9 coolo 2004-01-25 17:27:59 +0000 *** Bug 70930 has been marked as a duplicate of this bug. *** 198843 10 mueller 2004-01-25 22:12:13 +0000 Subject: kdelibs/khtml CVS commit by mueller: * rendering/render_block.cpp (positionNewFloats): when somebody says clear: both;, he usually means it (#68068). CCMAIL: 68068-done@bugs.kde.org M +3 -0 ChangeLog 1.185 M +7 -5 rendering/render_block.cpp 1.23 --- kdelibs/khtml/ChangeLog #1.184:1.185 @@ -1,4 +1,7 @@ 2004-01-25 Dirk Mueller <mueller@kde.org> + * rendering/render_block.cpp (positionNewFloats): when somebody says + clear: both;, he usually means it (#68068). + * html/html_objectimpl.cpp (renderAlternative): give the alternative rendering some time to avoid ugly deletion races. --- kdelibs/khtml/rendering/render_block.cpp #1.22:1.23 @@ -1361,8 +1361,12 @@ void RenderBlock::positionNewFloats() if (ro - lo < fwidth) fwidth = ro - lo; // Never look for more than what will be available. - if (o->style()->floating() == FLEFT) - { + if ( o->style()->clear() & CLEFT ) y = kMax( leftBottom(), y ); + if ( o->style()->clear() & CRIGHT ) + y = kMax( rightBottom(), y ); + + if (o->style()->floating() == FLEFT) + { int heightRemainingLeft = 1; int heightRemainingRight = 1; @@ -1380,6 +1384,4 @@ void RenderBlock::positionNewFloats() else { - if ( o->style()->clear() & CRIGHT ) - y = kMax( rightBottom(), y ); int heightRemainingLeft = 1; int heightRemainingRight = 1; @@ -1786,5 +1788,5 @@ void RenderBlock::markAllDescendantsWith bool RenderBlock::checkClear(RenderObject *child) { - //kdDebug( 6040 ) << "checkClear oldheight=" << m_height << endl; + //kdDebug( 6040 ) << "checkClear on child " << child << " oldheight=" << m_height << endl; int bottom = 0; switch(child->style()->clear()) 4099 2004-01-11 16:35:59 +0000 2004-01-11 16:35:59 +0000 First testcase clear-both.html text/html 744 shift PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjEvL0VOIiAiaHR0cDov L3d3dy53My5vcmcvVFIveGh0bWwxMS9EVEQveGh0bWwxMS5kdGQiPgoKPGh0bWwgeG1sbnM9Imh0 dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiIHhtbDpsYW5nPSJmciI+Cgk8aGVhZD4KCQk8dGl0 bGU+Q1NTIFRlc3Q8L3RpdGxlPgoKCQk8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgoKCQkJZGl2IHsK CQkJCWJvcmRlcjogc29saWQgMXB4IHJlZDsKCQkJfQoJCQkKCQkJI3RvcFJpZ2h0IHsKCQkJCWZs b2F0OnJpZ2h0OwoJCQkJd2lkdGg6IDI1MHB4OwoJCQkJaGVpZ2h0OjEwMHB4OwoJCQl9CgkJCQoJ CQkjdG9wIHsJCgkJCQl3aWR0aDo1MCU7CgkJCX0KCQkJCgkJCSNib3R0b21MZWZ0IHsKCQkJCWZs b2F0OiBsZWZ0OwoJCQkJY2xlYXI6IGJvdGg7CgkJCX0KCQk8L3N0eWxlPgkKCgk8L2hlYWQ+CgoJ PGJvZHk+CgoJCTxkaXYgaWQ9InRvcFJpZ2h0Ij4KCQkJVE9QLVJJR0hUPGJyIC8+CgkJCWZsb2F0 OnJpZ2h0OzxiciAvPgoJCQl3aWR0aDogMjUwcHg7PGJyIC8+CgkJCWhlaWdodDoxMDBweDsKCQk8 L2Rpdj4KCgkJPGRpdiBpZD0idG9wIj4KCQkJVE9QPGJyIC8+CgkJCXdpZHRoOjUwJTsKCQk8L2Rp dj4KCgoJCTxkaXYgaWQ9ImJvdHRvbUxlZnQiPgoJCQlCT1RUT00tTEVGVDxiciAvPgoJCQlmbG9h dDogbGVmdDs8YnIgLz4KCQkJY2xlYXI6IGJvdGg7CgkJPC9kaXY+CgkJCgk8L2JvZHk+CjwvaHRt bD4K 4100 2004-01-11 16:36:43 +0000 2004-01-11 16:36:43 +0000 Second testcase clear-both2.html text/html 2304 shift PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjEvL0VOIiAiaHR0cDov L3d3dy53My5vcmcvVFIveGh0bWwxMS9EVEQveGh0bWwxMS5kdGQiPgoKPGh0bWwgeG1sbnM9Imh0 dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiIHhtbDpsYW5nPSJmciI+Cgk8aGVhZD4KCQk8dGl0 bGU+Q1NTIFRlc3Q8L3RpdGxlPgoKCQk8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgoKCQkJZGl2IHsK CQkJCWJvcmRlcjogc29saWQgMXB4IHJlZDsKCQkJfQoJCQkKCQkKCQkJIzEgewoJCQkJd2lkdGg6 IDQwMHB4OwoJCQl9CgoJCQkjMiB7CQoJCQkJZmxvYXQ6bGVmdDsKCQkJCXdpZHRoOiAxNTBweDsK CQkJCWhlaWdodCA6IDE1MHB4OwoJCQkJYmFja2dyb3VuZC1jb2xvcjp5ZWxsb3c7CgkJCX0KCQkJ CgkJCSMzIHsKCQkJCWNsZWFyOmJvdGg7CgkJCX0KCQkJCgkJPC9zdHlsZT4JCgoJPC9oZWFkPgoK CTxib2R5PgoKCQoJCTxkaXYgaWQ9IjEiPgoJCQk8ZGl2IGlkPSIyIj4KCQkJCTI8YnIgLz4KCQkJ CWZsb2F0OmxlZnQ7PGJyIC8+CgkJCQl3aWR0aDogMTAwcHg7PGJyIC8+CgkJCQloZWlnaHQgOiAx MDBweDs8YnIgLz4KCQkJCWJhY2tncm91bmQtY29sb3I6eWVsbG93OwoJCQk8L2Rpdj4KCQkJPGRp diBpZD0iMyI+CgkJCQkKCQkJCTM8YnIvPgoJCQkJY2xlYXI6Ym90aDs8YnIgLz4KCShmc2Qgc2Rq IHNka2pnIGhzZGpnaGV6aWdkZmdiampzZGJnZiBkc2ogaGdqa3NkaGdqa2hkc2Zqa2cgaHNkaGdq a3NsaGRnIGprc2hmZGdqIGtoc2QgZmpna2ggc2xnaGprZmhnIGtqc2hmZGprc3RoanNodCBramRi Z2tkYnQga2JzcmkgamJmIGdqYnNkayBnYmQga2dmYiBranNkZmcgZmRoZyBkZmhnZGZnaCBkZmdo IGRmaCBkYnJkZXRiYnl0YmJ5aCBmc2Qgc2RqIHNka2pnIGhzZGpnaGV6aWdkZmdiampzZGJnZiBk c2ogaGdqa3NkaGdqa2hkc2Zqa2cgaHNkaGdqa3NsaGRnIGprc2hmZGdqIGtoc2QgZmpna2ggc2xn aGprZmhnIGtqc2hmZGprc3RoanNodCBramRiZ2tkYnQga2JzcmkgamJmIGdqYnNkayBnYmQga2dm YiBranNkZmcgZmRoZyBkZmhnZGZnaCBkZmdoIGRmaCBkYnJkZXRiYnl0YmJ5aApmc2Qgc2RqIHNk a2pnIGhzZGpnaGV6aWdkZmdiampzZGJnZiBkc2ogaGdqa3NkaGdqa2hkc2Zqa2cgaHNkaGdqa3Ns aGRnIGprc2hmZGdqIGtoc2QgZmpna2ggc2xnaGprZmhnIGtqc2hmZGprc3RoanNodCBramRiZ2tk YnQga2JzcmkgamJmIGdqYnNkayBnYmQga2dmYiBranNkZmcgZmRoZyBkZmhnZGZnaCBkZmdoIGRm aCBkYnJkZXRiYnl0YmJ5aApmc2Qgc2RqIHNka2pnIGhzZGpnaGV6aWdkZmdiampzZGJnZiBkc2og aGdqa3NkaGdqa2hkc2Zqa2cgaHNkaGdqa3NsaGRnIGprc2hmZGdqIGtoc2QgZmpna2ggc2xnaGpr ZmhnIGtqc2hmZGprc3RoanNodCBramRiZ2tkYnQga2JzcmkgamJmIGdqYnNkayBnYmQga2dmYiBr anNkZmcgZmRoZyBkZmhnZGZnaCBkZmdoIGRmaCBkYnJkZXRiYnl0YmJ5aApmc2Qgc2RqIHNka2pn IGhzZGpnaGV6aWdkZmdiampzZGJnZiBkc2ogaGdqa3NkaGdqa2hkc2Zqa2cgaHNkaGdqa3NsaGRn IGprc2hmZGdqIGtoc2QgZmpna2ggc2xnaGprZmhnIGtqc2hmZGprc3RoanNodCBramRiZ2tkYnQg a2JzcmkgamJmIGdqYnNkayBnYmQga2dmYiBranNkZmcgZmRoZyBkZmhnZGZnaCBkZmdoIGRmaCBk YnJkZXRiYnl0YmJ5aApmc2Qgc2RqIHNka2pnIGhzZGpnaGV6aWdkZmdiampzZGJnZiBkc2ogaGdq a3NkaGdqa2hkc2Zqa2cgaHNkaGdqa3NsaGRnIGprc2hmZGdqIGtoc2QgZmpna2ggc2xnaGprZmhn IGtqc2hmZGprc3RoanNodCBramRiZ2tkYnQga2JzcmkgamJmIGdqYnNkayBnYmQga2dmYiBranNk ZmcgZmRoZyBkZmhnZGZnaCBkZmdoIGRmaCBkYnJkZXRiYnl0YmJ5aApmc2Qgc2RqIHNka2pnIGhz ZGpnaGV6aWdkZmdiampzZGJnZiBkc2ogaGdqa3NkaGdqa2hkc2Zqa2cgaHNkaGdqa3NsaGRnIGpr c2hmZGdqIGtoc2QgZmpna2ggc2xnaGprZmhnIGtqc2hmZGprc3RoanNodCBramRiZ2tkYnQga2Jz cmkgamJmIGdqYnNkayBnYmQga2dmYiBranNkZmcgZmRoZyBkZmhnZGZnaCBkZmdoIGRmaCBkYnJk ZXRiYnl0YmJ5aApmc2Qgc2RqIHNka2pnIGhzZGpnaGV6aWdkZmdiampzZGJnZiBkc2ogaGdqa3Nk aGdqa2hkc2Zqa2cgaHNkaGdqa3NsaGRnIGprc2hmZGdqIGtoc2QgZmpna2ggc2xnaGprZmhnIGtq c2hmZGprc3RoanNodCBramRiZ2tkYnQga2JzcmkgamJmIGdqYnNkayBnYmQga2dmYiBranNkZmcg ZmRoZyBkZmhnZGZnaCBkZmdoIGRmaCBkYnJkZXRiYnl0YmJ5aAopCgkJCTwvZGl2PgoKCQk8L2Rp dj4KCgkJCgk8L2JvZHk+CjwvaHRtbD4K