<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>66492</bug_id>
          
          <creation_ts>2003-10-24 07:27:16 +0000</creation_ts>
          <short_desc>keuphoria occasionally only using quarter of screen</short_desc>
          <delta_ts>2011-06-02 16:08:18 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>10</classification_id>
          <classification>Unmaintained</classification>
          <product>kscreensaver</product>
          <component>general</component>
          <version>unspecified</version>
          <rep_platform>Debian testing</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ben Burton">bab</reporter>
          <assigned_to name="kscreensaver bugs tracking">kscreensaver-bugs-null</assigned_to>
          <cc>4ernov</cc>
    
    <cc>alecm</cc>
    
    <cc>ana</cc>
    
    <cc>bobby.culture</cc>
    
    <cc>georg.wittenburg</cc>
    
    <cc>ivo</cc>
    
    <cc>kocur666</cc>
    
    <cc>l.lunak</cc>
    
    <cc>markrose</cc>
    
    <cc>missive</cc>
    
    <cc>nickt</cc>
    
    <cc>pothibo</cc>
    
    <cc>ronisbr</cc>
    
    <cc>sh</cc>
    
    <cc>simon</cc>
    
    <cc>thilo</cc>
    
    <cc>vR</cc>
    
    <cc>walch.martin</cc>
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>40</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>168508</commentid>
    <comment_count>0</comment_count>
    <who name="Ben Burton">bab</who>
    <bug_when>2003-10-24 07:27:16 +0000</bug_when>
    <thetext>Version:            (using KDE KDE 3.1.4)
Installed from:    Debian testing/unstable Packages

Received through the Debian BTS (#207536).

&quot;Occasionally (1 in 50 times,  ish?) I&apos;m finding that the keuphoria screensaver only uses the top left hand corner of my screen rather than the whole screen.  Its happened a handful of times now.&quot;

If you want further details it&apos;s probably best to ask the original submitter (David Gilbert, gilbertd@treblig.org) since this one is difficult to reproduce.

Ben. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>181351</commentid>
    <comment_count>1</comment_count>
    <who name="James Guo">jinp</who>
    <bug_when>2003-11-29 12:39:11 +0000</bug_when>
    <thetext>Have same problem in fedora core 1.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>520205</commentid>
    <comment_count>2</comment_count>
    <who name="Oswald Buddenhagen">ossi</who>
    <bug_when>2007-04-12 13:24:46 +0000</bug_when>
    <thetext>anybody can still reproduce this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>525419</commentid>
    <comment_count>3</comment_count>
    <who name="Oswald Buddenhagen">ossi</who>
    <bug_when>2007-05-12 12:29:49 +0000</bug_when>
    <thetext>*** Bug 112872 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>526624</commentid>
    <comment_count>4</comment_count>
    <who name="Oswald Buddenhagen">ossi</who>
    <bug_when>2007-05-18 20:29:13 +0000</bug_when>
    <thetext>*** Bug 119797 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>597049</commentid>
    <comment_count>5</comment_count>
    <who name="Oswald Buddenhagen">ossi</who>
    <bug_when>2008-04-25 21:54:48 +0000</bug_when>
    <thetext>is this still reproducible with kde4?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>607488</commentid>
    <comment_count>6</comment_count>
    <who name="Lubos Lunak">l.lunak</who>
    <bug_when>2008-06-05 11:29:04 +0000</bug_when>
    <thetext>Waiting for anybody to confirm the bug still exists.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>629408</commentid>
    <comment_count>7</comment_count>
    <who name="Oswald Buddenhagen">ossi</who>
    <bug_when>2008-07-26 12:29:52 +0000</bug_when>
    <thetext>*** Bug 167456 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>629814</commentid>
    <comment_count>8</comment_count>
    <who name="Oswald Buddenhagen">ossi</who>
    <bug_when>2008-07-27 20:59:48 +0000</bug_when>
    <thetext>*** Bug 163536 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>629815</commentid>
    <comment_count>9</comment_count>
    <who name="Oswald Buddenhagen">ossi</who>
    <bug_when>2008-07-27 21:00:39 +0000</bug_when>
    <thetext>lubos, i think we have enough confirmations now. :}
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>629929</commentid>
    <comment_count>10</comment_count>
    <who name="Jason &apos;vanRijn&apos; Kasper">vR</who>
    <bug_when>2008-07-28 07:10:15 +0000</bug_when>
    <thetext>I&apos;ll just note that I never have and still do not see this in a KDE3 session. But bug #163536 is extremely reproducible (much more than 1/50) in KDE4.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>632117</commentid>
    <comment_count>11</comment_count>
    <who name="Christian Nitschkowski">christian.nitschkowski</who>
    <bug_when>2008-08-01 18:24:37 +0000</bug_when>
    <thetext>I just wanted to open a report for this issue.
During the Beta and RC-phase of KDE 4.1 I had the described issue a few times.
Since an RC+-build of SuSE I have this problem all of the time.
I now use KDE 4.1.0 and the problem is still there always.
Using NVidia GeForce 7600 GT with NVidia 173.14.09 drivers</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>635847</commentid>
    <comment_count>12</comment_count>
    <who name="Alexey Chernov">4ernov</who>
    <bug_when>2008-08-09 15:30:56 +0000</bug_when>
    <thetext>I can confirm for KDE 4.1.0 (Qt 4.4.1), NVidia GeForce 8600 GT with 177.13 beta proprietary drivers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>651122</commentid>
    <comment_count>13</comment_count>
    <who name="Staffan Hamala">sh</who>
    <bug_when>2008-10-05 10:56:59 +0000</bug_when>
    <thetext>The problem still exists in KDE 4.1.2. This happens about 80% of the time. So it is VERY reproducable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>651123</commentid>
    <comment_count>14</comment_count>
    <who name="Staffan Hamala">sh</who>
    <bug_when>2008-10-05 10:59:27 +0000</bug_when>
    <thetext>(In reply to comment #13)
&gt; The problem still exists in KDE 4.1.2. This happens about 80% of the time. So
&gt; it is VERY reproducable.

I&apos;m also using nVidia. Driver version 169.12. FeForce 7100 GS
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>651285</commentid>
    <comment_count>15</comment_count>
    <who name="Pier-Olivier Thibault">pothibo</who>
    <bug_when>2008-10-05 18:44:00 +0000</bug_when>
    <thetext>I also have this issue running on Nvidia and Dual Screen set up.

Compiled from source on 2008/10/01.

main screen: the screen saver uses 1/4 of the screen (top left hand)
Secondary screen: All blank.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>665838</commentid>
    <comment_count>16</comment_count>
    <who name="ndarkduck">av_libre</who>
    <bug_when>2008-11-16 20:51:36 +0000</bug_when>
    <thetext>I have exactly the same problem. It wasnt on ubuntu 8.04, but on upgrade to ubuntu 8.10  w/ kde 4 it happens most of the time 9/10.

I&apos;m willing to give any information.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>692900</commentid>
    <comment_count>17</comment_count>
    <who name="Georg Wittenburg">georg.wittenburg</who>
    <bug_when>2009-01-03 00:54:27 +0000</bug_when>
    <thetext>I&apos;m seeing this problem with 4.1.85 (unofficial packages from kde42.debian.net at version 4:4.1.85+svn899741-0r1). It&apos;s reproducible about 50% of the time for certain GL screensavers, e.g. Euphoria, Flux, Gravity, KRotation, Particle Fountain, Solar Winds. None of the screensaver packaged in xscreensaver-gl have this issue.

Like some reporters, I&apos;m using a nVidia GPU (GeForce 8600M GS with driver 177.82). Is this reproducible on Intel or ATI GPUs?

Further, I haven&apos;t see this happening prior (and including in) 4.1.x. I&apos;m not sure whether the upgrade to 4.2 beta or something else caused it to appear.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>701404</commentid>
    <comment_count>18</comment_count>
    <who name="Alec Moskvin">alecm</who>
    <bug_when>2009-01-17 19:13:06 +0000</bug_when>
    <thetext>I&apos;m having the same problem as in Comment #17, except I&apos;d say it&apos;s more like 66% of the time.

To reproduce, set screensaver as &quot;Solar Winds (GL)&quot; and click test a few times.
It results in the screensaver starting in the top-left corner with the rest of the screen white.

This happens in KDE 4.1.96 (KDE 4.2 RC1) with the latest beta NVIDIA drivers, version 180.22. My graphics card is GeForce Go7300.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>726987</commentid>
    <comment_count>19</comment_count>
    <who name="Martin Walch">walch.martin</who>
    <bug_when>2009-03-08 00:45:32 +0000</bug_when>
    <thetext>Does not seem to be nvidia related. I get this problem with my Intel GMA X3000, too. It looks like the screensaver is run in demo mode instead of root mode.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>727428</commentid>
    <comment_count>20</comment_count>
    <who name="Thilo-Alexander Ginkel">thilo</who>
    <bug_when>2009-03-08 19:53:42 +0000</bug_when>
    <thetext>*** Bug 165552 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>727541</commentid>
    <comment_count>21</comment_count>
    <who name="DarkElven">kocur666</who>
    <bug_when>2009-03-08 23:24:54 +0000</bug_when>
    <thetext>Ok if Bug 165552 is a duplicate, so i confirm that this bug is still not resolved even with kde-4.2.1 and also it happens to me with qt-4.5.0.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>730595</commentid>
    <comment_count>22</comment_count>
    <who name="Ronan Arraes Jardim Chagas">ronisbr</who>
    <bug_when>2009-03-15 04:40:02 +0000</bug_when>
    <thetext>I also confirmed this bug with KDE 4.2.1 and QT 4.5.0, but I noticed something very interesting: this just happen (in my case) with OpenGL screensavers that comes with KDE. I mean, when I use an OpenGL screensaver of xscreensaver, like GLMatrix, I wasn&apos;t able to reproduce this bug. I&apos;ve turned on and off GLMatrix more than 20 times and it always works correctly, with and without the option to show Plasma Widgets with screensaver.

My system:
- Gentoo Linux
- nVidia Drivers: 180.37
- QT: 4.5.0
- KDE: 4.2.1

* KScreenSaver was compiled with xscreensaver support (xscreensaver USE flag in Gentoo)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737148</commentid>
    <comment_count>23</comment_count>
      <attachid>32504</attachid>
    <who name="Ivo Anjo">ivo</who>
    <bug_when>2009-03-31 19:24:28 +0000</bug_when>
    <thetext>Created attachment 32504
Fix

Ok so I finally got fed up with this bug this week, and decided to not rest until it&apos;s solved :)

My analysis of the problem is: most screensavers just subclass KScreenSaver, and do their stuff on paintEvent(). Opengl screensavers on the other hand, need to work with a QGlWidget, instead of QWidget which is what KScreenSaver is, so they create a QGlWidget, and then use XEmbed to place that widget inside a KScreenSaver. The problem is that by doing this using X11 calls, the QGlWidget isn&apos;t alerted of changes on his parent in this case (because it has no parent, unlike normal widgets).

So my solution is for KScreenSaver to keep a pointer to the widget when embed() gets called, and to propagate resizeEvents to this widget when it receives them.

The attached patch implements this.

This patch fixes all the opengl screensavers I tested: kflux, kfountain, ksolarwinds, kwave, keuphoria and kgravity. To test it just start any screensaver from the shell (for example kflux.kss) and then resize the window: you&apos;ll notice that without the patch the &quot;opengl&quot; view is never resized.

I haven&apos;t commited this yet, but if I can get some confirmations that it&apos;s all ok (including trying with --setup and inside systemsettings), I&apos;ll commit this to trunk and to branch. Thanks in advance :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737164</commentid>
    <comment_count>24</comment_count>
    <who name="Martin Walch">walch.martin</who>
    <bug_when>2009-03-31 20:28:08 +0000</bug_when>
    <thetext>I just tested this and resizing works fine now. But the main problem remains: sometimes the OpenGL screensavers take up only about a quarter of the screen in the upper left. Sorry.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737186</commentid>
    <comment_count>25</comment_count>
      <attachid>32507</attachid>
    <who name="Ivo Anjo">ivo</who>
    <bug_when>2009-03-31 21:48:59 +0000</bug_when>
    <thetext>Created attachment 32507
Fix, try 2

Thanks a lot for testing. Yeah you were right, after hammering on it for a while eventually I get the bug again, so it seems that patch reduced the frequency it happened, but didn&apos;t fully remove the bug.

Here&apos;s a new patch with a fix to set the gl widget size before XEmbed&apos;ing it: I think this was what was missing to get it fully working.

If you could please re-test, thanks :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737192</commentid>
    <comment_count>26</comment_count>
    <who name="Martin Walch">walch.martin</who>
    <bug_when>2009-03-31 22:47:13 +0000</bug_when>
    <thetext>(In reply to comment #25)

the good news: the problem seems to be gone

the bad news: WIth intensive testing I get kernel panics (Linux)

the even worse news: I have not figured out, yet, if it is related to the fix.

&gt; Here&apos;s a new patch with a fix to set the gl widget size before XEmbed&apos;ing it: I
&gt; think this was what was missing to get it fully working.

I don&apos;t want to be mean, but... is this really a fix? Shouldn&apos;t the inital size be the right one without setting it explicitely?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737195</commentid>
    <comment_count>27</comment_count>
    <who name="Ivo Anjo">ivo</who>
    <bug_when>2009-03-31 23:03:10 +0000</bug_when>
    <thetext>Nice to see it seems to be fixed for you :)

As for the kernel panics, I tested it pretty hard before posting this second patch, and no problems at all here (pc on since I woke up this morning). I&apos;m running on an nvidia 8600GT with the 180.29 drivers.

Finally,
&gt; I don&apos;t want to be mean, but... is this really a fix? Shouldn&apos;t the inital size
&gt; be the right one without setting it explicitely?

The problem is that the real screensaver widget is KScreenSaver. The XEmbed is there to suck another top-level window (the one with the opengl animation) inside the screensaver one. I did a small test application and found that if you don&apos;t give a size to a top-level QGlWidget, the default will be 640x480 so I&apos;m guessing part of the bug was a race: maybe the default size was set before the embed, maybe after, and that was causing the &quot;works sometimes, other times it doesn&apos;t&quot;.

In both my small test app and kscreensaver, setting the right size (e.g. telling the gl widget that its size should be that of the real screensaver widget) before XEmbed&apos;ding did the trick.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737200</commentid>
    <comment_count>28</comment_count>
    <who name="Martin Walch">walch.martin</who>
    <bug_when>2009-03-31 23:18:29 +0000</bug_when>
    <thetext>The crash is indeed related to the fix. The crash is even worse and I can reproduce it. But I agree, that this is probably driver and maybe hardware related (but I am not sure, I am using an Intel G965 with xorg-video-intel-2.5.1).

steps to reproduce (DANGER!):
1. open Konsole
2. run keuphoria.kss
3. close it
4. run keuphoria.kss --root
5. resize that window (this is where the patch comes in!)
6. close the window
7. keuphoria.kss will not stop before killing the process with SIGTERM (ctrl+c)
8. press ctrl+c
9. open systemsettings
10. choose Desktop, then Screen Saver
11. choose Euphoria and click Test

This results in a hard lock. Caps Lock and Scroll Lock are blinking.

(After turning the computer off by pressing the power button for five seconds, and turning it on again, X does not start on first try, because the graphics chip is still in an invalid state.)

Anyway, this probably does not have anything to do with this bug. However, I am not sure, yet, where to open a new bug. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737206</commentid>
    <comment_count>29</comment_count>
    <who name="Ivo Anjo">ivo</who>
    <bug_when>2009-03-31 23:34:08 +0000</bug_when>
    <thetext>I can reproduce that crash here -- although I get some X Errors on the shell when I close the screensaver window, but those were already there before the patch.

Let&apos;s hope someone with an Intel driver can test this. Unfortunately, I only have access to ati and nvidia hardware.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737207</commentid>
    <comment_count>30</comment_count>
    <who name="Ivo Anjo">ivo</who>
    <bug_when>2009-03-31 23:34:59 +0000</bug_when>
    <thetext>Damn, I meant to say &quot;I can&apos;t&quot;, not I can. It works fine here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737212</commentid>
    <comment_count>31</comment_count>
    <who name="Oswald Buddenhagen">ossi</who>
    <bug_when>2009-04-01 00:16:45 +0000</bug_when>
    <thetext>the patch is, ermm, &quot;suboptimal&quot; (it breaks binary compatibility and disregards the coding style), but the analysis of the problem is very helpful. :)

martin: nvidia is very happy about every linux driver bug report they get (of course they are, right? there can never be enough). so make them happy. :D</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737214</commentid>
    <comment_count>32</comment_count>
    <who name="Ivo Anjo">ivo</who>
    <bug_when>2009-04-01 00:33:39 +0000</bug_when>
    <thetext>(In reply to comment #31)
&gt; the patch is, ermm, &quot;suboptimal&quot; (it breaks binary compatibility and disregards
&gt; the coding style), but the analysis of the problem is very helpful. :)

I could catch the resize inside the event() call, instead of inside resizeEvent(). As for avoiding the slot for saving the QWidget the only way I can think of is to create a wrapper class that is a QObject, and setting the KScreenSaver as parent, and when we need to access it (not very often), ask for the children of KScreenSaver and search for that object.

As for the coding style, I tried to copy the original. Could you point out where I got it wrong? The only thing I can think of is adding a space after each &apos;(&apos; and before each &apos;)&apos; .

&gt; martin: nvidia is very happy about every linux driver bug report they get (of
&gt; course they are, right? there can never be enough). so make them happy. :D

Martin seems to be having problems with intel, not nvidia hardware.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737306</commentid>
    <comment_count>33</comment_count>
      <attachid>32515</attachid>
    <who name="Ivo Anjo">ivo</who>
    <bug_when>2009-04-01 10:42:28 +0000</bug_when>
    <thetext>Created attachment 32515
Fix, try 3

So, third version of the patch. This one should preserve binary compatibility: I catch the resize event inside event() and use the d-pointer to keep the extra member I needed (before I was confused because I thought other subclasses were also using the d-pointer but I understand now).

I also tried to add the extra spaces to preserve the original style.

Is this version of the patch acceptable? Thanks for the feedback so far.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737314</commentid>
    <comment_count>34</comment_count>
    <who name="Martin Walch">walch.martin</who>
    <bug_when>2009-04-01 11:03:32 +0000</bug_when>
    <thetext>That fix also works fine.
Concerning binary compatibility: also seems to be good. Works for me without relinking.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737320</commentid>
    <comment_count>35</comment_count>
    <who name="Oswald Buddenhagen">ossi</who>
    <bug_when>2009-04-01 11:19:43 +0000</bug_when>
    <thetext>that one is technically correct. there is still room for improvement, though: :)

i don&apos;t think you need to include QResizeEvent.
there is a resize() overload which takes a QSize.
trivial constructors of private classes are typically inlined.
the creation of the private object is typically put into the c&apos;tor&apos;s variable initializer list (i.e., before the opening brace).
you are leaking the private object.
given that the private object contains exactly one pointer, it might be preferable to replace the unused d pointer with that one, adding a big fat note that if more members are added, they need to be moved to a private object.
make a line break after the if&apos;s condition.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737324</commentid>
    <comment_count>36</comment_count>
      <attachid>32516</attachid>
    <who name="Ivo Anjo">ivo</who>
    <bug_when>2009-04-01 12:03:07 +0000</bug_when>
    <thetext>Created attachment 32516
Fix, try 4

(In reply to comment #35)

Fixed most of the suggestions, thanks (the patch seems to be getting smaller, a few more iterations and don&apos;t I anything will be left).

&gt; given that the private object contains exactly one pointer, it might be
&gt; preferable to replace the unused d pointer with that one, adding a big fat note
&gt; that if more members are added, they need to be moved to a private object.

As for this one, I think that would just complicate things, for a savings of a couple of extra bytes, so I think this way is cleaner. (But if you think that it really should be done that way, I could do that too).

Thanks</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737331</commentid>
    <comment_count>37</comment_count>
    <who name="Oswald Buddenhagen">ossi</who>
    <bug_when>2009-04-01 12:48:22 +0000</bug_when>
    <thetext>(In reply to comment #36)
&gt; (the patch seems to be getting smaller, a
&gt; few more iterations and don&apos;t I anything will be left).
&gt; 
hehe

&gt; &gt; [...] it might be
&gt; &gt; preferable to replace the unused d pointer with that one, [...]
&gt; 
&gt; As for this one, I think that would just complicate things, for a savings of a
&gt; couple of extra bytes, so I think this way is cleaner.
&gt;
it wouldn&apos;t complicate anything, as it would be just the straight-forward, non-d-pointer-ized variant. in fact, it would work towards the goal of making the patch disappear. :D
it is true that it would complicate the next addition, as that one would have to do the d pointer transformation in the first place, but given the frequency at which new members are added, this seems fairly acceptable to me. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737340</commentid>
    <comment_count>38</comment_count>
      <attachid>32517</attachid>
    <who name="Ivo Anjo">ivo</who>
    <bug_when>2009-04-01 13:08:33 +0000</bug_when>
    <thetext>Created attachment 32517
Fix, try 6

This new version uses the d-pointer to store the widget.

If it&apos;s ok with you I&apos;ll commit it (always wanted do kill a many-year-old-bug) :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737342</commentid>
    <comment_count>39</comment_count>
    <who name="Lubos Lunak">l.lunak</who>
    <bug_when>2009-04-01 13:21:04 +0000</bug_when>
    <thetext>I&apos;d prefer if we didn&apos;t ask for ubergeek ugly hacks for reasons that absolutely don&apos;t matter in practice. Please use the version with the proper d pointer.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737349</commentid>
    <comment_count>40</comment_count>
    <who name="Oswald Buddenhagen">ossi</who>
    <bug_when>2009-04-01 13:56:30 +0000</bug_when>
    <thetext>huh, i didn&apos;t ask you to do typecasts - that&apos;s just plain ugly. replace the declaration of d accordingly and leave a note that it needs to be transformed into a d pointer once more members are needed. this &quot;trick&quot; is used fairly often in qt and kde code.

of course, the unnecessary use of a private object doesn&apos;t matter at all in this case, but having the minimal implementation just makes the code nicer to read. and, after all, ivo will now have tried about every conceivable approach to the problem - for good practice. try 4 is good enough if the practice is not called for. :D</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737438</commentid>
    <comment_count>41</comment_count>
      <attachid>32523</attachid>
    <who name="Ivo Anjo">ivo</who>
    <bug_when>2009-04-01 19:20:55 +0000</bug_when>
    <thetext>Created attachment 32523
Fix, try 7 (hey, whatever happened to 5!?)

I misunderstood what Oswald was saying. I think I got it, so here&apos;s a version that &quot;replaces&quot; the dpointer with the pointer to the widget.

So, try 4 or try 7, take your pick :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737555</commentid>
    <comment_count>42</comment_count>
    <who name="Oswald Buddenhagen">ossi</who>
    <bug_when>2009-04-02 00:00:00 +0000</bug_when>
    <thetext>haha, ok, one more try: use the member name from try 1, and move the comment above the commented out d pointer, altering it to something like &quot;for binary compatibility reasons, this class must have exactly one data member which is a pointer. if more members are added, uncomment the private object and move the members into it&quot;.

yes, i was also wondering about #5. i assume it was eaten by today&apos;s date.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737568</commentid>
    <comment_count>43</comment_count>
      <attachid>32527</attachid>
    <who name="Ivo Anjo">ivo</who>
    <bug_when>2009-04-02 01:18:52 +0000</bug_when>
    <thetext>Created attachment 32527
Fix, try 8

Ok, so I&apos;ve gone back to embeddedWidget, and added the note to the header file.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737654</commentid>
    <comment_count>44</comment_count>
    <who name="Oswald Buddenhagen">ossi</who>
    <bug_when>2009-04-02 11:11:01 +0000</bug_when>
    <thetext>u can&apos;t trick me - this is try 7! and that&apos;s a fairly good number for a final version. :-D

i assume do do the backport as well?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737672</commentid>
    <comment_count>45</comment_count>
    <who name="Ivo Anjo">ivo</who>
    <bug_when>2009-04-02 12:07:08 +0000</bug_when>
    <thetext>Ok so I&apos;ll commit try 8 (or is it 7!?) when I get home, and I&apos;ll also backport it (don&apos;t know if there&apos;s going to be a 4.2.3 though, but I hope so, so I can get this fix via distro packages).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737675</commentid>
    <comment_count>46</comment_count>
    <who name="Martin Walch">walch.martin</who>
    <bug_when>2009-04-02 12:14:43 +0000</bug_when>
    <thetext>Attachment #32527 also works fine. Resizing works, full screen is used and it
is binary compatible.

(What I did not test was the Kernel panic, which is very likely not gone, but I
do not want to let my system crash again :))</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737876</commentid>
    <comment_count>47</comment_count>
    <who name="Ivo Anjo">ivo</who>
    <bug_when>2009-04-02 21:53:45 +0000</bug_when>
    <thetext>SVN commit 948339 by ianjo:

Pass along resize events to the embedded widget, and also set the correct
size for the widget before using XReparentWindow on it.

Thanks for all the feedback and testing of the patch!

BUG: 66492



 M  +5 -1      kscreensaver.cpp  
 M  +5 -1      kscreensaver.h  


WebSVN link: http://websvn.kde.org/?view=rev&amp;revision=948339</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>737891</commentid>
    <comment_count>48</comment_count>
    <who name="Ivo Anjo">ivo</who>
    <bug_when>2009-04-02 22:15:01 +0000</bug_when>
    <thetext>SVN commit 948349 by ianjo:

Backport r948339.
Pass along resize events to the embedded widget, and also set the
correct size for the widget before using XReparentWindow on it.

Thanks for all the feedback and testing of the patch!

CCBUG: 66492



 M  +5 -1      kscreensaver.cpp  
 M  +5 -1      kscreensaver.h  


WebSVN link: http://websvn.kde.org/?view=rev&amp;revision=948349</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>753917</commentid>
    <comment_count>49</comment_count>
    <who name="Mark Rose">markrose</who>
    <bug_when>2009-05-08 05:11:42 +0000</bug_when>
    <thetext>Hey, thanks for fixing this!! Now I can use all the beautiful screen savers again! :D</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1126396</commentid>
    <comment_count>50</comment_count>
    <who name="Oswald Buddenhagen">ossi</who>
    <bug_when>2011-06-02 16:07:24 +0000</bug_when>
    <thetext>*** Bug 165413 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1126399</commentid>
    <comment_count>51</comment_count>
    <who name="Oswald Buddenhagen">ossi</who>
    <bug_when>2011-06-02 16:08:18 +0000</bug_when>
    <thetext>*** Bug 183819 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32504</attachid>
            <date>2009-03-31 19:24:28 +0000</date>
            <delta_ts>2009-03-31 21:48:59 +0000</delta_ts>
            <desc>Fix</desc>
            <filename>kscreensaver_embed_fix.patch</filename>
            <type>text/plain</type>
            <size>1611</size>
            <attacher name="Ivo Anjo">ivo</attacher>
            
              <data encoding="base64">SW5kZXg6IHdvcmtzcGFjZS9rc2NyZWVuc2F2ZXIvbGlia3NjcmVlbnNhdmVyL2tzY3JlZW5zYXZl
ci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIHdvcmtzcGFjZS9rc2NyZWVuc2F2ZXIvbGlia3NjcmVlbnNhdmVy
L2tzY3JlZW5zYXZlci5oCShyZXZpc2lvbiA5NDcyNzcpCisrKyB3b3Jrc3BhY2Uva3NjcmVlbnNh
dmVyL2xpYmtzY3JlZW5zYXZlci9rc2NyZWVuc2F2ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNjIs
OSArNjIsMTEgQEAKICAgICAgKi8KICAgICB2b2lkIGVtYmVkKCBRV2lkZ2V0ICp3aWRnZXQgKTsK
ICAgICBib29sIGV2ZW50KCBRRXZlbnQqIGV2ZW50ICk7CisgICAgdm9pZCByZXNpemVFdmVudChR
UmVzaXplRXZlbnQgKmV2ZW50KTsKIAogcHJpdmF0ZToKICAgICBLU2NyZWVuU2F2ZXJQcml2YXRl
ICpkOworICAgIFFXaWRnZXQgKmVtYmVkZGVkV2lkZ2V0OwogfTsKIAogLyoqCkluZGV4OiB3b3Jr
c3BhY2Uva3NjcmVlbnNhdmVyL2xpYmtzY3JlZW5zYXZlci9rc2NyZWVuc2F2ZXIuY3BwCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIHdvcmtzcGFjZS9rc2NyZWVuc2F2ZXIvbGlia3NjcmVlbnNhdmVyL2tzY3JlZW5z
YXZlci5jcHAJKHJldmlzaW9uIDk0NzI3NykKKysrIHdvcmtzcGFjZS9rc2NyZWVuc2F2ZXIvbGli
a3NjcmVlbnNhdmVyL2tzY3JlZW5zYXZlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2LDYgKzI2
LDcgQEAKICNpbmNsdWRlIDxRQXBwbGljYXRpb24+CiAjaW5jbHVkZSA8UURlYnVnPgogI2luY2x1
ZGUgPGtyYW5kb20uaD4KKyNpbmNsdWRlIDxRUmVzaXplRXZlbnQ+CiAKICNpZmRlZiBRX1dTX1gx
MQogI2luY2x1ZGUgPFgxMS9YbGliLmg+CkBAIC0zMyw3ICszNCw3IEBACiAKIC8vLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0KIAotS1NjcmVlblNhdmVyOjpLU2NyZWVuU2F2ZXIoIFdJZCBpZCApIDogUVdp
ZGdldCgpCitLU2NyZWVuU2F2ZXI6OktTY3JlZW5TYXZlciggV0lkIGlkICkgOiBRV2lkZ2V0KCks
IGVtYmVkZGVkV2lkZ2V0KDApCiB7CiAgICAgaWYgKCBpZCApCiAgICAgewpAQCAtNjEsNiArNjIs
NyBAQAogICAgIFhSZXBhcmVudFdpbmRvdyhRWDExSW5mbzo6ZGlzcGxheSgpLCB3LT53aW5JZCgp
LCB3aW5JZCgpLCAwLCAwKTsKICNlbmRpZgogICAgIHctPnNldEdlb21ldHJ5KCAwLCAwLCB3aWR0
aCgpLCBoZWlnaHQoKSApOworICAgIGVtYmVkZGVkV2lkZ2V0ID0gdzsKICAgICBRQXBwbGljYXRp
b246OnNlbmRQb3N0ZWRFdmVudHMoKTsKIH0KIApAQCAtNjgsNiArNzAsMTAgQEAKIHsKIH0KIAor
dm9pZCBLU2NyZWVuU2F2ZXI6OnJlc2l6ZUV2ZW50KFFSZXNpemVFdmVudCAqZXZlbnQpIHsKKyAg
ICBpZiAoZW1iZWRkZWRXaWRnZXQpIGVtYmVkZGVkV2lkZ2V0LT5yZXNpemUod2lkdGgoKSwgaGVp
Z2h0KCkpOworfQorCiBRRGlhbG9nKiBLU2NyZWVuU2F2ZXJJbnRlcmZhY2U6OnNldHVwKCkKIHsK
ICAgICByZXR1cm4gMDsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32507</attachid>
            <date>2009-03-31 21:48:59 +0000</date>
            <delta_ts>2009-04-01 10:42:28 +0000</delta_ts>
            <desc>Fix, try 2</desc>
            <filename>kscreensaver_embed_fix_2.patch</filename>
            <type>text/plain</type>
            <size>1757</size>
            <attacher name="Ivo Anjo">ivo</attacher>
            
              <data encoding="base64">SW5kZXg6IHdvcmtzcGFjZS9rc2NyZWVuc2F2ZXIvbGlia3NjcmVlbnNhdmVyL2tzY3JlZW5zYXZl
ci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIHdvcmtzcGFjZS9rc2NyZWVuc2F2ZXIvbGlia3NjcmVlbnNhdmVy
L2tzY3JlZW5zYXZlci5oCShyZXZpc2lvbiA5NDcyNzcpCisrKyB3b3Jrc3BhY2Uva3NjcmVlbnNh
dmVyL2xpYmtzY3JlZW5zYXZlci9rc2NyZWVuc2F2ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNjIs
OSArNjIsMTEgQEAKICAgICAgKi8KICAgICB2b2lkIGVtYmVkKCBRV2lkZ2V0ICp3aWRnZXQgKTsK
ICAgICBib29sIGV2ZW50KCBRRXZlbnQqIGV2ZW50ICk7CisgICAgdm9pZCByZXNpemVFdmVudChR
UmVzaXplRXZlbnQgKmV2ZW50KTsKIAogcHJpdmF0ZToKICAgICBLU2NyZWVuU2F2ZXJQcml2YXRl
ICpkOworICAgIFFXaWRnZXQgKmVtYmVkZGVkV2lkZ2V0OwogfTsKIAogLyoqCkluZGV4OiB3b3Jr
c3BhY2Uva3NjcmVlbnNhdmVyL2xpYmtzY3JlZW5zYXZlci9rc2NyZWVuc2F2ZXIuY3BwCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIHdvcmtzcGFjZS9rc2NyZWVuc2F2ZXIvbGlia3NjcmVlbnNhdmVyL2tzY3JlZW5z
YXZlci5jcHAJKHJldmlzaW9uIDk0NzI3NykKKysrIHdvcmtzcGFjZS9rc2NyZWVuc2F2ZXIvbGli
a3NjcmVlbnNhdmVyL2tzY3JlZW5zYXZlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2LDYgKzI2
LDcgQEAKICNpbmNsdWRlIDxRQXBwbGljYXRpb24+CiAjaW5jbHVkZSA8UURlYnVnPgogI2luY2x1
ZGUgPGtyYW5kb20uaD4KKyNpbmNsdWRlIDxRUmVzaXplRXZlbnQ+CiAKICNpZmRlZiBRX1dTX1gx
MQogI2luY2x1ZGUgPFgxMS9YbGliLmg+CkBAIC0zMyw3ICszNCw3IEBACiAKIC8vLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0KIAotS1NjcmVlblNhdmVyOjpLU2NyZWVuU2F2ZXIoIFdJZCBpZCApIDogUVdp
ZGdldCgpCitLU2NyZWVuU2F2ZXI6OktTY3JlZW5TYXZlciggV0lkIGlkICkgOiBRV2lkZ2V0KCks
IGVtYmVkZGVkV2lkZ2V0KDApCiB7CiAgICAgaWYgKCBpZCApCiAgICAgewpAQCAtNTYsMTEgKzU3
LDEzIEBACiAKIHZvaWQgS1NjcmVlblNhdmVyOjplbWJlZCggUVdpZGdldCAqdyApCiB7CisgICAg
dy0+cmVzaXplKHdpZHRoKCksIGhlaWdodCgpKTsKICAgICBRQXBwbGljYXRpb246OnNlbmRQb3N0
ZWRFdmVudHMoKTsKICNpZmRlZiBRX1dTX1gxMSAvL0ZJWE1FCiAgICAgWFJlcGFyZW50V2luZG93
KFFYMTFJbmZvOjpkaXNwbGF5KCksIHctPndpbklkKCksIHdpbklkKCksIDAsIDApOwogI2VuZGlm
CiAgICAgdy0+c2V0R2VvbWV0cnkoIDAsIDAsIHdpZHRoKCksIGhlaWdodCgpICk7CisgICAgZW1i
ZWRkZWRXaWRnZXQgPSB3OwogICAgIFFBcHBsaWNhdGlvbjo6c2VuZFBvc3RlZEV2ZW50cygpOwog
fQogCkBAIC02OCw2ICs3MSwxMCBAQAogewogfQogCit2b2lkIEtTY3JlZW5TYXZlcjo6cmVzaXpl
RXZlbnQoUVJlc2l6ZUV2ZW50ICpldmVudCkgeworICAgIGlmIChlbWJlZGRlZFdpZGdldCkgZW1i
ZWRkZWRXaWRnZXQtPnJlc2l6ZSh3aWR0aCgpLCBoZWlnaHQoKSk7Cit9CisKIFFEaWFsb2cqIEtT
Y3JlZW5TYXZlckludGVyZmFjZTo6c2V0dXAoKQogewogICAgIHJldHVybiAwOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32515</attachid>
            <date>2009-04-01 10:42:28 +0000</date>
            <delta_ts>2009-04-01 12:03:07 +0000</delta_ts>
            <desc>Fix, try 3</desc>
            <filename>kscreensaver_embed_fix_4.patch</filename>
            <type>text/plain</type>
            <size>1529</size>
            <attacher name="Ivo Anjo">ivo</attacher>
            
              <data encoding="base64">SW5kZXg6IHdvcmtzcGFjZS9rc2NyZWVuc2F2ZXIvbGlia3NjcmVlbnNhdmVyL2tzY3JlZW5zYXZl
ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gd29ya3NwYWNlL2tzY3JlZW5zYXZlci9saWJrc2NyZWVuc2F2
ZXIva3NjcmVlbnNhdmVyLmNwcAkocmV2aXNpb24gOTQ3Mjc3KQorKysgd29ya3NwYWNlL2tzY3Jl
ZW5zYXZlci9saWJrc2NyZWVuc2F2ZXIva3NjcmVlbnNhdmVyLmNwcAkod29ya2luZyBjb3B5KQpA
QCAtMjYsNiArMjYsNyBAQAogI2luY2x1ZGUgPFFBcHBsaWNhdGlvbj4KICNpbmNsdWRlIDxRRGVi
dWc+CiAjaW5jbHVkZSA8a3JhbmRvbS5oPgorI2luY2x1ZGUgPFFSZXNpemVFdmVudD4KIAogI2lm
ZGVmIFFfV1NfWDExCiAjaW5jbHVkZSA8WDExL1hsaWIuaD4KQEAgLTMzLDEyICszNCwyMiBAQAog
CiAvLy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKK2NsYXNzIEtTY3JlZW5TYXZlclByaXZhdGUKK3sK
K3B1YmxpYzoKKyAgICBLU2NyZWVuU2F2ZXJQcml2YXRlKCk7CisgICAgUVdpZGdldCAqZW1iZWRk
ZWRXaWRnZXQ7Cit9OworCitLU2NyZWVuU2F2ZXJQcml2YXRlOjpLU2NyZWVuU2F2ZXJQcml2YXRl
KCkgOiBlbWJlZGRlZFdpZGdldCggMCApIHsgfQorCiBLU2NyZWVuU2F2ZXI6OktTY3JlZW5TYXZl
ciggV0lkIGlkICkgOiBRV2lkZ2V0KCkKIHsKICAgICBpZiAoIGlkICkKICAgICB7CiAgICAgICAg
IGNyZWF0ZSggaWQsIGZhbHNlLCB0cnVlICk7CiAgICAgfQorICAgIGQgPSBuZXcgS1NjcmVlblNh
dmVyUHJpdmF0ZTsKIH0KIAogS1NjcmVlblNhdmVyOjp+S1NjcmVlblNhdmVyKCkKQEAgLTUxLDE2
ICs2MiwyMCBAQAogICAgIGJvb2wgciA9IFFXaWRnZXQ6OmV2ZW50KGUpOwogICAgIGlmIChlLT50
eXBlKCkgPT0gUUV2ZW50OjpQb2xpc2gpCiAgICAgICAgIHNldEF0dHJpYnV0ZShRdDo6V0FfU3R5
bGVkQmFja2dyb3VuZCwgZmFsc2UpOworICAgIGlmIChlLT50eXBlKCkgPT0gUUV2ZW50OjpSZXNp
emUpCisgICAgICAgIGlmIChkLT5lbWJlZGRlZFdpZGdldCkgZC0+ZW1iZWRkZWRXaWRnZXQtPnJl
c2l6ZSggd2lkdGgoKSwgaGVpZ2h0KCkgKTsKICAgICByZXR1cm4gcjsKIH0KIAogdm9pZCBLU2Ny
ZWVuU2F2ZXI6OmVtYmVkKCBRV2lkZ2V0ICp3ICkKIHsKKyAgICB3LT5yZXNpemUoIHdpZHRoKCks
IGhlaWdodCgpICk7CiAgICAgUUFwcGxpY2F0aW9uOjpzZW5kUG9zdGVkRXZlbnRzKCk7CiAjaWZk
ZWYgUV9XU19YMTEgLy9GSVhNRQogICAgIFhSZXBhcmVudFdpbmRvdyhRWDExSW5mbzo6ZGlzcGxh
eSgpLCB3LT53aW5JZCgpLCB3aW5JZCgpLCAwLCAwKTsKICNlbmRpZgogICAgIHctPnNldEdlb21l
dHJ5KCAwLCAwLCB3aWR0aCgpLCBoZWlnaHQoKSApOworICAgIGQtPmVtYmVkZGVkV2lkZ2V0ID0g
dzsKICAgICBRQXBwbGljYXRpb246OnNlbmRQb3N0ZWRFdmVudHMoKTsKIH0KIAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32516</attachid>
            <date>2009-04-01 12:03:07 +0000</date>
            <delta_ts>2009-04-01 13:08:33 +0000</delta_ts>
            <desc>Fix, try 4</desc>
            <filename>kscreensaver_embed_fix_5.patch</filename>
            <type>text/plain</type>
            <size>1448</size>
            <attacher name="Ivo Anjo">ivo</attacher>
            
              <data encoding="base64">SW5kZXg6IHdvcmtzcGFjZS9rc2NyZWVuc2F2ZXIvbGlia3NjcmVlbnNhdmVyL2tzY3JlZW5zYXZl
ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gd29ya3NwYWNlL2tzY3JlZW5zYXZlci9saWJrc2NyZWVuc2F2
ZXIva3NjcmVlbnNhdmVyLmNwcAkocmV2aXNpb24gOTQ3Mjc3KQorKysgd29ya3NwYWNlL2tzY3Jl
ZW5zYXZlci9saWJrc2NyZWVuc2F2ZXIva3NjcmVlbnNhdmVyLmNwcAkod29ya2luZyBjb3B5KQpA
QCAtMzMsOCArMzMsMTUgQEAKIAogLy8tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCi1LU2NyZWVuU2F2
ZXI6OktTY3JlZW5TYXZlciggV0lkIGlkICkgOiBRV2lkZ2V0KCkKK2NsYXNzIEtTY3JlZW5TYXZl
clByaXZhdGUKIHsKK3B1YmxpYzoKKyAgICBLU2NyZWVuU2F2ZXJQcml2YXRlKCkgOiBlbWJlZGRl
ZFdpZGdldCggMCApIHt9CisgICAgUVdpZGdldCAqZW1iZWRkZWRXaWRnZXQ7Cit9OworCitLU2Ny
ZWVuU2F2ZXI6OktTY3JlZW5TYXZlciggV0lkIGlkICkgOiBRV2lkZ2V0KCksIGQobmV3IEtTY3Jl
ZW5TYXZlclByaXZhdGUpIAorewogICAgIGlmICggaWQgKQogICAgIHsKICAgICAgICAgY3JlYXRl
KCBpZCwgZmFsc2UsIHRydWUgKTsKQEAgLTQ0LDYgKzUxLDcgQEAKIEtTY3JlZW5TYXZlcjo6fktT
Y3JlZW5TYXZlcigpCiB7CiAgICAgZGVzdHJveSggZmFsc2UsIGZhbHNlICk7CisgICAgZGVsZXRl
IGQ7CiB9CiAKIGJvb2wgS1NjcmVlblNhdmVyOjpldmVudChRRXZlbnQqIGUpCkBAIC01MSwxNiAr
NTksMjAgQEAKICAgICBib29sIHIgPSBRV2lkZ2V0OjpldmVudChlKTsKICAgICBpZiAoZS0+dHlw
ZSgpID09IFFFdmVudDo6UG9saXNoKQogICAgICAgICBzZXRBdHRyaWJ1dGUoUXQ6OldBX1N0eWxl
ZEJhY2tncm91bmQsIGZhbHNlKTsKKyAgICBpZiAoKGUtPnR5cGUoKSA9PSBRRXZlbnQ6OlJlc2l6
ZSkgJiYgZC0+ZW1iZWRkZWRXaWRnZXQpCisgICAgICAgIGQtPmVtYmVkZGVkV2lkZ2V0LT5yZXNp
emUoIHNpemUoKSApOwogICAgIHJldHVybiByOwogfQogCiB2b2lkIEtTY3JlZW5TYXZlcjo6ZW1i
ZWQoIFFXaWRnZXQgKncgKQogeworICAgIHctPnJlc2l6ZSggc2l6ZSgpICk7CiAgICAgUUFwcGxp
Y2F0aW9uOjpzZW5kUG9zdGVkRXZlbnRzKCk7CiAjaWZkZWYgUV9XU19YMTEgLy9GSVhNRQogICAg
IFhSZXBhcmVudFdpbmRvdyhRWDExSW5mbzo6ZGlzcGxheSgpLCB3LT53aW5JZCgpLCB3aW5JZCgp
LCAwLCAwKTsKICNlbmRpZgogICAgIHctPnNldEdlb21ldHJ5KCAwLCAwLCB3aWR0aCgpLCBoZWln
aHQoKSApOworICAgIGQtPmVtYmVkZGVkV2lkZ2V0ID0gdzsKICAgICBRQXBwbGljYXRpb246OnNl
bmRQb3N0ZWRFdmVudHMoKTsKIH0KIAo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32517</attachid>
            <date>2009-04-01 13:08:33 +0000</date>
            <delta_ts>2009-04-01 19:20:55 +0000</delta_ts>
            <desc>Fix, try 6</desc>
            <filename>kscreensaver_embed_fix_6.patch</filename>
            <type>text/plain</type>
            <size>1234</size>
            <attacher name="Ivo Anjo">ivo</attacher>
            
              <data encoding="base64">SW5kZXg6IGtzY3JlZW5zYXZlci9saWJrc2NyZWVuc2F2ZXIva3NjcmVlbnNhdmVyLmNwcAo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBrc2NyZWVuc2F2ZXIvbGlia3NjcmVlbnNhdmVyL2tzY3JlZW5zYXZlci5jcHAJ
KHJldmlzaW9uIDk0NzI3NykKKysrIGtzY3JlZW5zYXZlci9saWJrc2NyZWVuc2F2ZXIva3NjcmVl
bnNhdmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzMsNyArMzMsMTAgQEAKIAogLy8tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLQogCi1LU2NyZWVuU2F2ZXI6OktTY3JlZW5TYXZlciggV0lkIGlkICkgOiBR
V2lkZ2V0KCkKKy8vTm90ZTogVGhlIGQtcG9pbnRlciBpcyBjdXJyZW50bHkgYmVpbmcgKGFiKXVz
ZWQgdG8ga2VlcCB0aGUgZW1iZWRkZWQgY2hpbGQgd2lkZ2V0CisvLyAgICAgICBkb24ndCBmb3Jn
ZXQgdG8gY29udmVydCBpdCB0byBhIHByb3BlciBtZW1iZXIgaWYgbmVlZGVkLgorCitLU2NyZWVu
U2F2ZXI6OktTY3JlZW5TYXZlciggV0lkIGlkICkgOiBRV2lkZ2V0KCksIGQoMCkKIHsKICAgICBp
ZiAoIGlkICkKICAgICB7CkBAIC01MSwxNiArNTQsMjAgQEAKICAgICBib29sIHIgPSBRV2lkZ2V0
OjpldmVudChlKTsKICAgICBpZiAoZS0+dHlwZSgpID09IFFFdmVudDo6UG9saXNoKQogICAgICAg
ICBzZXRBdHRyaWJ1dGUoUXQ6OldBX1N0eWxlZEJhY2tncm91bmQsIGZhbHNlKTsKKyAgICBpZiAo
KGUtPnR5cGUoKSA9PSBRRXZlbnQ6OlJlc2l6ZSkgJiYgZCkKKyAgICAgICAgKChRV2lkZ2V0Kilk
KS0+cmVzaXplKCBzaXplKCkgKTsKICAgICByZXR1cm4gcjsKIH0KIAogdm9pZCBLU2NyZWVuU2F2
ZXI6OmVtYmVkKCBRV2lkZ2V0ICp3ICkKIHsKKyAgICB3LT5yZXNpemUoIHNpemUoKSApOwogICAg
IFFBcHBsaWNhdGlvbjo6c2VuZFBvc3RlZEV2ZW50cygpOwogI2lmZGVmIFFfV1NfWDExIC8vRklY
TUUKICAgICBYUmVwYXJlbnRXaW5kb3coUVgxMUluZm86OmRpc3BsYXkoKSwgdy0+d2luSWQoKSwg
d2luSWQoKSwgMCwgMCk7CiAjZW5kaWYKICAgICB3LT5zZXRHZW9tZXRyeSggMCwgMCwgd2lkdGgo
KSwgaGVpZ2h0KCkgKTsKKyAgICBkID0gKEtTY3JlZW5TYXZlclByaXZhdGUgKil3OwogICAgIFFB
cHBsaWNhdGlvbjo6c2VuZFBvc3RlZEV2ZW50cygpOwogfQogCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32523</attachid>
            <date>2009-04-01 19:20:55 +0000</date>
            <delta_ts>2009-04-02 01:18:52 +0000</delta_ts>
            <desc>Fix, try 7 (hey, whatever happened to 5!?)</desc>
            <filename>kscreensaver_embed_fix_7.patch</filename>
            <type>text/plain</type>
            <size>1521</size>
            <attacher name="Ivo Anjo">ivo</attacher>
            
              <data encoding="base64">SW5kZXg6IGxpYmtzY3JlZW5zYXZlci9rc2NyZWVuc2F2ZXIuaAo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBsaWJr
c2NyZWVuc2F2ZXIva3NjcmVlbnNhdmVyLmgJKHJldmlzaW9uIDk0NzI3NykKKysrIGxpYmtzY3Jl
ZW5zYXZlci9rc2NyZWVuc2F2ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNjQsNyArNjQsOCBAQAog
ICAgIGJvb2wgZXZlbnQoIFFFdmVudCogZXZlbnQgKTsKIAogcHJpdmF0ZToKLSAgICBLU2NyZWVu
U2F2ZXJQcml2YXRlICpkOworICAgIC8vS1NjcmVlblNhdmVyUHJpdmF0ZSAqZDsKKyAgICBRV2lk
Z2V0ICpkOwogfTsKIAogLyoqCkluZGV4OiBsaWJrc2NyZWVuc2F2ZXIva3NjcmVlbnNhdmVyLmNw
cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBsaWJrc2NyZWVuc2F2ZXIva3NjcmVlbnNhdmVyLmNwcAkocmV2aXNp
b24gOTQ3Mjc3KQorKysgbGlia3NjcmVlbnNhdmVyL2tzY3JlZW5zYXZlci5jcHAJKHdvcmtpbmcg
Y29weSkKQEAgLTMzLDcgKzMzLDEwIEBACiAKIC8vLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAotS1Nj
cmVlblNhdmVyOjpLU2NyZWVuU2F2ZXIoIFdJZCBpZCApIDogUVdpZGdldCgpCisvL05vdGU6IFRo
ZSBkLXBvaW50ZXIgaXMgY3VycmVudGx5IGJlaW5nIChhYil1c2VkIHRvIGtlZXAgdGhlIGVtYmVk
ZGVkIGNoaWxkIHdpZGdldAorLy8gICAgICAgZG9uJ3QgZm9yZ2V0IHRvIGNvbnZlcnQgaXQgdG8g
YSBwcm9wZXIgbWVtYmVyIGlmIG5lZWRlZC4KKworS1NjcmVlblNhdmVyOjpLU2NyZWVuU2F2ZXIo
IFdJZCBpZCApIDogUVdpZGdldCgpLCBkKDApCiB7CiAgICAgaWYgKCBpZCApCiAgICAgewpAQCAt
NTEsMTYgKzU0LDIwIEBACiAgICAgYm9vbCByID0gUVdpZGdldDo6ZXZlbnQoZSk7CiAgICAgaWYg
KGUtPnR5cGUoKSA9PSBRRXZlbnQ6OlBvbGlzaCkKICAgICAgICAgc2V0QXR0cmlidXRlKFF0OjpX
QV9TdHlsZWRCYWNrZ3JvdW5kLCBmYWxzZSk7CisgICAgaWYgKChlLT50eXBlKCkgPT0gUUV2ZW50
OjpSZXNpemUpICYmIGQpCisgICAgICAgIGQtPnJlc2l6ZSggc2l6ZSgpICk7CiAgICAgcmV0dXJu
IHI7CiB9CiAKIHZvaWQgS1NjcmVlblNhdmVyOjplbWJlZCggUVdpZGdldCAqdyApCiB7CisgICAg
dy0+cmVzaXplKCBzaXplKCkgKTsKICAgICBRQXBwbGljYXRpb246OnNlbmRQb3N0ZWRFdmVudHMo
KTsKICNpZmRlZiBRX1dTX1gxMSAvL0ZJWE1FCiAgICAgWFJlcGFyZW50V2luZG93KFFYMTFJbmZv
OjpkaXNwbGF5KCksIHctPndpbklkKCksIHdpbklkKCksIDAsIDApOwogI2VuZGlmCiAgICAgdy0+
c2V0R2VvbWV0cnkoIDAsIDAsIHdpZHRoKCksIGhlaWdodCgpICk7CisgICAgZCA9IHc7CiAgICAg
UUFwcGxpY2F0aW9uOjpzZW5kUG9zdGVkRXZlbnRzKCk7CiB9CiAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32527</attachid>
            <date>2009-04-02 01:18:52 +0000</date>
            <delta_ts>2009-04-02 01:18:52 +0000</delta_ts>
            <desc>Fix, try 8</desc>
            <filename>kscreensaver_embed_fix_8.patch</filename>
            <type>text/plain</type>
            <size>1831</size>
            <attacher name="Ivo Anjo">ivo</attacher>
            
              <data encoding="base64">SW5kZXg6IHdvcmtzcGFjZS9rc2NyZWVuc2F2ZXIvbGlia3NjcmVlbnNhdmVyL2tzY3JlZW5zYXZl
ci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIHdvcmtzcGFjZS9rc2NyZWVuc2F2ZXIvbGlia3NjcmVlbnNhdmVy
L2tzY3JlZW5zYXZlci5oCShyZXZpc2lvbiA5NDcyNzcpCisrKyB3b3Jrc3BhY2Uva3NjcmVlbnNh
dmVyL2xpYmtzY3JlZW5zYXZlci9rc2NyZWVuc2F2ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNjQs
NyArNjQsMTEgQEAKICAgICBib29sIGV2ZW50KCBRRXZlbnQqIGV2ZW50ICk7CiAKIHByaXZhdGU6
Ci0gICAgS1NjcmVlblNhdmVyUHJpdmF0ZSAqZDsKKyAgICAvL05vdGU6IFRvIGtlZXAgYmluYXJ5
IGNvbXBhdGliaWxpdHkgdGhpcyBjbGFzcyBtdXN0IGhhdmUgb25seSBvbmUgbWVtYmVyLCB3aGlj
aCBpcyBhIHBvaW50ZXIuCisgICAgLy8gICAgICBJZiBtb3JlIG1lbWJlcnMgYXJlIG5lZWRlZCwg
dXNlIHRoZSBkLXBvaW50ZXIgdGVjaG5pcXVlLgorICAgIC8vICAgICAgU2VlIGh0dHA6Ly90ZWNo
YmFzZS5rZGUub3JnL1BvbGljaWVzL0JpbmFyeV9Db21wYXRpYmlsaXR5X0lzc3Vlc19XaXRoX0Ml
MkIlMkIKKyAgICAvL0tTY3JlZW5TYXZlclByaXZhdGUgKmQ7CisgICAgUVdpZGdldCAqZW1iZWRk
ZWRXaWRnZXQ7CiB9OwogCiAvKioKSW5kZXg6IHdvcmtzcGFjZS9rc2NyZWVuc2F2ZXIvbGlia3Nj
cmVlbnNhdmVyL2tzY3JlZW5zYXZlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gd29ya3NwYWNlL2tzY3Jl
ZW5zYXZlci9saWJrc2NyZWVuc2F2ZXIva3NjcmVlbnNhdmVyLmNwcAkocmV2aXNpb24gOTQ3Mjc3
KQorKysgd29ya3NwYWNlL2tzY3JlZW5zYXZlci9saWJrc2NyZWVuc2F2ZXIva3NjcmVlbnNhdmVy
LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzMsNyArMzMsNyBAQAogCiAvLy0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tCiAKLUtTY3JlZW5TYXZlcjo6S1NjcmVlblNhdmVyKCBXSWQgaWQgKSA6IFFXaWRnZXQo
KQorS1NjcmVlblNhdmVyOjpLU2NyZWVuU2F2ZXIoIFdJZCBpZCApIDogUVdpZGdldCgpLCBlbWJl
ZGRlZFdpZGdldCgwKQogewogICAgIGlmICggaWQgKQogICAgIHsKQEAgLTUxLDE2ICs1MSwyMCBA
QAogICAgIGJvb2wgciA9IFFXaWRnZXQ6OmV2ZW50KGUpOwogICAgIGlmIChlLT50eXBlKCkgPT0g
UUV2ZW50OjpQb2xpc2gpCiAgICAgICAgIHNldEF0dHJpYnV0ZShRdDo6V0FfU3R5bGVkQmFja2dy
b3VuZCwgZmFsc2UpOworICAgIGlmICgoZS0+dHlwZSgpID09IFFFdmVudDo6UmVzaXplKSAmJiBl
bWJlZGRlZFdpZGdldCkKKyAgICAgICAgZW1iZWRkZWRXaWRnZXQtPnJlc2l6ZSggc2l6ZSgpICk7
CiAgICAgcmV0dXJuIHI7CiB9CiAKIHZvaWQgS1NjcmVlblNhdmVyOjplbWJlZCggUVdpZGdldCAq
dyApCiB7CisgICAgdy0+cmVzaXplKCBzaXplKCkgKTsKICAgICBRQXBwbGljYXRpb246OnNlbmRQ
b3N0ZWRFdmVudHMoKTsKICNpZmRlZiBRX1dTX1gxMSAvL0ZJWE1FCiAgICAgWFJlcGFyZW50V2lu
ZG93KFFYMTFJbmZvOjpkaXNwbGF5KCksIHctPndpbklkKCksIHdpbklkKCksIDAsIDApOwogI2Vu
ZGlmCiAgICAgdy0+c2V0R2VvbWV0cnkoIDAsIDAsIHdpZHRoKCksIGhlaWdodCgpICk7CisgICAg
ZW1iZWRkZWRXaWRnZXQgPSB3OwogICAgIFFBcHBsaWNhdGlvbjo6c2VuZFBvc3RlZEV2ZW50cygp
OwogfQogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>