65553 2003-10-05 19:36:29 +0000 funny bug: dragging an attachment icon to desktop copies icon! 2004-04-23 19:08:49 +0000 1 1 2 Applications konqueror khtml event SVN unspecified Linux RESOLVED FIXED NOR grave --- 1 wbsoft konqueror-bugs-null d_baron gerard mi+kde oded siegmund 10 oldest_to_newest 164078 0 wbsoft 2003-10-05 19:36:29 +0000 Version: 1.5.9 (using KDE 3.1.92 (alpha2, CVS >= 20030921), compiled sources) Compiler: gcc version 3.2.1 OS: Linux (i686) release 2.4.22-ck2 I dragged a .po attachment to the desktop from KMail and selected Copy Here. It created a png file with the name gettext.png! I must drag the attachment file_name_, not the icon, to get the attachment copied to the desktop. 176377 1 kloecker 2003-11-14 10:09:49 +0000 *** Bug 68185 has been marked as a duplicate of this bug. *** 176401 2 kloecker 2003-11-14 11:15:07 +0000 That's a great new feature of KHTML. I don't think we (the KMail developers) can do anything about it. Reassigning to the guys who implemented this new feature without thinking about the consequences (or maybe they did but just forgot to tell us what we have to change). BTW, this isn't specific to .po files but applies to all attachments which are shown as icon in KMail. 181127 3 bastian 2003-11-28 14:46:56 +0000 Raising severity, blocking bug for 3.2, regression. Selecting the icon of KMail attachments drags the icon (the image that is shown) but not the attachment itself (the URL associated with the icon). 181128 4 staikos 2003-11-28 14:51:20 +0000 Subject: Re: funny bug: dragging an attachment icon to desktop copies icon! On Friday 28 November 2003 08:46, Waldo Bastian wrote: > Raising severity, blocking bug for 3.2, regression. > > Selecting the icon of KMail attachments drags the icon (the image that is > shown) but not the attachment itself (the URL associated with the icon). I've seen this too, and I think my report about it was closed. Are you using load-on-demand imap? 181139 5 wbsoft 2003-11-28 15:42:09 +0000 I didn't use IMAP (when I reported the bug), just local mail folders. 181927 6 kloecker 2003-12-01 14:44:56 +0000 *** Bug 69419 has been marked as a duplicate of this bug. *** 182490 7 kloecker 2003-12-03 10:22:52 +0000 *** Bug 69540 has been marked as a duplicate of this bug. *** 182777 8 j.e.drews 2003-12-04 06:01:34 +0000 Hello Ingo: No it happens no matter where I click on the attachment. I tried clicking on the text and clicking on the mime symbol. In both cases the result of the drag and drop is still "unknown.png". 183706 9 adam 2003-12-07 19:46:08 +0000 *** Bug 69540 has been marked as a duplicate of this bug. *** 202265 10 wbsoft 2004-02-06 11:22:27 +0000 Still there in KDE 3.2.0 When I drag the icon from KMail, I get a PNG image. When I drag the filename, I get the attachment. I think this is a very severe bug. Think of a user who drags an attachment to his/her desktop, thinks it's OK, and then deletes the message and closes KMail, only to discover that the nice looking icon (which looks the same if previews are turned on!) is only a little PNG file, and that the original attachment is lost! 202606 11 j.e.drews 2004-02-07 01:37:19 +0000 > That's a great new feature of KHTML. I don't think we (the KMail developers) can > do anything about it. The KHTML changes are a great new feature but they break things? THEN WHY THE HELL DID YOU SHIP IT! 214323 12 maksim 2004-03-11 16:51:13 +0000 *** Bug 77275 has been marked as a duplicate of this bug. *** 215419 13 Michael.Brug 2004-03-14 18:10:12 +0000 In KDE 3.2.1 I can drag the icon and get an (unwanted) png image on the desktop. I cannot drag the filename anymore to the desktop (worked in 3.2). The behavior is the same, when I try to drag an attachment to a new message. So unless I missed something the functionality is completely broken now. 215469 14 wbsoft 2004-03-14 20:47:24 +0000 This is caused by this KHTML bug #71162, which really needs fixing, because the behaviour of dragging the image, while the link the image links to should be dragged/pasted. 216392 15 adawit 2004-03-16 23:36:26 +0000 Hi, The attached patch is intended to address the regression with dragging links and images as described in these reports. Please test... Created an attachment (id=5247) patch-71162.diff 216437 16 d_baron 2004-03-17 08:14:40 +0000 I am not working from source but installed from SID. On Tuesday 16 March 2004 23:36, Dawit Alemayehu wrote: > ------- You are receiving this mail because: ------- > You are on the CC list for the bug, or are watching someone who is. > > http://bugs.kde.org/show_bug.cgi?id=65553 > > > > > ------- Additional Comments From adawit kde org 2004-03-16 23:36 ------- > Hi, > > The attached patch is intended to address the regression with dragging > links and images as described in these reports. Please test... > > > > Created an attachment (id=5247) > --> (http://bugs.kde.org/attachment.cgi?id=5247&action=view) > patch-71162.diff 216494 17 adawit 2004-03-17 14:17:35 +0000 CVS commit by adawit: Backport: - Regression fix for BR# 71162 & BR# 65553. - Set the suggested filename if available when prompting user to save files. CCMAIL: 71162-done@bugs.kde.org CCMAIL: 65553-done@bugs.kde.org M +19 -17 khtml_part.cpp 1.959.2.9 --- kdelibs/khtml/khtml_part.cpp #1.959.2.8:1.959.2.9 @@ -3777,9 +3777,13 @@ bool KHTMLPart::processObjectRequest( kh if ( child->m_type != khtml::ChildFrame::Object ) { + QString suggestedFilename; + if ( child->m_run ) + suggestedFilename = child->m_run->suggestedFilename(); + KParts::BrowserRun::AskSaveResult res = KParts::BrowserRun::askEmbedOrSave( - url, mimetype/*, suggestedFilename */ ); + url, mimetype, suggestedFilename ); switch( res ) { case KParts::BrowserRun::Save: - KHTMLPopupGUIClient::saveURL( widget(), i18n( "Save As" ), url, child->m_args.metaData(), QString::null, 0 /*, suggestedFilename */ ); + KHTMLPopupGUIClient::saveURL( widget(), i18n( "Save As" ), url, child->m_args.metaData(), QString::null, 0, suggestedFilename); // fall-through case KParts::BrowserRun::Cancel: @@ -5364,4 +5368,9 @@ void KHTMLPart::khtmlMouseMoveEvent( kht d->m_bRightMousePressed = false; } + + DOM::DOMString url = event->url(); + DOM::DOMString target = event->target(); + DOM::Node innerNode = event->innerNode(); + #ifndef QT_NO_DRAGANDDROP if( d->m_bDnd && d->m_bMousePressed && @@ -5375,21 +5384,18 @@ void KHTMLPart::khtmlMouseMoveEvent( kht QDragObject *drag = 0; KURL u; - if ( d->m_mousePressNode.handle() && d->m_mousePressNode.handle()->id() == ID_IMG ) + + // qDebug("****************** Event URL: %s", url.string().latin1()); + // qDebug("****************** Event Target: %s", target.string().latin1()); + + // Normal image... + if ( url.length() == 0 && innerNode.handle() && innerNode.handle()->id() == ID_IMG ) { - // Normal image - img = static_cast<HTMLImageElementImpl *>(d->m_mousePressNode.handle()); + img = static_cast<HTMLImageElementImpl *>(innerNode.handle()); u = KURL( completeURL( khtml::parseURL(img->getAttribute(ATTR_SRC)).string() ) ); pix = KMimeType::mimeType("image/png")->pixmap(KIcon::Desktop); } - else if ( event->innerNode().handle() && event->innerNode().handle()->id() == ID_IMG ) - { - // Image inside a link? - img = static_cast<HTMLImageElementImpl *>(event->innerNode().handle()); - u = completeURL( d->m_strSelectedURL ); - pix = KMimeType::mimeType("image/png")->pixmap(KIcon::Desktop); - } else { - // Text link + // Text or image link... u = completeURL( d->m_strSelectedURL ); pix = KMimeType::pixmapForURL(u, 0, KIcon::Desktop, KIcon::SizeMedium); @@ -5423,8 +5429,4 @@ void KHTMLPart::khtmlMouseMoveEvent( kht #endif - DOM::DOMString url = event->url(); - DOM::DOMString target = event->target(); - DOM::Node innerNode = event->innerNode(); - // Not clicked -> mouse over stuff if ( !d->m_bMousePressed ) 226102 18 maksim 2004-04-23 19:08:49 +0000 *** Bug 80216 has been marked as a duplicate of this bug. *** 5247 2004-03-16 23:36:26 +0000 2004-03-16 23:36:26 +0000 patch-71162.diff patch-71162.diff text/x-diff 2430 adawit SW5kZXg6IGtodG1sX3BhcnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9ob21lL2tkZS9rZGVs aWJzL2todG1sL2todG1sX3BhcnQuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjk3OApkaWZm IC11IC0zIC1wIC1yMS45Nzgga2h0bWxfcGFydC5jcHAKLS0tIGtodG1sX3BhcnQuY3BwCTggTWFy IDIwMDQgMTQ6NDI6MTcgLTAwMDAJMS45NzgKKysrIGtodG1sX3BhcnQuY3BwCTE2IE1hciAyMDA0 IDIyOjIxOjU2IC0wMDAwCkBAIC01MzYzLDYgKzUzNjcsMTEgQEAgdm9pZCBLSFRNTFBhcnQ6Omto dG1sTW91c2VNb3ZlRXZlbnQoIGtodAogICAgIGQtPm1fc3RyU2VsZWN0ZWRVUkwgPSBkLT5tX3N0 clNlbGVjdGVkVVJMVGFyZ2V0ID0gUVN0cmluZzo6bnVsbDsKICAgICBkLT5tX2JSaWdodE1vdXNl UHJlc3NlZCA9IGZhbHNlOwogICB9CisKKyAgRE9NOjpET01TdHJpbmcgdXJsID0gZXZlbnQtPnVy bCgpOworICBET006OkRPTVN0cmluZyB0YXJnZXQgPSBldmVudC0+dGFyZ2V0KCk7CisgIERPTTo6 Tm9kZSBpbm5lck5vZGUgPSBldmVudC0+aW5uZXJOb2RlKCk7CisgIAogI2lmbmRlZiBRVF9OT19E UkFHQU5ERFJPUAogICBpZiggZC0+bV9iRG5kICYmIGQtPm1fYk1vdXNlUHJlc3NlZCAmJgogICAg ICAgKCAoIWQtPm1fc3RyU2VsZWN0ZWRVUkwuaXNFbXB0eSgpICYmICFpc0VkaXRhYmxlKCkpCkBA IC01Mzc0LDIzICs1MzgzLDIwIEBAIHZvaWQgS0hUTUxQYXJ0OjpraHRtbE1vdXNlTW92ZUV2ZW50 KCBraHQKICAgICBIVE1MSW1hZ2VFbGVtZW50SW1wbCAqaW1nID0gMEw7CiAgICAgUURyYWdPYmpl Y3QgKmRyYWcgPSAwOwogICAgIEtVUkwgdTsKLSAgICBpZiAoIGQtPm1fbW91c2VQcmVzc05vZGUu aGFuZGxlKCkgJiYgZC0+bV9tb3VzZVByZXNzTm9kZS5oYW5kbGUoKS0+aWQoKSA9PSBJRF9JTUcg KQotICAgIHsKLSAgICAgIC8vIE5vcm1hbCBpbWFnZQotICAgICAgaW1nID0gc3RhdGljX2Nhc3Q8 SFRNTEltYWdlRWxlbWVudEltcGwgKj4oZC0+bV9tb3VzZVByZXNzTm9kZS5oYW5kbGUoKSk7Cisg ICAgCisgICAgLy8gcURlYnVnKCIqKioqKioqKioqKioqKioqKiogRXZlbnQgVVJMOiAlcyIsIHVy bC5zdHJpbmcoKS5sYXRpbjEoKSk7CisgICAgLy8gcURlYnVnKCIqKioqKioqKioqKioqKioqKiog RXZlbnQgVGFyZ2V0OiAlcyIsIHRhcmdldC5zdHJpbmcoKS5sYXRpbjEoKSk7CisgICAgCisgICAg Ly8gTm9ybWFsIGltYWdlLi4uCisgICAgaWYgKCB1cmwubGVuZ3RoKCkgPT0gMCAmJiBpbm5lck5v ZGUuaGFuZGxlKCkgJiYgaW5uZXJOb2RlLmhhbmRsZSgpLT5pZCgpID09IElEX0lNRyApCisgICAg eyAgICAgIAorICAgICAgaW1nID0gc3RhdGljX2Nhc3Q8SFRNTEltYWdlRWxlbWVudEltcGwgKj4o aW5uZXJOb2RlLmhhbmRsZSgpKTsKICAgICAgIHUgPSBLVVJMKCBjb21wbGV0ZVVSTCgga2h0bWw6 OnBhcnNlVVJMKGltZy0+Z2V0QXR0cmlidXRlKEFUVFJfU1JDKSkuc3RyaW5nKCkgKSApOwogICAg ICAgcGl4ID0gS01pbWVUeXBlOjptaW1lVHlwZSgiaW1hZ2UvcG5nIiktPnBpeG1hcChLSWNvbjo6 RGVza3RvcCk7CiAgICAgfQotICAgIGVsc2UgaWYgKCBldmVudC0+aW5uZXJOb2RlKCkuaGFuZGxl KCkgJiYgZXZlbnQtPmlubmVyTm9kZSgpLmhhbmRsZSgpLT5pZCgpID09IElEX0lNRyApCi0gICAg ewotICAgICAgLy8gSW1hZ2UgaW5zaWRlIGEgbGluaz8KLSAgICAgIGltZyA9IHN0YXRpY19jYXN0 PEhUTUxJbWFnZUVsZW1lbnRJbXBsICo+KGV2ZW50LT5pbm5lck5vZGUoKS5oYW5kbGUoKSk7Ci0g ICAgICB1ID0gY29tcGxldGVVUkwoIGQtPm1fc3RyU2VsZWN0ZWRVUkwgKTsKLSAgICAgIHBpeCA9 IEtNaW1lVHlwZTo6bWltZVR5cGUoImltYWdlL3BuZyIpLT5waXhtYXAoS0ljb246OkRlc2t0b3Ap OwotICAgIH0KICAgICBlbHNlCiAgICAgewotICAgICAgLy8gVGV4dCBsaW5rCisgICAgICAvLyBU ZXh0IG9yIGltYWdlIGxpbmsuLi4KICAgICAgIHUgPSBjb21wbGV0ZVVSTCggZC0+bV9zdHJTZWxl Y3RlZFVSTCApOwogICAgICAgcGl4ID0gS01pbWVUeXBlOjpwaXhtYXBGb3JVUkwodSwgMCwgS0lj b246OkRlc2t0b3AsIEtJY29uOjpTaXplTWVkaXVtKTsKICAgICB9CkBAIC01NDIyLDEwICs1NDI4 LDYgQEAgdm9pZCBLSFRNTFBhcnQ6OmtodG1sTW91c2VNb3ZlRXZlbnQoIGtodAogICB9CiAjZW5k aWYKIAotICBET006OkRPTVN0cmluZyB1cmwgPSBldmVudC0+dXJsKCk7Ci0gIERPTTo6RE9NU3Ry aW5nIHRhcmdldCA9IGV2ZW50LT50YXJnZXQoKTsKLSAgRE9NOjpOb2RlIGlubmVyTm9kZSA9IGV2 ZW50LT5pbm5lck5vZGUoKTsKLQogICAvLyBOb3QgY2xpY2tlZCAtPiBtb3VzZSBvdmVyIHN0dWZm CiAgIGlmICggIWQtPm1fYk1vdXNlUHJlc3NlZCApCiAgIHsK