<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>59080</bug_id>
          
          <creation_ts>2003-05-28 12:39:34 +0000</creation_ts>
          <short_desc>[PATCH] Kopete does not keep toolbar settings</short_desc>
          <delta_ts>2008-05-31 18:48:23 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>10</classification_id>
          <classification>Unmaintained</classification>
          <product>kopete</product>
          <component>Chat Window</component>
          <version>unspecified</version>
          <rep_platform>Debian testing</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ralph Jenkin">ralphjenkin</reporter>
          <assigned_to name="Kopete Developers">kopete-bugs-null</assigned_to>
          <cc>aliakc</cc>
    
    <cc>b.buschinski</cc>
    
    <cc>brad</cc>
    
    <cc>chaosgeisterchen</cc>
    
    <cc>des</cc>
    
    <cc>epyon9283</cc>
    
    <cc>hisham</cc>
    
    <cc>ismail</cc>
    
    <cc>jason</cc>
    
    <cc>jes</cc>
    
    <cc>jorgp</cc>
    
    <cc>lopezibanez</cc>
    
    <cc>mcepl</cc>
    
    <cc>swalko12</cc>
    
    <cc>tenco</cc>
          
          <cf_commitlink></cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>41</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>136431</commentid>
    <comment_count>0</comment_count>
    <who name="Ralph Jenkin">ralphjenkin</who>
    <bug_when>2003-05-28 12:39:35 +0000</bug_when>
    <thetext>Version:           0.6.90cvs &gt;= 20030426 (Using KDE 3.1.2) (using KDE KDE 3.1.2)
Installed from:    Debian testing/unstable Packages
Compiler:          (Packages from http://kopete.creativa.cl/debian/sid/cvs) 
OS:          Linux

When I open a new chat, the Format Toolbar is always enabled, and when I disable it it goes away. However, when I open a new chat after closing the first, the Format Toolbar is back. A similar problem occurs when trying to change the icon size on the Format Toolbar, i.e. the change occurs correctly during a given chat, and reverts to the default when opening a new chat.

The problem is worse when using tabs: opening a new chat in a new tab after disabling the Format Toolbar instantly re-enables the Toolbar. In the new tab, the toolbar is marked as enabled, but switching back to the old tab, the toolbar is marked as disabled, even though it is visible. Any further attempts to disable or enable the toolbar at that point results only in the toggling of the tick, the toolbar doggedly remains put.

Now, this is not really an earth shatteringly serious bug or anything, and the short term solution is obvious: live with the damn format toolbar. However, I really never use the thing, and it bugs me everytime I try to disable it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>138200</commentid>
    <comment_count>1</comment_count>
    <who name="Olivier Goffart">ogoffart</who>
    <bug_when>2003-06-07 10:54:38 +0000</bug_when>
    <thetext>Yes, this RichTextEditor component is not so great in the current state of kopete. 
it needs more works </thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>143138</commentid>
    <comment_count>2</comment_count>
    <who name="Olivier Goffart">ogoffart</who>
    <bug_when>2003-06-30 19:25:48 +0000</bug_when>
    <thetext>as the rich text editor is now optional, i close this bug. (because you can remove it if 
you don&apos;t need it) </thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>238382</commentid>
    <comment_count>3</comment_count>
    <who name="Alexandre Pereira">pereira.alex</who>
    <bug_when>2004-06-02 12:34:15 +0000</bug_when>
    <thetext>reopening , because its happening again in latest cvs code</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>238384</commentid>
    <comment_count>4</comment_count>
    <who name="Alexandre Pereira">pereira.alex</who>
    <bug_when>2004-06-02 12:38:24 +0000</bug_when>
    <thetext>reopening , i mean -&gt; reopen , please :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>238388</commentid>
    <comment_count>5</comment_count>
    <who name="Till Gerken">till.gerken</who>
    <bug_when>2004-06-02 12:55:26 +0000</bug_when>
    <thetext>Bug reappeared.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>246354</commentid>
    <comment_count>6</comment_count>
    <who name="Matt Rogers">mattr</who>
    <bug_when>2004-07-06 23:32:26 +0000</bug_when>
    <thetext>*** Bug 84382 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>247921</commentid>
    <comment_count>7</comment_count>
    <who name="christian">ch75</who>
    <bug_when>2004-07-12 00:49:22 +0000</bug_when>
    <thetext>hello i just wanted to file this bug too, recent cvs (12.07.2004) here is a picture of the problem : http://www.kha.uni-karlsruhe.de/tmp/bug.png.

this toolbar always re-appears.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>248971</commentid>
    <comment_count>8</comment_count>
    <who name="Philipp Eberle">EBERLEPH</who>
    <bug_when>2004-07-15 11:54:25 +0000</bug_when>
    <thetext>same for me: i can disable the format toolbar, but it reappears when i open a new chat-window. i am using kopete from kde 3.3 beta1 (kopete 0.8.91, CVS &gt;= 2004 06 26), using the gentoo linux ebuilds in portage.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>251146</commentid>
    <comment_count>9</comment_count>
    <who name="Christopher J. Bottaro">cjbottaro</who>
    <bug_when>2004-07-21 18:48:09 +0000</bug_when>
    <thetext>i have this problem also in kde-3.3-beta1.  opening a new tab, closing then reopening a chat window, restarting kopete will all result in the format toolbar reappearing.  also, all my format options (and thus the format toolbar) are greyed out (i.e. unavailable).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>251150</commentid>
    <comment_count>10</comment_count>
    <who name="Till Gerken">till.gerken</who>
    <bug_when>2004-07-21 19:01:57 +0000</bug_when>
    <thetext>Formatting is only available for protocols supporting RTF.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>253594</commentid>
    <comment_count>11</comment_count>
    <who name="Jason Ahrens">jason</who>
    <bug_when>2004-07-27 20:15:48 +0000</bug_when>
    <thetext>The issue with the Kopete Format Bar always being active when the chat window opens (regardless that I turn it off every time) is also present in KDE 3.3.0 beta 2.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>254180</commentid>
    <comment_count>12</comment_count>
    <who name="Richard Smith">kde</who>
    <bug_when>2004-07-29 17:13:53 +0000</bug_when>
    <thetext>As a temporary workaround, you can comment out (add // to the start of) this 
line (around line 216) of kopete/chatwindow/chatview.cpp:

connect( this, SIGNAL( windowCreated()), editpart, 
SLOT(checkToolbarEnabled()) );

Then recompile and reinstall. The format toolbar will then not ever 
automatically appear. Those of you who use pre-compiled packages will have to 
wait for us to fix it, I&apos;m afraid.

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>254601</commentid>
    <comment_count>13</comment_count>
    <who name="Richard Smith">kde</who>
    <bug_when>2004-07-31 00:58:32 +0000</bug_when>
    <thetext>When we do fix this, can someone tell the KMail people how? They have the same bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>259727</commentid>
    <comment_count>14</comment_count>
    <who name="robert lindgren">r</who>
    <bug_when>2004-08-18 09:00:13 +0000</bug_when>
    <thetext>This still is present in 3.3.0 final, kopete 0.9.0. pitty.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>260444</commentid>
    <comment_count>15</comment_count>
    <who name="Matt Rogers">mattr</who>
    <bug_when>2004-08-20 16:11:17 +0000</bug_when>
    <thetext>*** Bug 86907 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>260446</commentid>
    <comment_count>16</comment_count>
    <who name="Matt Rogers">mattr</who>
    <bug_when>2004-08-20 16:12:31 +0000</bug_when>
    <thetext>*** Bug 87602 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>264781</commentid>
    <comment_count>17</comment_count>
    <who name="jos poortvliet">jospoortvliet</who>
    <bug_when>2004-09-01 11:08:39 +0000</bug_when>
    <thetext>its very annoying, hope it can get fixed in kde 3.3.1??? please?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267343</commentid>
    <comment_count>18</comment_count>
    <who name="Matt Rogers">mattr</who>
    <bug_when>2004-09-10 05:50:14 +0000</bug_when>
    <thetext>CVS commit by mattr: 

Fix the reappearing format toolbar.

CCMAIL: 59080-done@bugs.kde.org


  M +1 -1      kopetechatwindow.cpp   1.88


--- kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp  #1.87:1.88
@@ -852,5 +852,5 @@ void KopeteChatWindow::setActiveView( QW
         guiFactory()-&gt;addClient(view-&gt;msgManager());
         createGUI( view-&gt;part() );
-
+        readOptions();
         if( m_activeView )
                 m_activeView-&gt;setActive( false );


</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267344</commentid>
    <comment_count>19</comment_count>
    <who name="Matt Rogers">mattr</who>
    <bug_when>2004-09-10 05:51:19 +0000</bug_when>
    <thetext>CVS commit by mattr: 

Backport the reappearing format toolbar fix.

This will be in KDE 3.3.1

CCMAIL: 59080@bugs.kde.org


  M +1 -1      kopetechatwindow.cpp   1.82.2.2


--- kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp  #1.82.2.1:1.82.2.2
@@ -847,5 +847,5 @@ void KopeteChatWindow::setActiveView( QW
         guiFactory()-&gt;addClient(view-&gt;msgManager());
         createGUI( view-&gt;part() );
-
+        readOptions();
         if( m_activeView )
                 m_activeView-&gt;setActive( false );


</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267457</commentid>
    <comment_count>20</comment_count>
    <who name="jos poortvliet">jospoortvliet</who>
    <bug_when>2004-09-10 15:38:09 +0000</bug_when>
    <thetext>thanx

great work</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267462</commentid>
    <comment_count>21</comment_count>
    <who name="Alexandre Pereira">pereira.alex</who>
    <bug_when>2004-09-10 15:44:40 +0000</bug_when>
    <thetext>this doesnt fix the format toolbar setting , does it ?

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>271172</commentid>
    <comment_count>22</comment_count>
    <who name="Barak Neeman">barak_neeman</who>
    <bug_when>2004-09-23 18:22:13 +0000</bug_when>
    <thetext>Matt&apos;s patch makes chat window &quot;remember&quot; the on/off state of the three toolbars (main, status and format) in the chatwindow. The state also gets saved for the next time you run kopete.

In another bug report people asked for saving of individual toolbar settings for each chat window (per chat-buddy), but it looks like that would take a lot more work.

I&apos;m just happy that i don&apos;t have to see that annoying format toolbar anymore :)

thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>277166</commentid>
    <comment_count>23</comment_count>
    <who name="P. Varet">p.varet</who>
    <bug_when>2004-10-17 15:20:58 +0000</bug_when>
    <thetext>As of KDE 3.3.1, this bug still exists, albeit in a slightly different form:
1) Disable the toolbar;
2) Switch tabs;
3) BUG: the toolbar reappears.

Additionally, Matt&apos;s patch seems to have caused bug #89911.

Shall we reopen this until it&apos;s fixed for good? It doesn&apos;t seem like a very big bug: when switching tabs, the last active tab should save its settings immediately BEFORE the switch. Should Work(tm).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>277179</commentid>
    <comment_count>24</comment_count>
    <who name="Richard Smith">kde</who>
    <bug_when>2004-10-17 16:17:16 +0000</bug_when>
    <thetext>On Sunday 17 October 2004 14:20, Sundance wrote:
&gt; Shall we reopen this until it&apos;s fixed for good?

No, #89911 is enough.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>278035</commentid>
    <comment_count>25</comment_count>
    <who name="Richard Smith">kde</who>
    <bug_when>2004-10-20 02:53:30 +0000</bug_when>
    <thetext>CVS commit by lilachaze: 

Apply a different fix to bug #59080 which doesn&apos;t cause bug #89911.

Basically, this is a revert of Jason&apos;s commit of 28/05/04 which appears to
be bogus; dynamically adding/removing a toolbar is not fundamentally
different to adding/removing toolbar buttons or menu items -- we should not
do it. Plus the existing fix for bug #59080 disabled this behaviour anyway.

CCBUG: 59080
CCBUG: 89911
CCMAIL: matt@matt.rogers.name


  M +0 -1      chatview.cpp   1.171
  M +1 -1      kopetechatwindow.cpp   1.92


--- kdenetwork/kopete/kopete/chatwindow/chatview.cpp  #1.170:1.171
@@ -230,5 +230,4 @@ ChatView::ChatView( Kopete::MessageManag
                 mgr-&gt;protocol()-&gt;capabilities() );
         connect( editpart, SIGNAL( toggleToolbar(bool)), this, SLOT(slotToggleRtfToolbar(bool)) );
-        connect( this, SIGNAL( windowCreated()), editpart, SLOT(checkToolbarEnabled()) );
 
         m_edit = static_cast&lt;KTextEdit*&gt;( editpart-&gt;widget() );

--- kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp  #1.91:1.92
@@ -852,5 +852,5 @@ void KopeteChatWindow::setActiveView( QW
         guiFactory()-&gt;addClient(view-&gt;msgManager());
         createGUI( view-&gt;part() );
-        readOptions();
+        
         if( m_activeView )
                 m_activeView-&gt;setActive( false );


</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>278037</commentid>
    <comment_count>26</comment_count>
    <who name="Matt Rogers">mattr</who>
    <bug_when>2004-10-20 03:01:28 +0000</bug_when>
    <thetext>CVS commit by mattr: 

Backport the fixes for 59080 and 89911. Should be in KDE 3.3.2
BUG: 89911
CCBUG: 59080


  M +0 -1      chatview.cpp   1.155.2.2
  M +1 -1      kopetechatwindow.cpp   1.82.2.3


--- kdenetwork/kopete/kopete/chatwindow/chatview.cpp  #1.155.2.1:1.155.2.2
@@ -217,5 +217,4 @@ ChatView::ChatView( KopeteMessageManager
                 mgr-&gt;protocol()-&gt;richTextCapabilities() );
         connect( editpart, SIGNAL( toggleToolbar(bool)), this, SLOT(slotToggleRtfToolbar(bool)) );
-        connect( this, SIGNAL( windowCreated()), editpart, SLOT(checkToolbarEnabled()) );
 
         m_edit = static_cast&lt;KTextEdit*&gt;( editpart-&gt;widget() );

--- kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp  #1.82.2.2:1.82.2.3
@@ -847,5 +847,5 @@ void KopeteChatWindow::setActiveView( QW
         guiFactory()-&gt;addClient(view-&gt;msgManager());
         createGUI( view-&gt;part() );
-        readOptions();
+        
         if( m_activeView )
                 m_activeView-&gt;setActive( false );


</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>476469</commentid>
    <comment_count>27</comment_count>
    <who name="Brett Miller">kdebugs</who>
    <bug_when>2006-10-13 01:24:59 +0000</bug_when>
    <thetext>I am having this same problem with version 0.12.2 (KDE 3.5.2), the only difference being when using tabs. After marking the format tool bar as enabed and switching tabs in the new tab the tool bar is visable and marked as enabled. After switching back to the original tab the tool bar is now visable again and is marked as enabled, where as in the original bug it was still marked as disabled.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>485596</commentid>
    <comment_count>28</comment_count>
    <who name="Benjamin Dietrich">bugs</who>
    <bug_when>2006-11-10 01:22:08 +0000</bug_when>
    <thetext>I have the problem in 3.5.5 with kopete 0.12.3 on my jabber account... when i have a icq/msn chatwindow/tab open, everything works fine... its just jabber + format-toolbar -_-</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>509203</commentid>
    <comment_count>29</comment_count>
    <who name="Paul Thomas">thomaspu</who>
    <bug_when>2007-02-14 17:50:23 +0000</bug_when>
    <thetext>I have this same problem with Kopete 0.12.4. The formatting toolbar does not keep its setting to stay hidden. This just annoys me. I couldn&apos;t find the spot to re-open this bug or I would.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>509251</commentid>
    <comment_count>30</comment_count>
    <who name="Philip Rodrigues">phil</who>
    <bug_when>2007-02-14 21:31:13 +0000</bug_when>
    <thetext>Reopening due to feedback in the last few comments</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>524223</commentid>
    <comment_count>31</comment_count>
    <who name="Josh Berry">des</who>
    <bug_when>2007-05-05 19:45:20 +0000</bug_when>
    <thetext>Also seeing the problem in Kopete 0.12.4 (KDE 3.5.6).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>524895</commentid>
    <comment_count>32</comment_count>
      <attachid>20518</attachid>
    <who name="Josh Berry">des</who>
    <bug_when>2007-05-08 22:55:22 +0000</bug_when>
    <thetext>Created attachment 20518
kopete-format-toolbar.patch

This has been driving me absolutely batty for a long time, so I wrote a patch
against the 3.5 branch (attached).

KMainWindow&apos;s standard way of tracking toolbar visibility doesn&apos;t work for the
format toolbar.  This is because the format toolbar is automatically
shown/hidden based on whether or not the protocol(I think?) supports rich text.
 So it would be automatically shown every time the user opened a chat window
using such a protocol.

The solution is to keep a separate, special config option based not on whether
the toolbar is actually visible or not, but on the *last specific show/hide
request* the user made.  (Then, of course, only show the toolbar if the user
requested it.)	This preserves the toolbar visibility even when it is
automatically shown/hidden due to RTFness.

It has to be a separate option because otherwise there is no way to know if the
toolbar was hidden because the user requested it, or because the protocol
doesn&apos;t support rich text.

I preserved the existing default of &quot;show the toolbar if it&apos;s supported&quot;.

Please review and commit if it&apos;s OK.  Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>530668</commentid>
    <comment_count>33</comment_count>
    <who name="Matt Rogers">mattr</who>
    <bug_when>2007-06-09 03:51:43 +0000</bug_when>
    <thetext>SVN commit 673118 by mattr:

Commit patch by Josh Berry to fix bug 59080.
Thanks for the patch!

BUG: 59080



 M  +17 -1     kopetechatwindow.cpp  
 M  +3 -0      kopetechatwindow.h  


--- branches/KDE/3.5/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.cpp #673117:673118
@@ -216,6 +216,8 @@
 
 	KGlobal::config()-&gt;setGroup( QString::fromLatin1(&quot;ChatWindowSettings&quot;) );
 	m_alwaysShowTabs = KGlobal::config()-&gt;readBoolEntry( QString::fromLatin1(&quot;AlwaysShowTabs&quot;), false );
+	m_showFormatToolbar = KGlobal::config()-&gt;readBoolEntry( QString::fromLatin1(&quot;Show Format Toolbar&quot;), true );
+	adjustingFormatToolbar = false;
 //	kdDebug( 14010 ) &lt;&lt; k_funcinfo &lt;&lt; &quot;Open Windows: &quot; &lt;&lt; windows.count() &lt;&lt; endl;
 	kapp-&gt;ref();
 }
@@ -418,6 +420,9 @@
 
 	setXMLFile( QString::fromLatin1( &quot;kopetechatwindow.rc&quot; ) );
 	createGUI( 0L );
+
+	// Special handling for remembering whether the format toolbar is visible or not
+	connect ( toolBar(&quot;formatToolBar&quot;), SIGNAL(visibilityChanged(bool)), this, SLOT(slotToggleFormatToolbar(bool)) );
 }
 
 const QString KopeteChatWindow::fileContents( const QString &amp;path ) const
@@ -1029,6 +1034,7 @@
 	KConfig *config = KGlobal::config();
 	applyMainWindowSettings( config, QString::fromLatin1( &quot;KopeteChatWindow&quot; ) );
 	config-&gt;setGroup( QString::fromLatin1(&quot;ChatWindowSettings&quot;) );
+	m_showFormatToolbar = config-&gt;readBoolEntry( QString::fromLatin1(&quot;Show Format Toolbar&quot;), true );
 }
 
 void KopeteChatWindow::saveOptions()
@@ -1043,6 +1049,7 @@
 	if( m_tabBar )
 		config-&gt;writeEntry ( QString::fromLatin1(&quot;Tab Placement&quot;), m_tabBar-&gt;tabPosition() );
 
+	config-&gt;writeEntry( QString::fromLatin1(&quot;Show Format Toolbar&quot;), m_showFormatToolbar );
 	config-&gt;sync();
 }
 
@@ -1072,6 +1079,13 @@
 		statusBar()-&gt;show();
 }
 
+void KopeteChatWindow::slotToggleFormatToolbar(bool visible)
+{
+	if ( adjustingFormatToolbar )
+		return;
+	m_showFormatToolbar = visible;
+}
+
 void KopeteChatWindow::slotViewMenuBar()
 {
 	if( !menuBar()-&gt;isHidden() )
@@ -1092,10 +1106,12 @@
 	if ( cv != m_activeView )
 		return;
 
-	if ( enabled )
+	adjustingFormatToolbar = true;
+	if ( enabled &amp;&amp; m_showFormatToolbar )
 		toolBar( &quot;formatToolBar&quot; )-&gt;show();
 	else
 		toolBar( &quot;formatToolBar&quot; )-&gt;hide();
+	adjustingFormatToolbar = false;
 	updateSpellCheckAction();
 }
 
--- branches/KDE/3.5/kdenetwork/kopete/kopete/chatwindow/kopetechatwindow.h #673117:673118
@@ -127,6 +127,8 @@
 	ChatView *m_activeView;
 	ChatView *m_popupView;
 	bool m_alwaysShowTabs;
+	bool m_showFormatToolbar;
+	bool adjustingFormatToolbar;
 	bool updateBg;
 	KTabWidget *m_tabBar;
 	KPushButton *m_button_send;
@@ -200,6 +202,7 @@
 
 	void slotViewMenuBar();
 	void slotToggleStatusBar();
+	void slotToggleFormatToolbar( bool );
 
 	void slotConfKeys();
 	void slotConfToolbar();
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>530697</commentid>
    <comment_count>34</comment_count>
    <who name="Matt Rogers">mattr</who>
    <bug_when>2007-06-09 07:20:44 +0000</bug_when>
    <thetext>*** Bug 127176 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>540405</commentid>
    <comment_count>35</comment_count>
    <who name="Jan Ritzerfeld">kde</who>
    <bug_when>2007-08-10 20:02:29 +0000</bug_when>
    <thetext>*** Bug 148712 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>564240</commentid>
    <comment_count>36</comment_count>
    <who name="Martin Ammermüller">tenco</who>
    <bug_when>2007-12-17 22:58:52 +0000</bug_when>
    <thetext>Same problem here using kopete version 0.40.3, KDE 3.97.1, SVN checkout today. Format Toolbar status not saved for jabber chat/single message windows.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>584017</commentid>
    <comment_count>37</comment_count>
    <who name="Josh Berry">des</who>
    <bug_when>2008-03-02 23:44:56 +0000</bug_when>
    <thetext>I can confirm this bug has regressed.  Please reopen.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>601198</commentid>
    <comment_count>38</comment_count>
    <who name="Dennis Nienhüser">nienhueser</who>
    <bug_when>2008-05-14 14:54:07 +0000</bug_when>
    <thetext>Reopening, still (or again, probably related to porting to QT 4) present in SVN trunk.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>601201</commentid>
    <comment_count>39</comment_count>
    <who name="Dennis Nienhüser">nienhueser</who>
    <bug_when>2008-05-14 14:55:01 +0000</bug_when>
    <thetext>*** Bug 157499 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>601205</commentid>
    <comment_count>40</comment_count>
    <who name="Manuel López-Ibáñez">lopezibanez</who>
    <bug_when>2008-05-14 15:00:17 +0000</bug_when>
    <thetext>I have this bug in kopete 0.12.4. Not sure which one is the latest version in KDE 3.5.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>601208</commentid>
    <comment_count>41</comment_count>
    <who name="Manuel López-Ibáñez">lopezibanez</who>
    <bug_when>2008-05-14 15:11:15 +0000</bug_when>
    <thetext>In addition, the toolbar settings doesn&apos;t make any sense. First, there seems to be only 3 toolbars in Settings-&gt;Toolbars: &quot;Main Toolbar&quot;, &quot;Status&quot; and &quot;Format Toolbar&quot;. However, in &quot;Congure Toolbars...&quot; there are 6 toolbars and the particular toolbars change depending on the particular protocol of the chat window. Problems:

1) I cannot move the &quot;Picture/Avatar&quot; icon to the main toolbar. 

2) The picture/avatar only works for MSN.

3) I need to edit the MSN toolbar to remove icons that already appear in the main toolbar or that I never use (&quot;Webcam&quot; icons). However, since there is another status bar, those changes only work for MSN, which is very confusing.

Not sure what is the status of all this in trunk and whether I should open bug reports for these issues.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>602599</commentid>
    <comment_count>42</comment_count>
    <who name="Bernd Buschinski">b.buschinski</who>
    <bug_when>2008-05-19 17:35:28 +0000</bug_when>
    <thetext>Still present for me with kopete-0.50.1/kde-4.0.4

I cant hide the &quot;Format Toolbar&quot;, it always comes back when I reopen the chatwindow or if I use the chatwindow with tabs when I switch from one to another</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>605614</commentid>
    <comment_count>43</comment_count>
    <who name="Matt Rogers">mattr</who>
    <bug_when>2008-05-31 18:48:24 +0000</bug_when>
    <thetext>Fixed by SVN revision 814689 and backported to KDE 4.0.x in revision 814670
</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>20518</attachid>
            <date>2007-05-08 22:55:22 +0000</date>
            <delta_ts>2007-05-08 22:55:22 +0000</delta_ts>
            <desc>kopete-format-toolbar.patch</desc>
            <filename>kopete-format-toolbar.patch</filename>
            <type>text/plain</type>
            <size>2856</size>
            <attacher name="Josh Berry">des</attacher>
            
              <data encoding="base64">SW5kZXg6IGtvcGV0ZS9jaGF0d2luZG93L2tvcGV0ZWNoYXR3aW5kb3cuY3BwCj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIGtvcGV0ZS9jaGF0d2luZG93L2tvcGV0ZWNoYXR3aW5kb3cuY3BwCShyZXZpc2lvbiA2NjI1
NjcpCisrKyBrb3BldGUvY2hhdHdpbmRvdy9rb3BldGVjaGF0d2luZG93LmNwcAkod29ya2luZyBj
b3B5KQpAQCAtMjE2LDYgKzIxNiw4IEBACiAKIAlLR2xvYmFsOjpjb25maWcoKS0+c2V0R3JvdXAo
IFFTdHJpbmc6OmZyb21MYXRpbjEoIkNoYXRXaW5kb3dTZXR0aW5ncyIpICk7CiAJbV9hbHdheXNT
aG93VGFicyA9IEtHbG9iYWw6OmNvbmZpZygpLT5yZWFkQm9vbEVudHJ5KCBRU3RyaW5nOjpmcm9t
TGF0aW4xKCJBbHdheXNTaG93VGFicyIpLCBmYWxzZSApOworCW1fc2hvd0Zvcm1hdFRvb2xiYXIg
PSBLR2xvYmFsOjpjb25maWcoKS0+cmVhZEJvb2xFbnRyeSggUVN0cmluZzo6ZnJvbUxhdGluMSgi
U2hvdyBGb3JtYXQgVG9vbGJhciIpLCB0cnVlICk7CisJYWRqdXN0aW5nRm9ybWF0VG9vbGJhciA9
IGZhbHNlOwogLy8Ja2REZWJ1ZyggMTQwMTAgKSA8PCBrX2Z1bmNpbmZvIDw8ICJPcGVuIFdpbmRv
d3M6ICIgPDwgd2luZG93cy5jb3VudCgpIDw8IGVuZGw7CiAJa2FwcC0+cmVmKCk7CiB9CkBAIC00
MTgsNiArNDIwLDkgQEAKIAogCXNldFhNTEZpbGUoIFFTdHJpbmc6OmZyb21MYXRpbjEoICJrb3Bl
dGVjaGF0d2luZG93LnJjIiApICk7CiAJY3JlYXRlR1VJKCAwTCApOworCisJLy8gU3BlY2lhbCBo
YW5kbGluZyBmb3IgcmVtZW1iZXJpbmcgd2hldGhlciB0aGUgZm9ybWF0IHRvb2xiYXIgaXMgdmlz
aWJsZSBvciBub3QKKwljb25uZWN0ICggdG9vbEJhcigiZm9ybWF0VG9vbEJhciIpLCBTSUdOQUwo
dmlzaWJpbGl0eUNoYW5nZWQoYm9vbCkpLCB0aGlzLCBTTE9UKHNsb3RUb2dnbGVGb3JtYXRUb29s
YmFyKGJvb2wpKSApOwogfQogCiBjb25zdCBRU3RyaW5nIEtvcGV0ZUNoYXRXaW5kb3c6OmZpbGVD
b250ZW50cyggY29uc3QgUVN0cmluZyAmcGF0aCApIGNvbnN0CkBAIC0xMDI5LDYgKzEwMzQsNyBA
QAogCUtDb25maWcgKmNvbmZpZyA9IEtHbG9iYWw6OmNvbmZpZygpOwogCWFwcGx5TWFpbldpbmRv
d1NldHRpbmdzKCBjb25maWcsIFFTdHJpbmc6OmZyb21MYXRpbjEoICJLb3BldGVDaGF0V2luZG93
IiApICk7CiAJY29uZmlnLT5zZXRHcm91cCggUVN0cmluZzo6ZnJvbUxhdGluMSgiQ2hhdFdpbmRv
d1NldHRpbmdzIikgKTsKKwltX3Nob3dGb3JtYXRUb29sYmFyID0gY29uZmlnLT5yZWFkQm9vbEVu
dHJ5KCBRU3RyaW5nOjpmcm9tTGF0aW4xKCJTaG93IEZvcm1hdCBUb29sYmFyIiksIHRydWUgKTsK
IH0KIAogdm9pZCBLb3BldGVDaGF0V2luZG93OjpzYXZlT3B0aW9ucygpCkBAIC0xMDQzLDYgKzEw
NDksNyBAQAogCWlmKCBtX3RhYkJhciApCiAJCWNvbmZpZy0+d3JpdGVFbnRyeSAoIFFTdHJpbmc6
OmZyb21MYXRpbjEoIlRhYiBQbGFjZW1lbnQiKSwgbV90YWJCYXItPnRhYlBvc2l0aW9uKCkgKTsK
IAorCWNvbmZpZy0+d3JpdGVFbnRyeSggUVN0cmluZzo6ZnJvbUxhdGluMSgiU2hvdyBGb3JtYXQg
VG9vbGJhciIpLCBtX3Nob3dGb3JtYXRUb29sYmFyICk7CiAJY29uZmlnLT5zeW5jKCk7CiB9CiAK
QEAgLTEwNzIsNiArMTA3OSwxMyBAQAogCQlzdGF0dXNCYXIoKS0+c2hvdygpOwogfQogCit2b2lk
IEtvcGV0ZUNoYXRXaW5kb3c6OnNsb3RUb2dnbGVGb3JtYXRUb29sYmFyKGJvb2wgdmlzaWJsZSkK
K3sKKwlpZiAoIGFkanVzdGluZ0Zvcm1hdFRvb2xiYXIgKQorCQlyZXR1cm47CisJbV9zaG93Rm9y
bWF0VG9vbGJhciA9IHZpc2libGU7Cit9CisKIHZvaWQgS29wZXRlQ2hhdFdpbmRvdzo6c2xvdFZp
ZXdNZW51QmFyKCkKIHsKIAlpZiggIW1lbnVCYXIoKS0+aXNIaWRkZW4oKSApCkBAIC0xMDkyLDEw
ICsxMTA2LDEyIEBACiAJaWYgKCBjdiAhPSBtX2FjdGl2ZVZpZXcgKQogCQlyZXR1cm47CiAKLQlp
ZiAoIGVuYWJsZWQgKQorCWFkanVzdGluZ0Zvcm1hdFRvb2xiYXIgPSB0cnVlOworCWlmICggZW5h
YmxlZCAmJiBtX3Nob3dGb3JtYXRUb29sYmFyICkKIAkJdG9vbEJhciggImZvcm1hdFRvb2xCYXIi
ICktPnNob3coKTsKIAllbHNlCiAJCXRvb2xCYXIoICJmb3JtYXRUb29sQmFyIiApLT5oaWRlKCk7
CisJYWRqdXN0aW5nRm9ybWF0VG9vbGJhciA9IGZhbHNlOwogCXVwZGF0ZVNwZWxsQ2hlY2tBY3Rp
b24oKTsKIH0KIApJbmRleDoga29wZXRlL2NoYXR3aW5kb3cva29wZXRlY2hhdHdpbmRvdy5oCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIGtvcGV0ZS9jaGF0d2luZG93L2tvcGV0ZWNoYXR3aW5kb3cuaAkocmV2aXNp
b24gNjYyNTY3KQorKysga29wZXRlL2NoYXR3aW5kb3cva29wZXRlY2hhdHdpbmRvdy5oCSh3b3Jr
aW5nIGNvcHkpCkBAIC0xMjcsNiArMTI3LDggQEAKIAlDaGF0VmlldyAqbV9hY3RpdmVWaWV3Owog
CUNoYXRWaWV3ICptX3BvcHVwVmlldzsKIAlib29sIG1fYWx3YXlzU2hvd1RhYnM7CisJYm9vbCBt
X3Nob3dGb3JtYXRUb29sYmFyOworCWJvb2wgYWRqdXN0aW5nRm9ybWF0VG9vbGJhcjsKIAlib29s
IHVwZGF0ZUJnOwogCUtUYWJXaWRnZXQgKm1fdGFiQmFyOwogCUtQdXNoQnV0dG9uICptX2J1dHRv
bl9zZW5kOwpAQCAtMjAwLDYgKzIwMiw3IEBACiAKIAl2b2lkIHNsb3RWaWV3TWVudUJhcigpOwog
CXZvaWQgc2xvdFRvZ2dsZVN0YXR1c0JhcigpOworCXZvaWQgc2xvdFRvZ2dsZUZvcm1hdFRvb2xi
YXIoIGJvb2wgKTsKIAogCXZvaWQgc2xvdENvbmZLZXlzKCk7CiAJdm9pZCBzbG90Q29uZlRvb2xi
YXIoKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>