510760 2025-10-18 17:51:13 +0000 Could NOT find Eigen3 5.0.0 2025-12-25 10:53:58 +0000 1 1 2 Applications digikam Plugin-Editor-Sharpen 8.8.0 Fedora RPMs Linux RESOLVED FIXED NOR normal --- 0 nucleo digikam-bugs-null caulier.gilles grzybr1 metzpinguin https://invent.kde.org/graphics/digikam/-/commit/e7d4be62f8a523cf9a07fa7af39f439df3d93ea5 9.0.0 0 oldest_to_newest 2462949 0 nucleo 2025-10-18 17:51:13 +0000 SUMMARY Eigen3 5.0.0 could not be found STEPS TO REPRODUCE 1. Try to compile with eigen3 5.0.0 2. 3. OBSERVED RESULT -- Eigen3 version .. found in /usr/include/eigen3, but at least version 2.91.0 is required -- Could NOT find Eigen3 (missing: EIGEN3_VERSION_OK) (Required is at least version "2.91.0") -- libeigen3 found.......................... NO (optional) -- digiKam will be compiled without Refocus tool support. -- Please install the libeigen3 (version >= 3.0.0) development package. EXPECTED RESULT -- Found Eigen3: /usr/include/eigen3 (Required is at least version "2.91.0") SOFTWARE/OS VERSIONS Fedora 44 2462969 1 metzpinguin 2025-10-18 19:23:52 +0000 Eigen 5.0.0, released on October 9, 2025, may not yet be compatible with digiKam. Use Eigen 3.4.x. Maik 2462978 2 arojas 2025-10-18 19:54:13 +0000 DigiKam finds Eigen 5 and builds just fine if using Eigen's upstream cmake config, but DigiKam's own FindEigen module (which is not compatible with Eigen 5) gets in the way. Just rm core/cmake/modules/FindEigen3.cmake and pass -DEIGEN3_INCLUDE_DIR=/usr/include/eigen3 to cmake as a workaround 2473685 3 grzybr1 2025-11-30 16:21:45 +0000 Currently, Digikam's `../core/cmake/modules/FindEigen3.cmake` has a macro defined ( `_eigen3_check_version` ) which rely on being able to find the following defines: ``` #define EIGEN_WORLD_VERSION 3 #define EIGEN_MAJOR_VERSION 4 #define EIGEN_MINOR_VERSION 1 ``` by looking for them in a file from Eigen project called `../core/cmake/modules/FindEigen3.cmake`. This used to work for Eigen versions up to and including version 3.4.1. Starting with version 5 the Eigen project did the sensible thing and adopted semantic versioning, while at same time moving the definitions to a different file `Eigen/Version`: ``` #ifndef EIGEN_VERSION_H #define EIGEN_VERSION_H // The "WORLD" version will forever remain "3" for the "Eigen3" library. #define EIGEN_WORLD_VERSION 3 // As of Eigen3 5.0.0, we have moved to Semantic Versioning (semver.org). #define EIGEN_MAJOR_VERSION 5 #define EIGEN_MINOR_VERSION 0 #define EIGEN_PATCH_VERSION 1 #define EIGEN_PRERELEASE_VERSION "dev" #define EIGEN_BUILD_VERSION "master" #define EIGEN_VERSION_STRING "5.0.1-dev+master" #endif // EIGEN_VERSION_H ``` The cmake find module should be amended to parse the definitions from the new file (and possibly as a fallback from the previous file). 2473687 4 grzybr1 2025-11-30 16:32:09 +0000 Correction: > Currently, Digikam's `../core/cmake/modules/FindEigen3.cmake` has a macro defined ( `_eigen3_check_version` ) which rely on being able to find the following defines: > ... > by looking for them in a file from Eigen project called `../core/cmake/modules/FindEigen3.cmake`. > This used to work for Eigen versions up to and including version 3.4.1. The above should read: by looking for them in a file from Eigen project called `../Eigen/src/Core/util/Macros.h`. 2473688 5 arojas 2025-11-30 16:34:30 +0000 Again, the cmake module should just be removed in favor of the upstream one. 2473691 6 grzybr1 2025-11-30 16:48:45 +0000 On 30/11/2025 16:34, Antonio Rojas wrote: > https://bugs.kde.org/show_bug.cgi?id=510760 > > --- Comment #5 from Antonio Rojas <arojas@archlinux.org> --- > Again, the cmake module should just be removed in favor of the upstream one. Agree, this would be the most appropriate solution ... 2473792 7 caulier.gilles 2025-12-01 06:56:03 +0000 As i can see here on my Kubuntu 24.04 LTS, the Eigen3 version 3.5.0 is already ported to Cmake and configuration are shared on the system. This want mean that we can drop the findeigen3.cmake script at all and set the minimum dependency to 3.5.0 Note: on the gihub mirror, Eigen3 version 3.2.0 is already ported to cmake, but i don't know if cmake configuration have been already shared on the system. 2473795 8 caulier.gilles 2025-12-01 07:10:38 +0000 Git commit e7d4be62f8a523cf9a07fa7af39f439df3d93ea5 by Gilles Caulier. Committed on 01/12/2025 at 07:09. Pushed by cgilles into branch 'master'. Use Eigen3 cmake configuration shared on the system. FIXED-IN: 8.9.0 M +2 -2 NEWS M +1 -1 core/app/utils/digikam_config.h.cmake.in D +0 -83 core/cmake/modules/FindEigen3.cmake https://invent.kde.org/graphics/digikam/-/commit/e7d4be62f8a523cf9a07fa7af39f439df3d93ea5 2473797 9 arojas 2025-12-01 07:48:39 +0000 Note that this is not ennogh to build with eigen 5.x, since the EIGEN3_INCLUDE_DIRS variable is removed in that version. See https://invent.kde.org/graphics/digikam/-/merge_requests/377 2475692 10 grzybr1 2025-12-09 23:18:14 +0000 Thank you for fixing this, as of today the flatpack version is built with Eigen 5.0.1 and the Refocus tool is working again: ``` ID: org.kde.digikam Ref: app/org.kde.digikam/x86_64/stable Arch: x86_64 Branch: stable Version: 8.8.0 License: GPL-2.0+ Origin: flathub Collection: org.flathub.Stable Installation: system Installed: 670.3 MB Runtime: org.kde.Platform/x86_64/6.10 Sdk: org.kde.Sdk/x86_64/6.10 Commit: 42b2eb64a4297b01f45e7bc085a70889b1129ed10757eb474e3b3d56f8f3d41d Parent: 8fd5c75ba795d5b69c6917e8973aa28274609ab2779c381ed4e618817c285ef0 Subject: Merge pull request #277 from flathub/fix-eigen3 (2fe609cb1e1f) Date: 2025-12-09 16:06:12 +0000 ```