51014 2002-11-21 20:11:52 +0000 kghostview (as konqueror part) opening next document breaks paper orientation 2003-04-16 00:58:40 +0000 1 1 10 Unmaintained kghostview general unspecified Compiled Sources Linux RESOLVED FIXED NOR normal --- 1 frank.dekervel greven 0 oldest_to_newest 106621 0 frank.dekervel 2002-11-21 20:11:52 +0000 Version: 0.13.2 (using KDE 3.1.0 (KDE 3.1 RC4)) Installed from: compiled sources Compiler: gcc version 2.95.4 20011002 (Debian prerelease) OS: Linux (i686) release 2.4.19 when i change the paper orientation for a .ps document in konqueror, and i open another ps document in the same konqueror, the menu 'paper orientation' is inconsistent with the real paper orientation. i did this: -> opened landscape ps, was rendered upside down, so i chose seascape -> open next ps document. its rendered landscape again (upside down) but there is still a 'v' next to 'seascape' in the view->paper orientation menu. -> i have to select something else and then seascape again to get it right 108316 1 luis 2002-12-04 20:30:35 +0000 Hi, The bug report is about kghostview used as a part, but it affects kghostview as an app as well. The attached patch seems to fixed it. It changes the behaviour slightly to be, IMHO, more correct. Before, none of the options were checked by default. Now, "Auto" (which is default behaviour) is checked until you select something else. So this reflects the state of the program better. HTH -- Luis Pedro Coelho check out my game of hearts for the KDE at http://hearts.sf.net 108317 2 573 luis 2002-12-04 20:32:58 +0000 Created attachment 573 Proposed fix against CVS HEAD 126970 3 luis 2003-04-05 14:31:57 +0000 Subject: KDE_3_1_BRANCH: kdegraphics/kghostview CVS commit by luis_pedro: Apply my own patch from when I didn't have a CVS account. This goes towards fixing bug 51014. It works in BRANCH, but HEAD has been changed since my patch and needs porting. CCMAIL: 51014@bugs.kde.org M +11 -1 kgv_view.cpp 1.110.2.2 M +5 -0 kgv_view.h 1.54.2.1 --- kdegraphics/kghostview/kgv_view.h #1.54:1.54.2.1 @@ -135,4 +135,9 @@ protected: void writeSettings(); + /** + * Resets the menu settings, i.e. sets View->Orientation to "Auto", etc. + */ + void resetMenu(); + private: KGVBrowserExtension* _extension; --- kdegraphics/kghostview/kgv_view.cpp #1.110.2.1:1.110.2.2 @@ -474,4 +474,5 @@ bool KGVPart::openURL( const KURL& url ) SLOT( slotMimetypeError() ) ); + resetMenu(); return true; } @@ -601,5 +602,8 @@ void KGVPart::slotJobFinished( KIO::Job* emit canceled( job->errorString() ); else + { _docManager->openFile( m_file, _mimetype ); + resetMenu(); + } } @@ -612,4 +616,5 @@ void KGVPart::slotFileDirty( const QStri _currentPage = _docManager->currentPage(); _docManager->openFile( m_file, _mimetype ); + resetMenu(); } } @@ -687,4 +692,9 @@ void KGVPart::slotZoomOut() } +void KGVPart::resetMenu() +{ + _selectOrientation->setCurrentItem( 0 ); // Auto + _selectMedia->setCurrentItem( 0 ); // Auto +} KGVBrowserExtension::KGVBrowserExtension( KGVPart *parent ) : 128867 4 luis 2003-04-16 00:58:42 +0000 Subject: kdegraphics/kghostview CVS commit by luis_pedro: Forward porting of fix to Bug 51014: opening next document breaks paper orientation. We need to restore the display options to their default settings on opening a new document. Note that we shouldn't do that if we are reloading a document which changed. CCMAIL: 51014-done@bugs.kde.org M +1 -0 kgv_view.cpp 1.129 --- kdegraphics/kghostview/kgv_view.cpp #1.128:1.129 @@ -554,4 +554,5 @@ void KGVPart::slotOpenFileCompleted() else { + setOptions( DisplayOptions() ); _docManager->goToPage( _currentPage ); stateChanged( "documentState" ); 573 2002-12-04 20:32:58 +0000 2002-12-04 20:32:58 +0000 Proposed fix against CVS HEAD patch.kghostview text/plain 1895 luis SW5kZXg6IGtndl92aWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL2tkZWdyYXBoaWNz L2tnaG9zdHZpZXcva2d2X3ZpZXcuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjExMApkaWZm IC11IC0zIC1wIC1yMS4xMTAga2d2X3ZpZXcuY3BwCi0tLSBrZ3Zfdmlldy5jcHAJMjAwMi8xMS8x MiAyMDoxNTozNwkxLjExMAorKysga2d2X3ZpZXcuY3BwCTIwMDIvMTEvMjMgMTk6NDA6MjMKQEAg LTQ3Miw3ICs0NzIsOCBAQCBib29sIEtHVlBhcnQ6Om9wZW5VUkwoIGNvbnN0IEtVUkwmIHVybCAp CiAgICAgICAgICAgICAgU0xPVCggc2xvdE1pbWV0eXBlRmluaXNoZWQoIGNvbnN0IFFTdHJpbmcm ICkgKSApOwogICAgIGNvbm5lY3QoIF9taW1ldHlwZVNjYW5uZXIsIFNJR05BTCggZXJyb3IoKSAp LAogICAgICAgICAgICAgIFNMT1QoIHNsb3RNaW1ldHlwZUVycm9yKCkgKSApOwotICAgCisKKyAg ICByZXNldE1lbnUoKTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIApAQCAtNTk4LDcgKzU5OSwxMCBA QCB2b2lkIEtHVlBhcnQ6OnNsb3RKb2JGaW5pc2hlZCggS0lPOjpKb2IqCiAgICAgaWYoIGpvYi0+ ZXJyb3IoKSApCiAJZW1pdCBjYW5jZWxlZCggam9iLT5lcnJvclN0cmluZygpICk7CiAgICAgZWxz ZSAKKyAgICB7CiAJX2RvY01hbmFnZXItPm9wZW5GaWxlKCBtX2ZpbGUsIF9taW1ldHlwZSApOwor CXJlc2V0TWVudSgpOworICAgIH0KIH0KIAogdm9pZCBLR1ZQYXJ0OjpzbG90RmlsZURpcnR5KCBj b25zdCBRU3RyaW5nJiBmaWxlTmFtZSApCkBAIC02MDksNiArNjEzLDcgQEAgdm9pZCBLR1ZQYXJ0 OjpzbG90RmlsZURpcnR5KCBjb25zdCBRU3RyaQogCV9pc0ZpbGVEaXJ0eSA9IHRydWU7CiAJX2N1 cnJlbnRQYWdlID0gX2RvY01hbmFnZXItPmN1cnJlbnRQYWdlKCk7CiAJX2RvY01hbmFnZXItPm9w ZW5GaWxlKCBtX2ZpbGUsIF9taW1ldHlwZSApOworCXJlc2V0TWVudSgpOwogICAgIH0KIH0KIApA QCAtNjg0LDYgKzY4OSwxMSBAQCB2b2lkIEtHVlBhcnQ6OnNsb3Rab29tT3V0KCkKICAgICB1cGRh dGVab29tQWN0aW9ucygpOwogfQogCit2b2lkIEtHVlBhcnQ6OnJlc2V0TWVudSgpCit7CisgICAg X3NlbGVjdE9yaWVudGF0aW9uLT5zZXRDdXJyZW50SXRlbSggMCApOyAvLyBBdXRvCisgICAgX3Nl bGVjdE1lZGlhLT5zZXRDdXJyZW50SXRlbSggMCApOyAvLyBBdXRvCit9CiAKIEtHVkJyb3dzZXJF eHRlbnNpb246OktHVkJyb3dzZXJFeHRlbnNpb24oIEtHVlBhcnQgKnBhcmVudCApIDoKICAgICBL UGFydHM6OkJyb3dzZXJFeHRlbnNpb24oIHBhcmVudCwgIktHVkJyb3dzZXJFeHRlbnNpb24iICkK SW5kZXg6IGtndl92aWV3LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9rZGVncmFwaGljcy9r Z2hvc3R2aWV3L2tndl92aWV3LmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNTQKZGlmZiAtdSAt MyAtcCAtcjEuNTQga2d2X3ZpZXcuaAotLS0ga2d2X3ZpZXcuaAkyMDAyLzA3LzI5IDA5OjM0OjI2 CTEuNTQKKysrIGtndl92aWV3LmgJMjAwMi8xMS8yMyAxOTo0MDoyMwpAQCAtMTM0LDYgKzEzNCwx MSBAQCBwcm90ZWN0ZWQ6CiAgICAgdm9pZCByZWFkU2V0dGluZ3MoKTsKICAgICB2b2lkIHdyaXRl U2V0dGluZ3MoKTsKIAorICAgIC8qKgorICAgICAqIFJlc2V0cyB0aGUgbWVudSBzZXR0aW5ncywg aS5lLiBzZXRzIFZpZXctPk9yaWVudGF0aW9uIHRvICJBdXRvIiwgZXRjLgorICAgICAqLworICAg IHZvaWQgcmVzZXRNZW51KCk7CisKIHByaXZhdGU6CiAgICAgS0dWQnJvd3NlckV4dGVuc2lvbiog X2V4dGVuc2lvbjsKIAo=