503724 2025-05-03 20:57:51 +0000 "Reviews and Comments" is styled as a web URL link, but navigates pages within the dialog 2025-05-31 10:01:25 +0000 1 1 3 Frameworks and Libraries frameworks-knewstuff general 6.13.0 openSUSE Linux RESOLVED FIXED junior-jobs NOR minor --- 1 john.kde admin 4wy78uwh alexander.lohnau john kdelibs-bugs-null nate https://invent.kde.org/frameworks/knewstuff/-/commit/e833d3140aeaa40b19fd0043c93ef5a51959c5ed 6.15 0 oldest_to_newest 2420901 0 john.kde 2025-05-03 20:57:51 +0000 SUMMARY When viewing an item in a Get New Stuff dialog, the entry "Reviews and Comments" text is in blue and underlined and changes the mouse pointer to a pointing finger on hover, despite the fact that it switches to another view in the dialog, not opening a web link. The KDE Human Interface Guidelines advise against this. STEPS TO REPRODUCE 1. Open System Settings 2. Click on Global Theme 3. Click "Get New..." 4. Click on an item 5. Look at the "XXX Reviews and Comments" text OBSERVED RESULT Text is in blue and underlined and changes the mouse pointer to a pointing finger on hover. EXPECTED RESULT Text is in a button. SOFTWARE/OS VERSIONS Operating System: openSUSE Tumbleweed 20250501 KDE Plasma Version: 6.3.4 KDE Frameworks Version: 6.13.0 Qt Version: 6.9.0 Kernel Version: 6.14.4-1-default (64-bit) Graphics Platform: X11 ADDITIONAL INFORMATION https://develop.kde.org/hig/getting_input/ 2422252 1 john 2025-05-08 19:19:46 +0000 Hi - I can see that as well, thanks! 2424064 2 bug-janitor 2025-05-14 21:50:45 +0000 A possibly relevant merge request was started @ https://invent.kde.org/frameworks/knewstuff/-/merge_requests/363 2428412 3 bug-janitor 2025-05-28 16:52:10 +0000 A possibly relevant merge request was started @ https://invent.kde.org/frameworks/knewstuff/-/merge_requests/366 2428673 4 kristen 2025-05-29 13:06:22 +0000 Git commit e833d3140aeaa40b19fd0043c93ef5a51959c5ed by Kristen McWilliam, on behalf of John Veness. Committed on 29/05/2025 at 13:06. Pushed by merritt into branch 'master'. Change "Comments and Reviews" link into a button Right now this is a link but doesn't open a URL, violating the HIG guideline against this. Instead, make it a conventional button. With credit and many thanks to Nate Graham for his initial work on this (see !363 for more discussion). | Before | After | | ------ | ------ | |  |  | |  |  | M +8 -7 src/qtquick/qml/EntryDetails.qml https://invent.kde.org/frameworks/knewstuff/-/commit/e833d3140aeaa40b19fd0043c93ef5a51959c5ed