499255 2025-01-28 20:29:52 +0000 Ledger appears blank (no transactions) 2025-01-30 16:43:42 +0000 1 1 2 Applications kmymoney reports git (master) Gentoo Packages Linux RESOLVED FIXED NOR normal --- 0 alexandref75 kmymoney-devel alexandref75 https://invent.kde.org/office/kmymoney/-/commit/d9db245c0e7125d9236421af5159b926376dad67 5.2 0 oldest_to_newest 2393386 0 177778 alexandref75 2025-01-28 20:29:52 +0000 Created attachment 177778 kmymoney file SUMMARY Ledger appear blank (no transactions). I bisected it to this commit cbcaed2493329507191b24fb7c8d0fa3a36eed92. From cbcaed2493329507191b24fb7c8d0fa3a36eed92 Mon Sep 17 00:00:00 2001 From: Thomas Baumgart <thb@net-bembel.de> Date: Sat, 18 Jan 2025 11:22:06 +0100 Subject: [PATCH 1/1] Fix tag filtering in tags view The transaction tab in the tags view did not show transactions that referenced more than one tag. Only those that had a single tag assigned were shown. This change fixes the problem by interpreting the returned data from the journal model properly as list of ids and checks each single one for a match. --- kmymoney/models/ledgerfilterbase.cpp | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/kmymoney/models/ledgerfilterbase.cpp b/kmymoney/models/ledgerfilterbase.cpp index eabf7913c..fc69ffeb0 100644 --- a/kmymoney/models/ledgerfilterbase.cpp +++ b/kmymoney/models/ledgerfilterbase.cpp @@ -181,8 +181,17 @@ bool LedgerFilterBase::filterAcceptsRow(int source_row, const QModelIndex& sourc } if (LedgerSortProxyModel::filterAcceptsRow(source_row, source_parent)) { - const auto id = idx.data(filterRole()).toString(); - bool rc = d->filterIds.contains(id); + const QVariant dataItem = idx.data(filterRole()); + bool rc = false; + if (dataItem.canConvert<QVariantList>()) { + QSequentialIterable vList = dataItem.value<QSequentialIterable>(); + for (const auto& v : vList) { + rc |= d->filterIds.contains(v.toString()); + } + } else { + const auto id = idx.data(filterRole()).toString(); + rc = d->filterIds.contains(id); + } // in case a journal entry has no id, it is the new transaction placeholder if (!rc) { -- 2.48.1 STEPS TO REPRODUCE 1. Use the attached test.kmy (created with a single account and two transactions) 2. Go to ledgers->select account test 3. OBSERVED RESULT Ledger appears blank EXPECTED RESULT Two transactions being printed SOFTWARE/OS VERSIONS Windows: macOS: (available in the Info Center app, or by running `kinfo` in a terminal window) KMyMoney: 5.1.90-13115d9f4 Alkimia: 8.1.92(I18N_ARGUMENT_MISSING) (build against 8.1.92(I18N_ARGUMENT_MISSING)) Gpgme: Unknown(I18N_ARGUMENT_MISSING) (build against 1.24.1(I18N_ARGUMENT_MISSING)) KDiagram: Unknown(I18N_ARGUMENT_MISSING) (build against (I18N_ARGUMENT_MISSING)) libofx: Unknown(I18N_ARGUMENT_MISSING) (build against 0.10.9(I18N_ARGUMENT_MISSING)) KDE Frameworks: 6.10.0 Qt: Using 6.8.1 and built against 6.8.1 Gentoo Linux (Wayland) Build ABI: x86_64-little_endian-lp64 Kernel: linux 6.13.0-gentoo-archlinux ADDITIONAL INFORMATION 2393387 1 alexandref75 2025-01-28 20:32:01 +0000 Reverting the references commit fixes the error. 2393601 2 tbaumgart 2025-01-29 17:06:53 +0000 I am unable to duplicate the problem :( Both transactions show up just fine here (latest master). Are you building against Qt5 or Qt6? 2393624 3 alexandref75 2025-01-29 18:06:56 +0000 Against qt6 2393704 4 alexandref75 2025-01-30 00:22:14 +0000 A little additional debugging. Running with this debug added: const QVariant dataItem = idx.data(filterRole()); bool rc = false; if (dataItem.canConvert<QVariantList>()) { QSequentialIterable vList = dataItem.value<QSequentialIterable>(); for (const auto& v : vList) { qDebug() << "Processing filterRole " << v.toString(); rc |= d->filterIds.contains(v.toString()); qDebug() << "Result filterRole " << rc; } } else { const auto id = idx.data(filterRole()).toString(); qDebug() << "Processing filterRole " << id; rc = d->filterIds.contains(id); qDebug() << "Result filterRole " << rc; } Produces: ----------------------------------------------- Processing filterRole "A" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "1" Result filterRole false Processing filterRole "A" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "1" Result filterRole false Processing filterRole "" Result filterRole false Processing filterRole "" Result filterRole false Processing filterRole "A" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "1" Result filterRole false Processing filterRole "A" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "0" Result filterRole false Processing filterRole "1" Result filterRole false ---------------------------------------------- commenting the lines and running again: const QVariant dataItem = idx.data(filterRole()); bool rc = false; //if (dataItem.canConvert<QVariantList>()) { // QSequentialIterable vList = dataItem.value<QSequentialIterable>(); // for (const auto& v : vList) { // qDebug() << "Processing filterRole " << v.toString(); // rc |= d->filterIds.contains(v.toString()); // qDebug() << "Result filterRole " << rc; // } //} else { const auto id = idx.data(filterRole()).toString(); qDebug() << "Processing filterRole " << id; rc = d->filterIds.contains(id); qDebug() << "Result filterRole " << rc; //} Produces: ----------------------------------------------- Processing filterRole "A000001" Result filterRole true Processing filterRole "A000001" Result filterRole true Processing filterRole "" Result filterRole false Processing filterRole "A000001" Result filterRole true Processing filterRole "A000001" Result filterRole true Processing filterRole "" Result filterRole false ---------------------------------------------- 2393840 5 tbaumgart 2025-01-30 15:43:31 +0000 Seems that the problem is the apparently different behavior of QVariant::canConvert<QVariantList>() when used on a QVariant created from a QString between Qt5 (results in false) and Qt6 (results in true). 2393855 6 thb 2025-01-30 16:43:42 +0000 Git commit d9db245c0e7125d9236421af5159b926376dad67 by Thomas Baumgart. Committed on 30/01/2025 at 16:43. Pushed by tbaumgart into branch 'master'. Resolve different behavior of Qt5 vs Qt6 with QVariant FIXED-IN: 5.2 M +3 -9 kmymoney/models/ledgerfilterbase.cpp https://invent.kde.org/office/kmymoney/-/commit/d9db245c0e7125d9236421af5159b926376dad67 177778 2025-01-28 20:29:52 +0000 2025-01-28 20:29:52 +0000 kmymoney file test.kmy application/x-kmymoney 962 alexandref75 H4sICIEcmGcAAwDtVtuSm0YQfc9XEMqvrAAbraRi42Jh5BBrgeLiil7iQjDapZZbALmspPLv6Rlm uGhrs7GrNk/hhemeHvqc00zP6O+/FrnwBTdtVpU3onIliwIukyrNyvsbMQq30kp8/9MP+o+Wa4Z7 Dwkf7/Z3roP20tbeIZi4sAVBJwPb2brEANP0kRHarvPZMkIkpHGHb0RVVmRJXknKWlywsJ0RhJ/v XMve2siax6qaJCuSeh0q1xtN3WjXkrzcyPKw9BPyA0ggZCkQGLxb+9fpxHKYMDxvOqFdKVdrWTqq q7WiYZz0cfpiSkOPAuQLZVwAnhC3HWhUxFl+I4r8m5bloyAQ2q7BuAO/kGTdmbzbjrIQhT+ymrw6 nOP6oSqpL6lOZdech+GZBYL+dL6u2o6NGSoChI5sJwjtMCLKBv2cZ+wRChggalB+nkweRWTwOwq/ wUfcQJ1pFs5FKOIueYDC4zI+5JiqKZxacNCJRwzwZB51X1YNTuIW06gx4Lc3TJP/ThWiC+XbSzTq oJtuEJrICaHcvUah8YGNDNN0IyfkejGTKmYEXbrZGG2LQak6Bp26OKFISPY8JnSSqkwyqlHvKWDH HLPezsq2y7pTR3eUKFQ1LvuJ8lQccEP5nmuAv+ZFYblS3CZNVvOFyakhNQL6UWCNqgbR7Rz8hbfn wKq+GJYtnqzTF8x+VoNdFh+yHGr2ujooMhdikvAfxVg8Cxl9hTQtfmXAbzngId13wrWh1xavjVbl aHm279X299Pr/wvLQVqW7dvB8o53gXO2r1+CPB47z4LnIbS5XtKY99uXOQybse9coW84gWHS9s4o TlyUZihfPkrfGy/PTWjPuKhopyd99ek0/BSEePek03g7e95kiIMmD7jCZ4wnZ8yoKOvvccI5D1PH PL6nB8mXOD9BkKTI8gLWtg9Qrna06yYj5xMdcwJjLYdTbRD+EJePBNqs500Y6IuJgv9aU/V/Tb9F 05mj/5U/ov0nYxchz7D98Xpi+wK9L+xg193RXZfEhJYFJAcaL9/9xg89FoV0gPuIyfbW8JFpm5iH Z+kQ9Kf29lrVVvJSSrTjUnq3XKXSOlEVScOqFqepkmJ19Rffqk8o6YH5M7KiHWK3iwCZkW+HNrfB 8pFj2sP9jDn2tPAEIWsXUSBYVZ7HDdTuXBwquJe94T0FDp0GKkWu5lKBu4cKlsKf1sZHcoRC8Wu4 S70DR8IcDO08ue75tslx+chz/ZAZt5H1AXHDdXa2g35xb4kNjOfX/L8BTXK6/TcMAAA=