<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>498320</bug_id>
          
          <creation_ts>2025-01-06 15:02:45 +0000</creation_ts>
          <short_desc>Renaming a face tag fails to move over the training data</short_desc>
          <delta_ts>2025-01-31 18:45:49 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>digikam</product>
          <component>Faces-Workflow</component>
          <version>8.5.0</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Steven Robbins">steve</reporter>
          <assigned_to name="Digikam Developers">digikam-bugs-null</assigned_to>
          <cc>caulier.gilles</cc>
    
    <cc>michael_miller</cc>
          
          <cf_commitlink>https://invent.kde.org/graphics/digikam/-/commit/13fbc1ae5309e5dbd6b1ef24244f3f486ca45d97</cf_commitlink>
          <cf_versionfixedin>8.6.0</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2387197</commentid>
    <comment_count>0</comment_count>
    <who name="Steven Robbins">steve</who>
    <bug_when>2025-01-06 15:02:45 +0000</bug_when>
    <thetext>I have encountered situations where I wanted to change the tag name for a person.  For example, I have started a tag with their first name and later changed to First+Last.  Or I accidentally entered a trailing space -- e.g. &quot;Steve &quot; -- that I later changed to &quot;Steve&quot;.  In either case, it was easy enough to rename the tag using the People tag, selecting the desired tag and selecting  &quot;Properties&quot; from the right-click context menu.

The bug is that after a further round of face recognition, the old tag name reappears.

Michael Miller supplied a workaround: Retrain your face DB by going to Tools-&gt;Maintenance-&gt;Detect and Recognize Faces.  Select “Rebuild all training data” and click ok.

https://mail.kde.org/pipermail/digikam-users/2024-December/036856.html




SUMMARY


STEPS TO REPRODUCE
1. Create people tag &quot;A&quot;
2. Detect some faces of A
3. Rename &quot;A&quot; --&gt; &quot;B&quot;
4. Re-run detection 

OBSERVED RESULT
At step 4, people tag &quot;B&quot; reappears.

EXPECTED RESULT
At step 4, only people tag &quot;B&quot; is present.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2387207</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Miller">michael_miller</who>
    <bug_when>2025-01-06 15:19:50 +0000</bug_when>
    <thetext>(In reply to Steven Robbins from comment #0)
&gt; I have encountered situations where I wanted to change the tag name for a
&gt; person.  For example, I have started a tag with their first name and later
&gt; changed to First+Last.  Or I accidentally entered a trailing space -- e.g.
&gt; &quot;Steve &quot; -- that I later changed to &quot;Steve&quot;.  In either case, it was easy
&gt; enough to rename the tag using the People tag, selecting the desired tag and
&gt; selecting  &quot;Properties&quot; from the right-click context menu.
&gt; 
&gt; The bug is that after a further round of face recognition, the old tag name
&gt; reappears.
&gt; 
&gt; Michael Miller supplied a workaround: Retrain your face DB by going to
&gt; Tools-&gt;Maintenance-&gt;Detect and Recognize Faces.  Select “Rebuild all
&gt; training data” and click ok.
&gt; 
&gt; https://mail.kde.org/pipermail/digikam-users/2024-December/036856.html
&gt; 
&gt; 
&gt; 
&gt; 
&gt; SUMMARY
&gt; 
&gt; 
&gt; STEPS TO REPRODUCE
&gt; 1. Create people tag &quot;A&quot;
&gt; 2. Detect some faces of A
&gt; 3. Rename &quot;A&quot; --&gt; &quot;B&quot;
&gt; 4. Re-run detection 
&gt; 
&gt; OBSERVED RESULT
&gt; At step 4, people tag &quot;B&quot; reappears.
&gt; 
&gt; EXPECTED RESULT
&gt; At step 4, only people tag &quot;B&quot; is present.

Hi Steve,
I&apos;ll look at the root cause next week.  It will be fixed in 8.6.0.

Cheers,
Mike</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2394211</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Miller">michael_miller</who>
    <bug_when>2025-01-31 18:45:49 +0000</bug_when>
    <thetext>Git commit 13fbc1ae5309e5dbd6b1ef24244f3f486ca45d97 by Michael Miller.
Committed on 31/01/2025 at 18:45.
Pushed by michmill into branch &apos;master&apos;.

498320 - Renaming a face tag fails to move over the training data
FIXED-IN: 8.6.0

M  +12   -0    .gitignore
M  +1    -1    NEWS
M  +5    -0    core/libs/facesengine/common/identity.cpp
M  +2    -0    core/libs/facesengine/common/identity.h
M  +34   -0    core/libs/facesengine/recognition/identityprovider.cpp
M  +6    -1    core/libs/facesengine/recognition/identityprovider.h
M  +9    -3    core/libs/tags/engine/tagmodificationhelper.cpp

https://invent.kde.org/graphics/digikam/-/commit/13fbc1ae5309e5dbd6b1ef24244f3f486ca45d97</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>