494159 2024-10-05 08:35:39 +0000 Wrong decimal separator in CSV import 2025-01-21 17:04:11 +0000 1 1 2 Applications skrooge general 2.33.0 Debian testing Linux RESOLVED FIXED NOR normal 25.1.0 0 pat_h pat_h stephane https://invent.kde.org/office/skrooge/-/commit/459a500b74fd03b315ffef2d3d86e3192b888b60 0 oldest_to_newest 2362990 0 pat_h 2024-10-05 08:35:39 +0000 Hi, with a German bank, the CSV export uses comma as a decimal separator and a point as a digit group separator (https://en.wikipedia.org/wiki/Decimal_separator#Digit_grouping). However, for integer values, the bank does not include the fractional part in the CSV output resulting in something like "1.234" for 1234 €. This, however, is imported by Skrooge as a fraction resulting in 1.23 € (i.e. a euro and 23 cent). I see at least four possibilities how this can be solved 1. Argue with the bank to avoid using a point as a group separator as this is against the standards (https://en.wikipedia.org/wiki/Decimal_separator#Current_standards). I'll try that, but this is unlikely to change anything (we are talking about Germany here, where more than 25 years after introducing ISO 8601 via DIN EN 28601 kids still do not learn in school how to write a date correctly). 2. Use the decimal and group separators from the current locale when doing the CSV import in Skrooge. 3. Have an option to change the decimal and group separators when doing the CSV import in Skrooge. 4. Interpret the point as a group separator if there are three trailing digits. 2363214 1 stephane 2024-10-06 12:05:45 +0000 Hi, Could you provide me a sample csv file anonymized ? This is just to be sure I well take into account the right use case. 2363245 2 174481 pat_h 2024-10-06 16:15:16 +0000 Created attachment 174481 Example for group separator 2363246 3 pat_h 2024-10-06 16:20:30 +0000 Thanks for taking a look. I prepared a file with some lines deleted where only examples of relevant amounts and their formatting are included. I can't comment in #494197 as it is already closed, therefore I'll state it here: Thank you very much for implementing the "checking" functionality and in addition doing it in such a short time! I really appreciate that! 2365275 4 stephane 2024-10-12 16:04:48 +0000 Git commit 459a500b74fd03b315ffef2d3d86e3192b888b60 by Stephane MANKOWSKI. Committed on 12/10/2024 at 16:04. Pushed by smankowski into branch 'master'. Wrong decimal separator in CSV import M +1 -0 CHANGELOG M +19 -17 skgbasemodeler/skgservices.cpp A +6 -0 tests/input/skgtestimportcsv/494159.csv M +15 -15 tests/input/skgtestimportcsvunit/test2.csv M +28 -3 tests/skgbankmodelertest/skgtestimportcsv.cpp M +6 -0 tests/skgbasemodelertest/skgtestbase.cpp https://invent.kde.org/office/skrooge/-/commit/459a500b74fd03b315ffef2d3d86e3192b888b60 2391360 5 stephane 2025-01-21 17:04:11 +0000 For information, this fix is generating issues for some German users: https://bugs.kde.org/show_bug.cgi?id=498903 174481 2024-10-06 16:15:16 +0000 2024-10-06 16:15:16 +0000 Example for group separator export_group_separator.csv text/csv 919 pat_h 77u/Ikdpcm9rb250byIsIkRFWFhYWFhYWFhYWFhYWFhYWFhYWFgiCiIiCiJLb250b3N0YW5kIHZv bSAxNy4wOS4yMDI0OiIsIlguWFhYLFhYwqDigqwiCiIiCiJCdWNodW5nc2RhdHVtIiwiV2VydHN0 ZWxsdW5nIiwiU3RhdHVzIiwiWmFobHVuZ3NwZmxpY2h0aWdlKnIiLCJaYWhsdW5nc2VtcGbDpG5n ZXIqaW4iLCJWZXJ3ZW5kdW5nc3p3ZWNrIiwiVW1zYXR6dHlwIiwiSUJBTiIsIkJldHJhZyAo4oKs KSIsIkdsw6R1YmlnZXItSUQiLCJNYW5kYXRzcmVmZXJlbnoiLCJLdW5kZW5yZWZlcmVueiIKIjEw LjA5LjI0IiwiMTAuMDkuMjQiLCJHZWJ1Y2h0IiwiTXkgTmFtZSIsIk90aGVyIE5hbWUiLCJUZXh0 IiwiQXVzZ2FuZyIsIkRFWFhYWFhYWFhYWFhYWFhYWFhYWFgiLCItMTI5IiwiREVYWFhYWFhYWFhY WFhYWFhYIiwiWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYIiwiWFhYWFhYWFhYWFhYWFhY WCIKIjA0LjA5LjI0IiwiMDQuMDkuMjQiLCJHZWJ1Y2h0IiwiT3RoZXIgTmFtZSIsIk15IE5hbWUi LCJUZXh0IiwiRWluZ2FuZyIsIkRFWFhYWFhYWFhYWFhYWFhYWFhYWFgiLCIyNCw2IiwiIiwiIiwi IgoiMDIuMDkuMjQiLCIwMi4wOS4yNCIsIkdlYnVjaHQiLCJNeSBOYW1lIiwiT3RoZXIgTmFtZSIs IlRleHQiLCJBdXNnYW5nIiwiREVYWFhYWFhYWFhYWFhYWFhYWFhYWCIsIi0xLjEyMyIsIiIsIiIs IiIKIjAyLjA5LjI0IiwiMDIuMDkuMjQiLCJHZWJ1Y2h0IiwiTXkgTmFtZSIsIk90aGVyIE5hbWUi LCJUZXh0IiwiQXVzZ2FuZyIsIkRFWFhYWFhYWFhYWFhYWFhYWFhYWFgiLCItMTEuMDAwIiwiIiwi IiwiIgoiMDIuMDkuMjQiLCIwMi4wOS4yNCIsIkdlYnVjaHQiLCJNeSBOYW1lIiwiT3RoZXIgTmFt ZSIsIlRleHQiLCJBdXNnYW5nIiwiREVYWFhYWFhYWFhYWFhYWFhYWFhYWCIsIi0yNDEsNTMiLCIi LCIiLCIiCg==