493124 2024-09-14 15:04:14 +0000 Double clicking icon on the desktop does not wait for a second click 2024-09-17 15:32:11 +0000 1 1 4 Plasma plasmashell Desktop icons & Folder View widget 6.1.5 Arch Linux Linux RESOLVED FIXED regression NOR normal 1.0 1 richard plasma-bugs-null filip.kendes1 hein nate https://invent.kde.org/plasma/plasma-desktop/-/commit/a62e877c899c897b629783782046d4391e6c538d 6.2.0 0 oldest_to_newest 2353836 0 richard 2024-09-14 15:04:14 +0000 SUMMARY Double clicking a desktop icon that has been before selected tries to rename the file instead of opening. STEPS TO REPRODUCE 1. Create a file on the desktop 2. Click the file to select it and wait a while 3. Any time after that and without deselecting, try to double click the icon to open OBSERVED RESULT The first click immediately enters "edit filename" mode and the file is not opened. EXPECTED RESULT Following the first click, there should be a delay and wait for a second click. Enter edit mode when second click is not detected. SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 6.1.5 KDE Frameworks Version: 6.5.0 Qt Version: 6.7.2 Kernel Version: 6.10.9-arch1-2 (64-bit) Graphics Platform: Wayland ADDITIONAL INFORMATION The "expected result" behavior is exactly how Dolphin handles this situation. If you double click a selected file, the file opens, if you single click it, it enters name edit mode after a small moment. 2353843 1 filip.kendes1 2024-09-14 15:54:44 +0000 Can confirm. Although important thing to note is that when you select the file, you need to double click on the file name to reproduce this, not the icon. Double clicking on the icon opens the file, but double clicking on the file name opens the "edit filename" mode. Double clicking on the file name in dolphin opens the file. 2354519 2 bug-janitor 2024-09-15 10:21:10 +0000 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2521 2354758 3 nate 2024-09-16 12:22:42 +0000 Git commit 36e0d2dd4198b7948adfb55d82c96852bba167de by Nate Graham, on behalf of Christoph Wolk. Committed on 16/09/2024 at 12:14. Pushed by ngraham into branch 'master'. containments/desktop: fix single-click to rename FolderView has a feature that allows the user to single-click the label of an already selected item to trigger renaming that item (given a particular combination of settings), mirroring similar functionality in Dolphin. This is, again as in Dolphin, supposed to not apply to cases where the label is double-clicked, which should open the double-clicked file. However, the detection of double-clicks does not work: it relies on the doubleClickInProgress property, which is set later in the event handler (and never reached in this case as the handler returns early), and so is almost always false (unless the clicked element changes mid- double-click). This change modifies the event handling logic to instead use the regular logic to wait for a double-click, and triggers the renaming function from the timer if applicable. FIXED-IN: 6.2 M +9 -7 containments/desktop/package/contents/ui/FolderView.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/36e0d2dd4198b7948adfb55d82c96852bba167de 2354768 4 nate 2024-09-16 12:49:20 +0000 Git commit a62e877c899c897b629783782046d4391e6c538d by Nate Graham. Committed on 16/09/2024 at 12:23. Pushed by ngraham into branch 'Plasma/6.2'. containments/desktop: fix single-click to rename FolderView has a feature that allows the user to single-click the label of an already selected item to trigger renaming that item (given a particular combination of settings), mirroring similar functionality in Dolphin. This is, again as in Dolphin, supposed to not apply to cases where the label is double-clicked, which should open the double-clicked file. However, the detection of double-clicks does not work: it relies on the doubleClickInProgress property, which is set later in the event handler (and never reached in this case as the handler returns early), and so is almost always false (unless the clicked element changes mid- double-click). This change modifies the event handling logic to instead use the regular logic to wait for a double-click, and triggers the renaming function from the timer if applicable. FIXED-IN: 6.2 (cherry picked from commit 36e0d2dd4198b7948adfb55d82c96852bba167de) Co-authored-by: Christoph Wolk <christoph.wolk@gmx.de> M +9 -7 containments/desktop/package/contents/ui/FolderView.qml https://invent.kde.org/plasma/plasma-desktop/-/commit/a62e877c899c897b629783782046d4391e6c538d