<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>489724</bug_id>
          
          <creation_ts>2024-07-04 10:03:36 +0000</creation_ts>
          <short_desc>kmymoney depends on knewstuff library but is not used when cpp macro KMM_DEBUG is not defined</short_desc>
          <delta_ts>2024-07-05 04:25:58 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>kmymoney</product>
          <component>packaging</component>
          <version>git (master)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>488491</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Ralf Habacker">ralf.habacker</reporter>
          <assigned_to name="KMyMoney Devel Mailing List">kmymoney-devel</assigned_to>
          
          
          <cf_commitlink>https://invent.kde.org/office/kmymoney/-/commit/3ea7ddcd1d8f9a7cfe06d5bc53c15546c32bc9f1</cf_commitlink>
          <cf_versionfixedin>5.2</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2334841</commentid>
    <comment_count>0</comment_count>
    <who name="Ralf Habacker">ralf.habacker</who>
    <bug_when>2024-07-04 10:03:36 +0000</bug_when>
    <thetext>STEPS TO REPRODUCE
1. see https://invent.kde.org/office/kmymoney/-/blob/master/CMakeLists.txt#L114 - knewstuff library is added
2. see https://invent.kde.org/office/kmymoney/-/blame/master/kmymoney/kmymoney.cpp?page=5#L4002

OBSERVED RESULT
The knewstuff library is requested in the cmake build system unconditionally. 
An api function from knewstuff is used at https://invent.kde.org/office/kmymoney/-/blame/master/kmymoney/kmymoney.cpp?page=5#L4002, but the associate support is only reachable when the cpp macro KMM_DEBUG is defined.

EXPECTED RESULT
If debugging is disabled, knewstuff should not be requested in the cmake build system and not be used in the c++ code.

SOFTWARE/OS VERSIONS
Linux: openSUSE_Leap_15.5 
KDE Frameworks Version: 5.103.0
Qt Version:  5.15.4</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2335028</commentid>
    <comment_count>1</comment_count>
    <who name="Thomas Baumgart">thb</who>
    <bug_when>2024-07-05 04:25:58 +0000</bug_when>
    <thetext>Git commit 3ea7ddcd1d8f9a7cfe06d5bc53c15546c32bc9f1 by Thomas Baumgart.
Committed on 05/07/2024 at 04:25.
Pushed by tbaumgart into branch &apos;master&apos;.

Remove dependency to knewstuff

The whole &quot;new stuff&quot; logic for the online quotes has been moved to the
alkimia library so we don&apos;t need it here anymore.
FIXED-IN: 5.2

M  +1    -1    CMakeLists.txt
M  +0    -1    kmymoney/CMakeLists.txt
M  +0    -4    kmymoney/kmymoney.cpp

https://invent.kde.org/office/kmymoney/-/commit/3ea7ddcd1d8f9a7cfe06d5bc53c15546c32bc9f1</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>