488764 2024-06-19 23:30:17 +0000 Auto-rotate settings don't appear in KCM until leaving KCM and returning to it once 2024-08-09 21:55:43 +0000 1 1 2 Applications systemsettings kcm_kscreen 5.93.0 Other Linux RESOLVED FIXED regression NOR normal --- 1 nate kscreen-bugs-null kde notmart plasma-bugs-null qydwhotmail sitter https://invent.kde.org/plasma/kscreen/-/commit/779c1f56d363f5f8afe7d71def5cd2d5699f8347 6.1.4 0 oldest_to_newest 2329479 0 nate 2024-06-19 23:30:17 +0000 Git master everything, Qt 6.7.1, Kernel 6.8.9. When I open the KCM for the first time after a reboot, the auto-rotate controls are all missing. When I flip my laptop's screen around to enter tablet mode, the controls appear. This is governed by the following visibility condition in https://invent.kde.org/plasma/kscreen/-/blob/master/kcm/ui/Orientation.qml?ref_type=heads#L23: visible: kcm.autoRotationSupported && kcm.orientationSensorAvailable I did a bit of testing, and what happens is that the value of kcm.orientationSensorAvailable doesn't become true until I flip around my laptop's lid to enter Tablet Mode. Maybe entering tablet mode for the first time initializes the orientation sensor or something? 2329490 1 qydwhotmail 2024-06-20 01:07:11 +0000 Can reproduce. No wonder I don't see the option. 2330255 2 sitter 2024-06-21 14:35:42 +0000 what I'm seeing in busctl on the first run is that we `Get` the `AccelerometerOrientation` property. that returns `undefined`. after it returns, the service issues a `PropertiesChanged` on that property with `normal` (we probably fail to act on that correctly). on subsequent runs the property is already in the service-side cache and the `Get` returns `normal` instead of `undefined` i.e. the reason it works on subsequent runs is because the service already has the property cached and returns its value immediately instead of via a changed signal 2333042 3 171126 kde 2024-06-28 11:26:06 +0000 Created attachment 171126 Blind patch Attached a blind patch, as I dont have the hardware to test this. 2333048 4 notmart 2024-06-28 11:59:25 +0000 (In reply to David Redondo from comment #3) > Created attachment 171126 [details] > Blind patch > > Attached a blind patch, as I dont have the hardware to test this. Can you do a MR? I can test it 2343184 5 bug-janitor 2024-08-05 14:42:42 +0000 A possibly relevant merge request was started @ https://invent.kde.org/plasma/kscreen/-/merge_requests/320 2343185 6 notmart 2024-08-05 14:48:43 +0000 Git commit 7723a604662c83f10e3db90c4130b2fd3b461c82 by Marco Martin. Committed on 05/08/2024 at 14:48. Pushed by mart into branch 'master'. Emit OrientationSensor::availableChanged() when needed when we get the signal from QtSensors that the rotation sensor became available, forward the signal so that the QML part can show the autorotation checkbox M +1 -0 common/orientation_sensor.cpp https://invent.kde.org/plasma/kscreen/-/commit/7723a604662c83f10e3db90c4130b2fd3b461c82 2343186 7 notmart 2024-08-05 14:51:26 +0000 Git commit 779c1f56d363f5f8afe7d71def5cd2d5699f8347 by Marco Martin. Committed on 05/08/2024 at 14:49. Pushed by mart into branch 'Plasma/6.1'. Emit OrientationSensor::availableChanged() when needed when we get the signal from QtSensors that the rotation sensor became available, forward the signal so that the QML part can show the autorotation checkbox (cherry picked from commit 7723a604662c83f10e3db90c4130b2fd3b461c82) bddbbfc6 Emit availableChanged() when needed Co-authored-by: Marco Martin <notmart@gmail.com> M +1 -0 common/orientation_sensor.cpp https://invent.kde.org/plasma/kscreen/-/commit/779c1f56d363f5f8afe7d71def5cd2d5699f8347 171126 2024-06-28 11:26:06 +0000 2024-06-28 11:26:06 +0000 Blind patch sensorbecomesavailable.diff text/plain 4272 kde ZGlmZiAtLWdpdCBhL3NyYy9wbHVnaW5zL3NlbnNvcnMvaWlvLXNlbnNvci1wcm94eS9paW9zZW5z b3Jwcm94eW9yaWVudGF0aW9uc2Vuc29yLmNwcCBiL3NyYy9wbHVnaW5zL3NlbnNvcnMvaWlvLXNl bnNvci1wcm94eS9paW9zZW5zb3Jwcm94eW9yaWVudGF0aW9uc2Vuc29yLmNwcAppbmRleCBmNTg5 ODcwYS4uNjk0OGI5NmUgMTAwNjQ0Ci0tLSBhL3NyYy9wbHVnaW5zL3NlbnNvcnMvaWlvLXNlbnNv ci1wcm94eS9paW9zZW5zb3Jwcm94eW9yaWVudGF0aW9uc2Vuc29yLmNwcAorKysgYi9zcmMvcGx1 Z2lucy9zZW5zb3JzL2lpby1zZW5zb3ItcHJveHkvaWlvc2Vuc29ycHJveHlvcmllbnRhdGlvbnNl bnNvci5jcHAKQEAgLTI1LDE1ICsyNSwxMSBAQCBJSU9TZW5zb3JQcm94eU9yaWVudGF0aW9uU2Vu c29yOjp+SUlPU2Vuc29yUHJveHlPcmllbnRhdGlvblNlbnNvcigpCiAKIHZvaWQgSUlPU2Vuc29y UHJveHlPcmllbnRhdGlvblNlbnNvcjo6c3RhcnQoKQogeworICAgIG1fc3RhcnRlZCA9IHRydWU7 CiAgICAgaWYgKGlzU2VydmljZVJ1bm5pbmcoKSkgewogICAgICAgICBpZiAobV9zZW5zb3JQcm94 eUludGVyZmFjZS0+aGFzQWNjZWxlcm9tZXRlcigpKSB7Ci0gICAgICAgICAgICBRREJ1c1BlbmRp bmdSZXBseTw+IHJlcGx5ID0gbV9zZW5zb3JQcm94eUludGVyZmFjZS0+Q2xhaW1BY2NlbGVyb21l dGVyKCk7Ci0gICAgICAgICAgICByZXBseS53YWl0Rm9yRmluaXNoZWQoKTsKLSAgICAgICAgICAg IGlmICghcmVwbHkuaXNFcnJvcigpKSB7Ci0gICAgICAgICAgICAgICAgUVN0cmluZyBvcmllbnRh dGlvbiA9IG1fc2Vuc29yUHJveHlJbnRlcmZhY2UtPmFjY2VsZXJvbWV0ZXJPcmllbnRhdGlvbigp OwotICAgICAgICAgICAgICAgIHVwZGF0ZU9yaWVudGF0aW9uKG9yaWVudGF0aW9uKTsKLSAgICAg ICAgICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICB9CisgICAgICAgICAgICBzZW5zb3JCZWNv bWVzQXZhaWxhYmxlKCk7CisgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KICAgICB9CiAg ICAgc2Vuc29yU3RvcHBlZCgpOwpAQCAtNDEsNiArMzcsNyBAQCB2b2lkIElJT1NlbnNvclByb3h5 T3JpZW50YXRpb25TZW5zb3I6OnN0YXJ0KCkKIAogdm9pZCBJSU9TZW5zb3JQcm94eU9yaWVudGF0 aW9uU2Vuc29yOjpzdG9wKCkKIHsKKyAgICBtX3N0YXJ0ZWQgPSBmYWxzZTsKICAgICBpZiAoaXNT ZXJ2aWNlUnVubmluZygpKSB7CiAgICAgICAgIFFEQnVzUGVuZGluZ1JlcGx5PD4gcmVwbHkgPSBt X3NlbnNvclByb3h5SW50ZXJmYWNlLT5SZWxlYXNlQWNjZWxlcm9tZXRlcigpOwogICAgICAgICBy ZXBseS53YWl0Rm9yRmluaXNoZWQoKTsKQEAgLTUwLDEwICs0NywzMCBAQCB2b2lkIElJT1NlbnNv clByb3h5T3JpZW50YXRpb25TZW5zb3I6OnN0b3AoKQogCiB2b2lkIElJT1NlbnNvclByb3h5T3Jp ZW50YXRpb25TZW5zb3I6OnVwZGF0ZVByb3BlcnRpZXMoY29uc3QgUVZhcmlhbnRNYXAgJmNoYW5n ZWRQcm9wZXJ0aWVzKQogeworICAgIGlmIChjaGFuZ2VkUHJvcGVydGllcy5jb250YWlucygiSGFz QWNjZWxlcm9tZXRlciIpKSB7CisgICAgICAgIGlmIChjaGFuZ2VkUHJvcGVydGllcy52YWx1ZSgi SGFzQWNjZWxlcm9tZXRlciIpLnRvQm9vbCgpICYmIG1fc3RhcnRlZCkgeworICAgICAgICAgICAg c2Vuc29yKCktPnNldEFjdGl2ZSh0cnVlKTsKKyAgICAgICAgICAgIHNlbnNvckJlY29tZXNBdmFp bGFibGUoKTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIHNlbnNvclN0b3BwZWQoKTsK KyAgICAgICAgfQorICAgIH0KICAgICBpZiAoY2hhbmdlZFByb3BlcnRpZXMuY29udGFpbnMoIkFj Y2VsZXJvbWV0ZXJPcmllbnRhdGlvbiIpKSB7CiAgICAgICAgIFFTdHJpbmcgb3JpZW50YXRpb24g PSBjaGFuZ2VkUHJvcGVydGllcy52YWx1ZSgiQWNjZWxlcm9tZXRlck9yaWVudGF0aW9uIikudG9T dHJpbmcoKTsKICAgICAgICAgdXBkYXRlT3JpZW50YXRpb24ob3JpZW50YXRpb24pOwogICAgIH0K KworfQorCit2b2lkIElJT1NlbnNvclByb3h5T3JpZW50YXRpb25TZW5zb3I6OnNlbnNvckJlY29t ZXNBdmFpbGFibGUoKQoreworICAgIFFEQnVzUGVuZGluZ1JlcGx5PD4gcmVwbHkgPSBtX3NlbnNv clByb3h5SW50ZXJmYWNlLT5DbGFpbUFjY2VsZXJvbWV0ZXIoKTsKKyAgICByZXBseS53YWl0Rm9y RmluaXNoZWQoKTsKKyAgICBpZiAoIXJlcGx5LmlzRXJyb3IoKSkgeworICAgICAgICBRU3RyaW5n IG9yaWVudGF0aW9uID0gbV9zZW5zb3JQcm94eUludGVyZmFjZS0+YWNjZWxlcm9tZXRlck9yaWVu dGF0aW9uKCk7CisgICAgICAgIHVwZGF0ZU9yaWVudGF0aW9uKG9yaWVudGF0aW9uKTsKKyAgICAg ICAgcmV0dXJuOworICAgIH0KIH0KIAogdm9pZCBJSU9TZW5zb3JQcm94eU9yaWVudGF0aW9uU2Vu c29yOjp1cGRhdGVPcmllbnRhdGlvbihjb25zdCBRU3RyaW5nICZvcmllbnRhdGlvbikKZGlmZiAt LWdpdCBhL3NyYy9wbHVnaW5zL3NlbnNvcnMvaWlvLXNlbnNvci1wcm94eS9paW9zZW5zb3Jwcm94 eW9yaWVudGF0aW9uc2Vuc29yLmggYi9zcmMvcGx1Z2lucy9zZW5zb3JzL2lpby1zZW5zb3ItcHJv eHkvaWlvc2Vuc29ycHJveHlvcmllbnRhdGlvbnNlbnNvci5oCmluZGV4IDBkODFkMzEyLi41ZmUw MDM0OCAxMDA2NDQKLS0tIGEvc3JjL3BsdWdpbnMvc2Vuc29ycy9paW8tc2Vuc29yLXByb3h5L2lp b3NlbnNvcnByb3h5b3JpZW50YXRpb25zZW5zb3IuaAorKysgYi9zcmMvcGx1Z2lucy9zZW5zb3Jz L2lpby1zZW5zb3ItcHJveHkvaWlvc2Vuc29ycHJveHlvcmllbnRhdGlvbnNlbnNvci5oCkBAIC0y OCw2ICsyOCw3IEBAIHByb3RlY3RlZDoKIAogcHJpdmF0ZToKICAgICB2b2lkIHVwZGF0ZU9yaWVu dGF0aW9uKGNvbnN0IFFTdHJpbmcgJm9yaWVudGF0aW9uKTsKKyAgICB2b2lkIHNlbnNvckJlY29t ZXNBdmFpbGFibGUoKTsKIAogICAgIFFPcmllbnRhdGlvblJlYWRpbmcgbV9yZWFkaW5nOwogICAg IE5ldEhhZGVzc1NlbnNvclByb3h5SW50ZXJmYWNlICptX3NlbnNvclByb3h5SW50ZXJmYWNlOwpk aWZmIC0tZ2l0IGEvc3JjL3BsdWdpbnMvc2Vuc29ycy9paW8tc2Vuc29yLXByb3h5L2lpb3NlbnNv cnByb3h5c2Vuc29yYmFzZS5jcHAgYi9zcmMvcGx1Z2lucy9zZW5zb3JzL2lpby1zZW5zb3ItcHJv eHkvaWlvc2Vuc29ycHJveHlzZW5zb3JiYXNlLmNwcAppbmRleCA5ZDc4NDJmOC4uMDA4YzdmNmIg MTAwNjQ0Ci0tLSBhL3NyYy9wbHVnaW5zL3NlbnNvcnMvaWlvLXNlbnNvci1wcm94eS9paW9zZW5z b3Jwcm94eXNlbnNvcmJhc2UuY3BwCisrKyBiL3NyYy9wbHVnaW5zL3NlbnNvcnMvaWlvLXNlbnNv ci1wcm94eS9paW9zZW5zb3Jwcm94eXNlbnNvcmJhc2UuY3BwCkBAIC0zMCw2ICszMCw3IEBAIHF1 aW50NjQgSUlPU2Vuc29yUHJveHlTZW5zb3JCYXNlOjpwcm9kdWNlVGltZXN0YW1wKCkKIAogSUlP U2Vuc29yUHJveHlTZW5zb3JCYXNlOjpJSU9TZW5zb3JQcm94eVNlbnNvckJhc2UoY29uc3QgUVN0 cmluZyYgZGJ1c1BhdGgsIGNvbnN0IFFTdHJpbmcgZGJ1c0lmYWNlLCBRU2Vuc29yICpzZW5zb3Ip CiAgICAgOiBRU2Vuc29yQmFja2VuZChzZW5zb3IpCisgICAgLCBtX3N0YXJ0ZWQoZmFsc2UpCiAg ICAgLCBtX2RidXNJbnRlcmZhY2UoZGJ1c0lmYWNlKQogewogICAgIFFEQnVzU2VydmljZVdhdGNo ZXIgKndhdGNoZXIgPSBuZXcgUURCdXNTZXJ2aWNlV2F0Y2hlcihzZXJ2aWNlTmFtZSgpLCBRREJ1 c0Nvbm5lY3Rpb246OnN5c3RlbUJ1cygpLApkaWZmIC0tZ2l0IGEvc3JjL3BsdWdpbnMvc2Vuc29y cy9paW8tc2Vuc29yLXByb3h5L2lpb3NlbnNvcnByb3h5c2Vuc29yYmFzZS5oIGIvc3JjL3BsdWdp bnMvc2Vuc29ycy9paW8tc2Vuc29yLXByb3h5L2lpb3NlbnNvcnByb3h5c2Vuc29yYmFzZS5oCmlu ZGV4IDEyYmFlZGNkLi4yM2Q5YjRhYSAxMDA2NDQKLS0tIGEvc3JjL3BsdWdpbnMvc2Vuc29ycy9p aW8tc2Vuc29yLXByb3h5L2lpb3NlbnNvcnByb3h5c2Vuc29yYmFzZS5oCisrKyBiL3NyYy9wbHVn aW5zL3NlbnNvcnMvaWlvLXNlbnNvci1wcm94eS9paW9zZW5zb3Jwcm94eXNlbnNvcmJhc2UuaApA QCAtMjQsNiArMjQsNyBAQCBwdWJsaWM6CiBwcm90ZWN0ZWQ6CiAgICAgc3RhdGljIHF1aW50NjQg cHJvZHVjZVRpbWVzdGFtcCgpOwogICAgIHZpcnR1YWwgdm9pZCB1cGRhdGVQcm9wZXJ0aWVzKGNv bnN0IFFWYXJpYW50TWFwICZjaGFuZ2VkUHJvcGVydGllcykgPSAwOworICAgIGJvb2wgbV9zdGFy dGVkOwogCiBwcml2YXRlIHNsb3RzOgogICAgIHZvaWQgc2VydmljZVJlZ2lzdGVyZWQoKTsK