488032 2024-06-04 17:52:09 +0000 Plasma session gets killed during 6.0 -> 6.1 upgrades 2024-06-07 16:49:43 +0000 1 1 4 Plasma plasmashell general git-stable-Plasma/6.1 Other Linux RESOLVED FIXED regression VHI crash 1.0 1 fabian kde heiko.becker kde kde nate plasma-bugs-null https://invent.kde.org/plasma/plasma-workspace/-/commit/c0624a8bddc2843a1652ea96e6bd1ab231becc8a 6.1 0 oldest_to_newest 2324543 0 fabian 2024-06-04 17:52:09 +0000 When upgrading from Plasma 6.0 to 6.1 (Beta) while a 6.0 session is active, that session gets killed. The reason for that plasma-workspace updates and adds some user .service files, including plasma-sentinel.service. To make systemd aware of this, the update triggers a daemon-reload of systemd user instances. This notices that plasma-workspace.target is active but the new plasma-sentinel.service is not, so it tries to rectify the situation: Jun 04 13:40:37 localhost.localdomain systemd[1639]: plasma-workspace.target: Unit is stopped because bound to inactive unit plasma-sentinel.service. Jun 04 13:40:37 localhost.localdomain systemd[1639]: plasma-workspace.target: Trying to enqueue job plasma-workspace.target/stop/replace This is fatal for the session. 2324562 1 kde 2024-06-04 19:28:07 +0000 Thanks for the investigation, I bet that was a pain. > This notices that plasma-workspace.target is active but the new plasma-sentinel.service is not, so it tries to rectify the situation: I *think* that's not quite the whole story. I think the new target will bring up plasma-sentinel.service, but plasma-sentinel.service will exit immediately if startplasma does not own the DBus name 'org.kde.startplasma', which obviously wasn't the case during the last boot. If so I can just delete from waiter.cpp ``` if (!sessionBus.interface()->isServiceRegistered(mService)) { qCDebug(LOG_PLASMA) << "WaitForName: Service" << mService << "is not yet registered"; return false; } ``` and say "watch for deregistration, but if the service doesn't exist, carry on". That would fix this issue, and fix the bug this was trying to fix in the first place. 2324567 2 fabian 2024-06-04 19:46:43 +0000 (In reply to David Edmundson from comment #1) > Thanks for the investigation, I bet that was a pain. > > > This notices that plasma-workspace.target is active but the new plasma-sentinel.service is not, so it tries to rectify the situation: > > I *think* that's not quite the whole story. > > I think the new target will bring up plasma-sentinel.service, but > plasma-sentinel.service will exit immediately if startplasma does not own > the DBus name 'org.kde.startplasma', which obviously wasn't the case during > the last boot. I had the same thought, but the log does not show any attempt at starting plasma-sentinel.service. systemctl --user status plasma-sentinel.service also doesn't show any sign of such an attempt. 2324635 3 kde 2024-06-05 06:03:11 +0000 I ran systemctl --user edit plasma-workspace.target and BindsTo=plasma-krunner can cause an immediate restart, even if it's 'Wanted' 2324943 4 bug-janitor 2024-06-06 08:45:20 +0000 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4421 2325280 5 bug-janitor 2024-06-07 07:59:02 +0000 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4425 2325321 6 kde 2024-06-07 11:42:59 +0000 Git commit dcd7080d7f04906ba2998e02779072a3ed9aaa66 by David Edmundson. Committed on 07/06/2024 at 11:21. Pushed by davidedmundson into branch 'master'. Revert "startkde: Close systemd session when startplasma exits" This code worked a bit too aggressively; on a live upgrade from 6.0 to 6.1, systemd will reload and immediately quit the whole session. This reverts commit 0ff2e9a70ccfa96b82fd6d2ea5a0a8545a5e3a60. M +0 -4 startkde/startplasma.cpp M +1 -1 startkde/systemd/CMakeLists.txt D +0 -10 startkde/systemd/plasma-sentinel.service.in M +1 -6 startkde/systemd/plasma-workspace.target M +1 -3 startkde/waitforname/waiter.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/dcd7080d7f04906ba2998e02779072a3ed9aaa66 2325474 7 nate 2024-06-07 16:49:43 +0000 Git commit c0624a8bddc2843a1652ea96e6bd1ab231becc8a by Nate Graham, on behalf of David Edmundson. Committed on 07/06/2024 at 16:29. Pushed by ngraham into branch 'Plasma/6.1'. Revert "startkde: Close systemd session when startplasma exits" This code worked a bit too aggressively; on a live upgrade from 6.0 to 6.1, systemd will reload and immediately quit the whole session. This reverts commit 0ff2e9a70ccfa96b82fd6d2ea5a0a8545a5e3a60. M +0 -4 startkde/startplasma.cpp M +1 -1 startkde/systemd/CMakeLists.txt D +0 -10 startkde/systemd/plasma-sentinel.service.in M +1 -6 startkde/systemd/plasma-workspace.target M +1 -3 startkde/waitforname/waiter.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/c0624a8bddc2843a1652ea96e6bd1ab231becc8a