<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>486724</bug_id>
          
          <creation_ts>2024-05-07 12:26:51 +0000</creation_ts>
          <short_desc>Kirigami.Icon doesn&apos;t apply &quot;active&quot; lightening/highlighting effect to pixmaps, only to icons loaded by name</short_desc>
          <delta_ts>2025-05-09 23:53:45 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>3</classification_id>
          <classification>Frameworks and Libraries</classification>
          <product>frameworks-kirigami</product>
          <component>general</component>
          <version>6.2.0</version>
          <rep_platform>Arch Linux</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>minor</bug_severity>
          <target_milestone>1.0</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>thegrandfinale2001</reporter>
          <assigned_to name="kdelibs bugs">kdelibs-bugs-null</assigned_to>
          <cc>mikel5764</cc>
    
    <cc>nate</cc>
    
    <cc>noahadvs</cc>
    
    <cc>notmart</cc>
          
          <cf_commitlink>https://invent.kde.org/frameworks/kirigami/-/commit/4142c2b7e7252ee1a2ae4d8aa51970d9457a692e</cf_commitlink>
          <cf_versionfixedin>6.16</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2318061</commentid>
    <comment_count>0</comment_count>
    <who name="">thegrandfinale2001</who>
    <bug_when>2024-05-07 12:26:51 +0000</bug_when>
    <thetext>***
If you&apos;re not sure this is actually a bug, instead post about it at https://discuss.kde.org

If you&apos;re reporting a crash, attach a backtrace with debug symbols; see https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***

SUMMARY
Icons in the panel produce a highlight effect when you hover over them, including the application launcher icon.  If you choose to use a different icon for the application launcher that icon does not highlight.


STEPS TO REPRODUCE
1. Change icon to an icon to a different icon.
2. Hover over custom icon.
3. No highlighting effect.

OBSERVED RESULT
No highlighting for custom icon.

EXPECTED RESULT
Custom icon should highlight like other icons in panel.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Arch Linux / KDE Plasma 6.0.4
(available in About System)
KDE Plasma Version: 6.0.4
KDE Frameworks Version: 6.1.0
Qt Version: 6.7.0

ADDITIONAL INFORMATION</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2318214</commentid>
    <comment_count>1</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2024-05-07 20:55:09 +0000</bug_when>
    <thetext>Which custom icon did you use? One of the system&apos;s standard icons, or else an image file?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2318223</commentid>
    <comment_count>2</comment_count>
    <who name="">thegrandfinale2001</who>
    <bug_when>2024-05-07 20:59:39 +0000</bug_when>
    <thetext>(In reply to Nate Graham from comment #1)
&gt; Which custom icon did you use? One of the system&apos;s standard icons, or else
&gt; an image file?

It was an image.  PNG and SVG, still the same results.  No standard icon used.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2318598</commentid>
    <comment_count>3</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2024-05-09 19:17:13 +0000</bug_when>
    <thetext>Can confirm. This appears to be happening because we&apos;re using the &quot;active&quot; property of Kirigami.Icon to do the lightening effect, and it only works when given an icon name, not a pixmap. Moving to Kirigami.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2422022</commentid>
    <comment_count>4</comment_count>
    <who name="Arjen Hiemstra">ahiemstra</who>
    <bug_when>2025-05-08 08:33:47 +0000</bug_when>
    <thetext>Git commit 4142c2b7e7252ee1a2ae4d8aa51970d9457a692e by Arjen Hiemstra.
Committed on 08/05/2025 at 08:18.
Pushed by ahiemstra into branch &apos;master&apos;.

primitives: Use a custom shader for rendering Icon

This replaces all QIcon effects, masking and transition animation with a
custom shader that does the same, making use of the new ShaderNode to
avoid a lot of boilerplate.
Related: bug 498530

M  +42   -87   src/primitives/icon.cpp
M  +0    -1    src/primitives/icon.h
M  +21   -0    src/primitives/shaders.cmake
A  +58   -0    src/primitives/shaders/icon.frag
A  +37   -0    src/primitives/shaders/icon.vert

https://invent.kde.org/frameworks/kirigami/-/commit/4142c2b7e7252ee1a2ae4d8aa51970d9457a692e</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>