486409 2024-05-01 16:07:20 +0000 System Settings allows users to select Adwaita as an icon theme, which breaks things due to missing icons 2024-05-05 22:24:50 +0000 1 1 2 Applications systemsettings kcm_icons 6.0.4 Fedora RPMs Linux RESOLVED FIXED https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/issues/288 NOR major --- 1 ngompa plasma-bugs-null 4wy78uwh kde nate timaeos https://invent.kde.org/plasma/plasma-workspace/-/commit/c8b8a4db63b575edf931c3d61aea1ed3d3d287f2 6.0.5 0 oldest_to_newest 2315601 0 ngompa 2024-05-01 16:07:20 +0000 SUMMARY Users are able to select the Adwaita icon theme in Plasma, and the result is pretty broken due to numerous missing icons. It is unlikely that Adwaita can be fixed to be a fully compliant FDO icon theme, so we should block it in KDE Plasma. STEPS TO REPRODUCE 1. Open System Settings 2. Change the icon theme to Adwaita OBSERVED RESULT The system switches to Adwaita, and a bunch of icons are simply nonexistent and get replaced either a "broken file" icon or no icon at all. EXPECTED RESULT You cannot select Adwaita as an icon theme for Plasma and none of this breakage is possible. SOFTWARE/OS VERSIONS Linux/KDE Plasma: Fedora Linux 40 (KDE Plasma) (available in About System) KDE Plasma Version: 6.0.4 KDE Frameworks Version: 6.1.0 Qt Version: 6.7.0 ADDITIONAL INFORMATION Cinnamon has blocked Adwaita a few days ago[1][2]. Budgie blocked Adwaita a couple years ago[3]. [1]: https://github.com/linuxmint/cinnamon/commit/13b1ad104e88197f6c4e2d02ab2674c07254b8e8 [2]: https://github.com/linuxmint/cinnamon/commit/b6661f62a42958b80425c63b34ad789bfa7eb3f2 [3]: https://github.com/BuddiesOfBudgie/budgie-desktop/commit/27b944769ada26e4d8c60252a4602f7b15b2688f 2315603 1 nate 2024-05-01 16:12:36 +0000 Given the problems described in https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/issues/288, I think this is reasonable until Adwaita regains the ability to be a proper FDO-compatible icon theme. 2315604 2 ngompa 2024-05-01 16:14:02 +0000 We should also probably block the GNOME/GTK built-in high contrast theme too for the same reason. 2315634 3 bug-janitor 2024-05-01 18:24:15 +0000 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4280 2315692 4 nate 2024-05-01 21:41:00 +0000 Git commit 813d22ff80ede0c7c08e4563621e3778459426f0 by Nate Graham. Committed on 01/05/2024 at 21:24. Pushed by ngraham into branch 'master'. kcms/icons: filter out GNOME's Adwaita and High Contrast icon themes These are no longer FDO-compatible icon themes, and are apparently no longer intended to be used for non-GNOME apps--going against what an FDO icon theme is supposed to be used for. I've contacted the GNOME folks about it, and unfortunately they've made it clear that the situation is intended; see https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/issues/288 As such, allowing the user to select these icon themes will just give them an opportunity to break all their non-GNOME apps. Let's filter these themes out to prevent that possibility. We still need to figure out a solution for when our apps are run in distros where Adwaita is used as the default icon theme, but that's a separate topic. FIXED-IN: 6.1 M +12 -0 kcms/icons/iconsmodel.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/813d22ff80ede0c7c08e4563621e3778459426f0 2315694 5 nate 2024-05-01 22:03:11 +0000 Git commit c8b8a4db63b575edf931c3d61aea1ed3d3d287f2 by Nate Graham. Committed on 01/05/2024 at 21:50. Pushed by ngraham into branch 'Plasma/6.0'. kcms/icons: filter out GNOME's Adwaita and High Contrast icon themes These are no longer FDO-compatible icon themes, and are apparently no longer intended to be used for non-GNOME apps--going against what an FDO icon theme is supposed to be used for. I've contacted the GNOME folks about it, and unfortunately they've made it clear that the situation is intended; see https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/issues/288 As such, allowing the user to select these icon themes will just give them an opportunity to break all their non-GNOME apps. Let's filter these themes out to prevent that possibility. We still need to figure out a solution for when our apps are run in distros where Adwaita is used as the default icon theme, but that's a separate topic. FIXED-IN: 6.0.5 (cherry picked from commit 813d22ff80ede0c7c08e4563621e3778459426f0) M +12 -0 kcms/icons/iconsmodel.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/c8b8a4db63b575edf931c3d61aea1ed3d3d287f2