48461 2002-09-29 18:59:19 +0000 kmail should remember smtp password 2007-09-14 12:17:01 +0000 1 1 10 Unmaintained kmail general unspecified RedHat Enterprise Linux Linux RESOLVED FIXED NOR wishlist --- 1 test1 pim-bugs-null kdebugs 86 oldest_to_newest 96644 0 test1 2002-09-29 18:59:19 +0000 Version: (using KDE KDE 3.0) Installed from: RedHat RPMs Unlike pop or imap passwords, kde cannot remember smtp passwords. I do not check "store password in configuration file" box, for security reasons. As a result every time I want to send an email, I have to reenter smtp auth password. I would like kde to store password in memory like pop or imap passwords. So I should only enter password once per session. 96658 1 kloecker 2002-09-29 20:38:19 +0000 I'd also like to see this implemented. 160532 2 ladislav.strojil 2003-09-22 11:27:06 +0000 KMail now supports saving SMTP password in its configuration file. Please upgrade if you haven't done already so. 255527 3 schnetter 2004-08-03 10:59:52 +0000 I don't think that comment #2 answers the feature request of the original poster. Ali wants kmail to remember the password per session, so that the password is not stored in a file (and all backups). I would be very happy to see the same feature. 255561 4 a.gungl 2004-08-03 13:24:57 +0000 The caching isn't fixed. That's why I reopen the wish. Caching should work like for receiving or for signing where you have to provide the password only once per KMail session. Storing the password in the config file is not really related. 361116 5 tonyb.sfkde 2005-07-28 17:14:20 +0000 Also, I would like to see an option that says POP and SMTP passwords are the same. 367988 6 kdebugs 2005-08-23 06:02:52 +0000 Password should be cached. As said above, I would not like to have my password stored in the config file 447721 7 nu2linux 2006-06-18 22:58:59 +0000 I am using KDE 3.5.1 level a. on a SUSE 10.1 Linux distribution and this SMTP password bug is not fixed as yet. Everything I have tried does not work everytime I send an email I am asked whether or not I want to save my password to a configuration file and I say yes and it never saves it. 472988 8 rasasi78 2006-09-26 16:52:44 +0000 I also vote for this one and for the #5 proposal. This bug is somewhat old, and I don't that implementing this could be difficult. Just for general interest, thunderbird has already this option, and I also would like that my favourite mail reading app has it. Thank you. 508949 9 19666 luigi.toscano 2007-02-13 18:27:46 +0000 Created attachment 19666 Proposed patch (tested on the 3.5.x branch) 508957 10 winter 2007-02-13 18:45:27 +0000 SVN commit 633276 by winterz: Make KMail remember the SMTP password. Thanks for the patch Luigi. CCBUGS: 48461 M +14 -0 branches/work/kdepim-3.5.5+/kmail/kmsender.cpp M +2 -0 branches/work/kdepim-3.5.5+/kmail/kmsender.h --- branches/work/kdepim-3.5.5+/kmail/kmsender.cpp #633275:633276 @@ -723,6 +723,11 @@ mOutboxFolder->unGetMsg( mFailedMessages ); mCurrentMsg = 0; mFailedMessages++; + // reset cached password + QMapIterator <QString,QString> pc; + if ( (pc = mPasswdCache.find( mMethodStr )) != mPasswdCache.end() ) { + mPasswdCache.erase(pc); + } // Sending of message failed. if (!errString.isEmpty()) { int res = KMessageBox::Yes; @@ -1093,6 +1098,12 @@ if (ti->auth) { + QMapIterator<QString,QString> tpc = mSender->mPasswdCache.find( ti->name ); + QString tpwd = ( tpc != mSender->mPasswdCache.end() )?(*tpc):QString::null; + + if ( ti->passwd().isEmpty() ) + ti->setPasswd( tpwd ); + if( (ti->user.isEmpty() || ti->passwd().isEmpty()) && ti->authType != "GSSAPI" ) { @@ -1113,6 +1124,9 @@ if (int id = KMTransportInfo::findTransport(ti->name)) { ti->setPasswd( passwd ); ti->writeConfig(id); + + // save the password into the cache + mSender->mPasswdCache[ti->name] = passwd; } } destination.setUser(ti->user); --- branches/work/kdepim-3.5.5+/kmail/kmsender.h #633275:633276 @@ -30,6 +30,7 @@ #include <qcstring.h> #include <qstring.h> #include <qstringlist.h> +#include <qmap.h> #include <qobject.h> #include <kdeversion.h> @@ -167,6 +168,7 @@ int mSentMessages, mTotalMessages; int mSentBytes, mTotalBytes; int mFailedMessages; + QMap<QString,QString> mPasswdCache; }; #endif /*kmsender_h*/ 520601 11 winter 2007-04-14 16:07:35 +0000 SVN commit 653892 by winterz: merge SVN commit 633276 by winterz: Make KMail remember the SMTP password. Thanks for the patch Luigi. BUGS: 48461 M +14 -0 kmsender.cpp M +2 -0 kmsender.h --- branches/KDE/3.5/kdepim/kmail/kmsender.cpp #653891:653892 @@ -707,6 +707,11 @@ mOutboxFolder->unGetMsg( mFailedMessages ); mCurrentMsg = 0; mFailedMessages++; + // reset cached password + QMapIterator <QString,QString> pc; + if ( (pc = mPasswdCache.find( mMethodStr )) != mPasswdCache.end() ) { + mPasswdCache.erase(pc); + } // Sending of message failed. if (!errString.isEmpty()) { int res = KMessageBox::Yes; @@ -1077,6 +1082,12 @@ if (ti->auth) { + QMapIterator<QString,QString> tpc = mSender->mPasswdCache.find( ti->name ); + QString tpwd = ( tpc != mSender->mPasswdCache.end() )?(*tpc):QString::null; + + if ( ti->passwd().isEmpty() ) + ti->setPasswd( tpwd ); + if( (ti->user.isEmpty() || ti->passwd().isEmpty()) && ti->authType != "GSSAPI" ) { @@ -1097,6 +1108,9 @@ if (int id = KMTransportInfo::findTransport(ti->name)) { ti->setPasswd( passwd ); ti->writeConfig(id); + + // save the password into the cache + mSender->mPasswdCache[ti->name] = passwd; } } destination.setUser(ti->user); --- branches/KDE/3.5/kdepim/kmail/kmsender.h #653891:653892 @@ -30,6 +30,7 @@ #include <qcstring.h> #include <qstring.h> #include <qstringlist.h> +#include <qmap.h> #include <qobject.h> #include <kdeversion.h> @@ -167,6 +168,7 @@ int mSentMessages, mTotalMessages; int mSentBytes, mTotalBytes; int mFailedMessages; + QMap<QString,QString> mPasswdCache; }; #endif /*kmsender_h*/ 19666 2007-02-13 18:27:46 +0000 2007-02-13 18:27:46 +0000 Proposed patch (tested on the 3.5.x branch) kmail_patch_ok_nodebug text/plain 1749 luigi.toscano SW5kZXg6IGttc2VuZGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0ga21zZW5kZXIuaAkocmV2aXNpb25lIDYz MjQ3MykKKysrIGttc2VuZGVyLmgJKGNvcGlhIGxvY2FsZSkKQEAgLTMwLDYgKzMwLDcgQEAKICNp bmNsdWRlIDxxY3N0cmluZy5oPgogI2luY2x1ZGUgPHFzdHJpbmcuaD4KICNpbmNsdWRlIDxxc3Ry aW5nbGlzdC5oPgorI2luY2x1ZGUgPHFtYXAuaD4KICNpbmNsdWRlIDxxb2JqZWN0Lmg+CiAjaW5j bHVkZSA8a2RldmVyc2lvbi5oPgogCkBAIC0xNjcsNiArMTY4LDcgQEAKICAgaW50IG1TZW50TWVz c2FnZXMsIG1Ub3RhbE1lc3NhZ2VzOwogICBpbnQgbVNlbnRCeXRlcywgbVRvdGFsQnl0ZXM7CiAg IGludCBtRmFpbGVkTWVzc2FnZXM7CisgIFFNYXA8UVN0cmluZyxRU3RyaW5nPiBtUGFzc3dkQ2Fj aGU7CiB9OwogCiAjZW5kaWYgLyprbXNlbmRlcl9oKi8KSW5kZXg6IGttc2VuZGVyLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBrbXNlbmRlci5jcHAJKHJldmlzaW9uZSA2MzI0NzMpCisrKyBrbXNlbmRlci5j cHAJKGNvcGlhIGxvY2FsZSkKQEAgLTcwNyw2ICs3MDcsMTEgQEAKICAgICAgICAgbU91dGJveEZv bGRlci0+dW5HZXRNc2coIG1GYWlsZWRNZXNzYWdlcyApOwogICAgICAgbUN1cnJlbnRNc2cgPSAw OwogICAgICAgbUZhaWxlZE1lc3NhZ2VzKys7CisgICAgICAvLyByZXNldCBjYWNoZWQgcGFzc3dv cmQKKyAgICAgIFFNYXBJdGVyYXRvciA8UVN0cmluZyxRU3RyaW5nPiBwYzsKKyAgICAgIGlmICgg KHBjID0gbVBhc3N3ZENhY2hlLmZpbmQoIG1NZXRob2RTdHIgKSkgIT0gbVBhc3N3ZENhY2hlLmVu ZCgpICkgeworICAgICAgICBtUGFzc3dkQ2FjaGUuZXJhc2UocGMpOworICAgICAgfQogICAgICAg Ly8gU2VuZGluZyBvZiBtZXNzYWdlIGZhaWxlZC4KICAgICAgIGlmICghZXJyU3RyaW5nLmlzRW1w dHkoKSkgewogICAgICAgICBpbnQgcmVzID0gS01lc3NhZ2VCb3g6OlllczsKQEAgLTEwNzcsNiAr MTA4MiwxMiBAQAogCiAgIGlmICh0aS0+YXV0aCkKICAgeworICAgIFFNYXBJdGVyYXRvcjxRU3Ry aW5nLFFTdHJpbmc+IHRwYyA9IG1TZW5kZXItPm1QYXNzd2RDYWNoZS5maW5kKCB0aS0+bmFtZSAp OworICAgIFFTdHJpbmcgdHB3ZCA9ICggdHBjICE9IG1TZW5kZXItPm1QYXNzd2RDYWNoZS5lbmQo KSApPygqdHBjKTpRU3RyaW5nOjpudWxsOworCisgICAgaWYgKCB0aS0+cGFzc3dkKCkuaXNFbXB0 eSgpICkKKyAgICAgIHRpLT5zZXRQYXNzd2QoIHRwd2QgKTsKKwogICAgIGlmKCAodGktPnVzZXIu aXNFbXB0eSgpIHx8IHRpLT5wYXNzd2QoKS5pc0VtcHR5KCkpICYmCiAgICAgICB0aS0+YXV0aFR5 cGUgIT0gIkdTU0FQSSIgKQogICAgIHsKQEAgLTEwOTcsNiArMTEwOCw5IEBACiAgICAgICBpZiAo aW50IGlkID0gS01UcmFuc3BvcnRJbmZvOjpmaW5kVHJhbnNwb3J0KHRpLT5uYW1lKSkgewogICAg ICAgICB0aS0+c2V0UGFzc3dkKCBwYXNzd2QgKTsKICAgICAgICAgdGktPndyaXRlQ29uZmlnKGlk KTsKKworICAgICAgICAvLyBzYXZlIHRoZSBwYXNzd29yZCBpbnRvIHRoZSBjYWNoZQorICAgICAg ICBtU2VuZGVyLT5tUGFzc3dkQ2FjaGVbdGktPm5hbWVdID0gcGFzc3dkOwogICAgICAgfQogICAg IH0KICAgICBkZXN0aW5hdGlvbi5zZXRVc2VyKHRpLT51c2VyKTsK