<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>479664</bug_id>
          
          <creation_ts>2024-01-11 19:26:25 +0000</creation_ts>
          <short_desc>[Animation curves] &quot;Add scalar keyframe&quot; doesn&apos;t interpolate</short_desc>
          <delta_ts>2024-02-28 18:09:41 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Animation</component>
          <version>git master (please specify the git hash!)</version>
          <rep_platform>Ubuntu</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="paleh">paleh21669</reporter>
          <assigned_to name="Krita Bugs">krita-bugs-null</assigned_to>
          
          
          <cf_commitlink>https://invent.kde.org/graphics/krita/-/commit/5a470a59d2b1af03ef7e14e3315595f6a00ef66a</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2279565</commentid>
    <comment_count>0</comment_count>
    <who name="paleh">paleh21669</who>
    <bug_when>2024-01-11 19:26:25 +0000</bug_when>
    <thetext>STEPS TO REPRODUCE
1.  Create a non-empty paint layer, add a transform mask to it.
2.  Add 2 keyframes to the mask in the animation curves docker such that there&apos;s at least 1 frame between the two.
3.  Select the frame (time) between the two keyframes and press the button &quot;Add keyframe to control scalar property&quot;

OBSERVED RESULT
The values of the keyframe added in step 3 copy the ones of the preceding frame.

EXPECTED RESULT
The values of the keyframe are linearly interpolated between the values of the surrounding keyframes.
Note: the result is as expected if at step 3, instead of pressing the button, we create the keyframe via the transform tool.

SOFTWARE/OS VERSIONS
Linux: Ubuntu 22.04
Qt Version: 5.15.7
Appimage

ADDITIONAL INFORMATION
git-b034513065 (today&apos;s nightly)
regression compared to 5.2.2
This was present at least as early as 5ffd6bebd0 (and so, unrelated to today&apos;s and yesterday&apos;s patches for animation curves)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2280769</commentid>
    <comment_count>1</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2024-01-16 14:11:42 +0000</bug_when>
    <thetext>Git commit fdb6edecf81262fade4b3f4c0257a161dd333231 by Dmitry Kazakov.
Committed on 16/01/2024 at 14:50.
Pushed by dkazakov into branch &apos;master&apos;.

Fix new scalar frames to use interpolated values

M  +1    -1    plugins/dockers/animation/KisAnimCurvesDocker.cpp
M  +1    -1    plugins/dockers/animation/KisAnimUtils.cpp

https://invent.kde.org/graphics/krita/-/commit/fdb6edecf81262fade4b3f4c0257a161dd333231</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2292555</commentid>
    <comment_count>2</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2024-02-28 18:09:41 +0000</bug_when>
    <thetext>Git commit 5a470a59d2b1af03ef7e14e3315595f6a00ef66a by Dmitry Kazakov.
Committed on 28/02/2024 at 12:54.
Pushed by dkazakov into branch &apos;kazakov/for-5.2&apos;.

Fix new scalar frames to use interpolated values

M  +1    -1    plugins/dockers/animation/KisAnimCurvesDocker.cpp
M  +1    -1    plugins/dockers/animation/KisAnimUtils.cpp

https://invent.kde.org/graphics/krita/-/commit/5a470a59d2b1af03ef7e14e3315595f6a00ef66a</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>