<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>476683</bug_id>
          
          <creation_ts>2023-11-07 16:51:15 +0000</creation_ts>
          <short_desc>Comics manager docker&apos;s visibility isn&apos;t affected by the Show Dockers toggle.</short_desc>
          <delta_ts>2024-08-22 20:49:48 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Dockers</component>
          <version>5.2.1</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>regression</keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="BroskiBaboski">wonkyskotny3</reporter>
          <assigned_to name="Krita Bugs">krita-bugs-null</assigned_to>
          <cc>deanyockey</cc>
    
    <cc>halla</cc>
    
    <cc>penguinflyer2222</cc>
          
          <cf_commitlink>https://invent.kde.org/graphics/krita/-/commit/984b8c5e6545765c8f7f9c139419207781a38e3b</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2264015</commentid>
    <comment_count>0</comment_count>
    <who name="BroskiBaboski">wonkyskotny3</who>
    <bug_when>2023-11-07 16:51:15 +0000</bug_when>
    <thetext>SUMMARY
***
Title; Comic manager docker won&apos;t despawn despite pressing the Show Dockers shortcut
***


STEPS TO REPRODUCE
1. Have comics manager docker floating
2. press &quot;Show Dockers&quot; shortcut

OBSERVED RESULT
Other dockers disappear, but Comics Manager does not

EXPECTED RESULT
They should all despawn

SOFTWARE/OS VERSIONS
Linux: EndeavourOS / i3wm
KDE Frameworks Version: 5.111.0
Qt Version: 5.15.11

ADDITIONAL INFORMATION
Does not happen in 5.2.0 and earlier</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2264125</commentid>
    <comment_count>1</comment_count>
    <who name="Halla Rempt">halla</who>
    <bug_when>2023-11-08 09:44:48 +0000</bug_when>
    <thetext>That goes for all dockers that have the special attribute &quot;show on welcome screen&quot;. Working around this is rather complicated, so we kinda decided to just keep it this way. The only other docker right now with that attribute is the log docker.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2264310</commentid>
    <comment_count>2</comment_count>
    <who name="BroskiBaboski">wonkyskotny3</who>
    <bug_when>2023-11-09 04:10:27 +0000</bug_when>
    <thetext>Well, this is a problem for me because I am dependant on that. I use my dockers on floating and spawn/despawn them at necessity through the shortcut, plus I work on comics so I require that docker.
I&apos;m currently using 5.1.5 and the issue doesn&apos;t exist there</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2264334</commentid>
    <comment_count>3</comment_count>
    <who name="Halla Rempt">halla</who>
    <bug_when>2023-11-09 09:14:07 +0000</bug_when>
    <thetext>Yes, I know. 5.1.5 didn&apos;t have the new docker-hiding welcome screen. But fixing this regression is not the highest priority.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2270623</commentid>
    <comment_count>4</comment_count>
    <who name="Bug Janitor Service">bug-janitor</who>
    <bug_when>2023-12-02 18:04:21 +0000</bug_when>
    <thetext>A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/2012</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2271954</commentid>
    <comment_count>5</comment_count>
    <who name="Freya Lupen">penguinflyer2222</who>
    <bug_when>2023-12-07 17:04:52 +0000</bug_when>
    <thetext>Git commit 35649e6d9c2ee95cfc62c629b0f7c4d7b9df68cb by Freya Lupen.
Committed on 07/12/2023 at 18:01.
Pushed by freyalupen into branch &apos;master&apos;.

Fix docker ShowOnWelcomePage flag

Ignore it if we aren&apos;t on the welcome page,
so we can still hide those dockers normally.

M  +3    -3    libs/ui/KisMainWindow.cpp
M  +1    -1    libs/ui/KisMainWindow.h

https://invent.kde.org/graphics/krita/-/commit/35649e6d9c2ee95cfc62c629b0f7c4d7b9df68cb</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2271955</commentid>
    <comment_count>6</comment_count>
    <who name="Freya Lupen">penguinflyer2222</who>
    <bug_when>2023-12-07 17:05:58 +0000</bug_when>
    <thetext>Git commit 984b8c5e6545765c8f7f9c139419207781a38e3b by Freya Lupen.
Committed on 07/12/2023 at 18:05.
Pushed by freyalupen into branch &apos;krita/5.2&apos;.

Fix docker ShowOnWelcomePage flag

Ignore it if we aren&apos;t on the welcome page,
so we can still hide those dockers normally.


(cherry picked from commit 35649e6d9c2ee95cfc62c629b0f7c4d7b9df68cb)

M  +3    -3    libs/ui/KisMainWindow.cpp
M  +1    -1    libs/ui/KisMainWindow.h

https://invent.kde.org/graphics/krita/-/commit/984b8c5e6545765c8f7f9c139419207781a38e3b</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2345942</commentid>
    <comment_count>7</comment_count>
    <who name="Dean">deanyockey</who>
    <bug_when>2024-08-15 17:35:13 +0000</bug_when>
    <thetext>Don&apos;t know why this bug is marked as &quot;RESOLVED FIXED&quot; when I&apos;m still having this exact same issue in 5.2.2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2347918</commentid>
    <comment_count>8</comment_count>
    <who name="Freya Lupen">penguinflyer2222</who>
    <bug_when>2024-08-22 20:25:58 +0000</bug_when>
    <thetext>The fix isn&apos;t in 5.2.2, but in 5.2.3 (the current latest version). Try updating.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2347920</commentid>
    <comment_count>9</comment_count>
    <who name="Freya Lupen">penguinflyer2222</who>
    <bug_when>2024-08-22 20:26:05 +0000</bug_when>
    <thetext>*** Bug 491757 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2347925</commentid>
    <comment_count>10</comment_count>
    <who name="Dean">deanyockey</who>
    <bug_when>2024-08-22 20:49:48 +0000</bug_when>
    <thetext>(In reply to Freya Lupen from comment #9)
&gt; *** Bug 491757 has been marked as a duplicate of this bug. ***

Thanks. Sorry for the trouble.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>