<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>476317</bug_id>
          
          <creation_ts>2023-10-30 08:34:39 +0000</creation_ts>
          <short_desc>after install 2261  my animation slice up on 5.3</short_desc>
          <delta_ts>2024-02-28 18:09:41 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Animation</component>
          <version>nightly build (please specify the git hash!)</version>
          <rep_platform>Microsoft Windows</rep_platform>
          <op_sys>Microsoft Windows</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>regression, release_blocker</keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="lizard_olmighty">harrynft</reporter>
          <assigned_to name="Dmitry Kazakov">dimula73</assigned_to>
          <cc>dimula73</cc>
          
          <cf_commitlink>https://invent.kde.org/graphics/krita/-/commit/7f3152798a08615d41e4e7cd6e0390b6cc67c0e1</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2262364</commentid>
    <comment_count>0</comment_count>
    <who name="lizard_olmighty">harrynft</who>
    <bug_when>2023-10-30 08:34:39 +0000</bug_when>
    <thetext>SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 11
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
After install version 2261 my animation move up per layer</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2262367</commentid>
    <comment_count>1</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2023-10-30 08:43:30 +0000</bug_when>
    <thetext>That is the same report as on KA:
https://krita-artists.org/t/need-testing-animated-transformation-masks-rewritten/76229/13</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2262387</commentid>
    <comment_count>2</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2023-10-30 11:38:29 +0000</bug_when>
    <thetext>I can confirm the issue using the test file that was sent by the reporter to my private email.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2263768</commentid>
    <comment_count>3</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2023-11-06 13:24:01 +0000</bug_when>
    <thetext>Git commit b24a3488cf23baa6ad0e41b8aef76cdf0787af87 by Dmitry Kazakov.
Committed on 06/11/2023 at 14:23.
Pushed by dkazakov into branch &apos;master&apos;.

Fix an offset when opening files with animated transform masks

Our curves should be centered againt the rotation center.

The current implementation still has a bug that the curve value
is **not** the position of the rotation center, but (position -
rotationCenterOffset), which is a completely nonsensial value.
But since it is baked into .kra format, we should keep it this
way for now.

M  +43   -2    plugins/tools/tool_transform2/KisAnimatedTransformMaskParamsHolder.cpp

https://invent.kde.org/graphics/krita/-/commit/b24a3488cf23baa6ad0e41b8aef76cdf0787af87</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2263771</commentid>
    <comment_count>4</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2023-11-06 13:25:58 +0000</bug_when>
    <thetext>Just for the sake of completeness, this package should fix the issue:

https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/2273/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2292554</commentid>
    <comment_count>5</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2024-02-28 18:09:41 +0000</bug_when>
    <thetext>Git commit 7f3152798a08615d41e4e7cd6e0390b6cc67c0e1 by Dmitry Kazakov.
Committed on 28/02/2024 at 12:49.
Pushed by dkazakov into branch &apos;kazakov/for-5.2&apos;.

Fix an offset when opening files with animated transform masks

Our curves should be centered againt the rotation center.

The current implementation still has a bug that the curve value
is **not** the position of the rotation center, but (position -
rotationCenterOffset), which is a completely nonsensial value.
But since it is baked into .kra format, we should keep it this
way for now.

M  +43   -2    plugins/tools/tool_transform2/KisAnimatedTransformMaskParamsHolder.cpp

https://invent.kde.org/graphics/krita/-/commit/7f3152798a08615d41e4e7cd6e0390b6cc67c0e1</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>