<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>475927</bug_id>
          
          <creation_ts>2023-10-21 15:05:29 +0000</creation_ts>
          <short_desc>Colorize tool: missing canvas updates on Edit key strokes and Show coloring</short_desc>
          <delta_ts>2024-02-28 18:10:14 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Tools/Colorize</component>
          <version>5.2.0</version>
          <rep_platform>Ubuntu</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="paleh">paleh21669</reporter>
          <assigned_to name="Krita Bugs">krita-bugs-null</assigned_to>
          <cc>p.f.parzer</cc>
          
          <cf_commitlink>https://invent.kde.org/graphics/krita/-/commit/eeffa12dddb1d373e6550ba7078565407bbae41a</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2260519</commentid>
    <comment_count>0</comment_count>
    <who name="paleh">paleh21669</who>
    <bug_when>2023-10-21 15:05:29 +0000</bug_when>
    <thetext>Formally , this is 2 different bugs, but since they may be related I decided to report them together.

STEPS TO REPRODUCE
1. Select the Colorize tool. Click on a paint layer to add a colorize mask.
2. Draw a stroke on the mask
3. In the tool options, click on update, wait for it to finish.
4. Uncheck &quot;Edit key strokes&quot;
5. Check &quot;Edit key strokes&quot;  back &lt;- error #1
6. Toggle &quot;Show coloring&quot; twice (in the layers docker)
7. Uncheck &quot;Edit key strokes&quot;
8. Uncheck &quot;Show coloring&quot;
9. Check &quot;Show coloring&quot; &lt;- error #2

OBSERVED RESULT
Step 5 has no immediate effect. Toggling &quot;Show coloring&quot; twice makes the canvas re-enter the strokes editing mode.
Step 9 has no immediate effect. Toggling &quot;Edit key strokes twice&quot; makes the coloring reappear.

EXPECTED RESULT
Step 5 makes the canvas enter the stroke editing mode immediately.
Step 9 makes the coloring appear immediately.

SOFTWARE/OS VERSIONS
Linux: Ubuntu 22.04
Qt Version: 5.15.7
Appimage

ADDITIONAL INFORMATION
The bug was not present in 5.1.5. It appeared at some point between 5.2.0-prealpha git 6c2a270 (30/11/2022) and 5.2.0-beta1 (27/06/2023)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2280121</commentid>
    <comment_count>1</comment_count>
    <who name="p.f.parzer@gmail.com">p.f.parzer</who>
    <bug_when>2024-01-13 15:51:53 +0000</bug_when>
    <thetext>This bug is still present in version 5.2.2 (appimage)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2280774</commentid>
    <comment_count>2</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2024-01-16 14:32:18 +0000</bug_when>
    <thetext>Git commit 1dbc7bd563cabf7691123ac407a0cc534552ca4d by Dmitry Kazakov.
Committed on 16/01/2024 at 15:32.
Pushed by dkazakov into branch &apos;master&apos;.

Don&apos;t skip updates on colorize mask props change

When we change visibility of any colorize mask&apos;s plane, we should
issue an update to make sure the new state of the layer is visible

M  +0    -2    libs/image/commands/kis_node_property_list_command.cpp

https://invent.kde.org/graphics/krita/-/commit/1dbc7bd563cabf7691123ac407a0cc534552ca4d</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2292567</commentid>
    <comment_count>3</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2024-02-28 18:10:14 +0000</bug_when>
    <thetext>Git commit eeffa12dddb1d373e6550ba7078565407bbae41a by Dmitry Kazakov.
Committed on 28/02/2024 at 12:54.
Pushed by dkazakov into branch &apos;kazakov/for-5.2&apos;.

Don&apos;t skip updates on colorize mask props change

When we change visibility of any colorize mask&apos;s plane, we should
issue an update to make sure the new state of the layer is visible

M  +0    -2    libs/image/commands/kis_node_property_list_command.cpp

https://invent.kde.org/graphics/krita/-/commit/eeffa12dddb1d373e6550ba7078565407bbae41a</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>