<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>474809</bug_id>
          
          <creation_ts>2023-09-23 16:04:24 +0000</creation_ts>
          <short_desc>We cannot active the OK button pressing ENTER in windows we resize image/canvas</short_desc>
          <delta_ts>2024-11-15 10:07:56 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Resize/Scale Image/Layer</component>
          <version>5.2.0-rc1</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>garuda1300</reporter>
          <assigned_to name="Krita Bugs">krita-bugs-null</assigned_to>
          <cc>dimula73</cc>
    
    <cc>griffinvalley</cc>
    
    <cc>rojasreinold</cc>
          
          <cf_commitlink>https://invent.kde.org/graphics/krita/-/commit/cd7b48348ce7bdad61a86b499410550acfa59062</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2254941</commentid>
    <comment_count>0</comment_count>
    <who name="">garuda1300</who>
    <bug_when>2023-09-23 16:04:24 +0000</bug_when>
    <thetext>SUMMARY
Hello. In version 5.1.5 we could resize image/canvas by changing width and/or height and just pressing ENTER. Now, press ENTER no longer works, even though we haven&apos;t made any changes. We need to use the mouse to click the OK button.


STEPS TO REPRODUCE
1. open the window to resize the image or canvas of an image
2. press enter when the window appear

OBSERVED RESULT
Nothing happens. The OK button is no longer &quot;selected&quot;.

EXPECTED RESULT
pressing the ENTER button OK would work automatically.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: LINUX MINT 20.3

ADDITIONAL INFORMATION
We cannot use the TAB as a workaround, because it selects the OK AND the button that link Width with Height.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2259799</commentid>
    <comment_count>1</comment_count>
    <who name="wolthera">griffinvalley</who>
    <bug_when>2023-10-18 11:46:59 +0000</bug_when>
    <thetext>I can&apos;t seem to reproduce &apos;enter&apos; not working when nothing is set, and while there *is* something odd going on with the tab-order in resize-canvas, I cannot get into a state where the ok button and the link-width-and-height buttons are both focused.

Is this with the appimage, or some other version?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2259844</commentid>
    <comment_count>2</comment_count>
    <who name="">garuda1300</who>
    <bug_when>2023-10-18 14:54:16 +0000</bug_when>
    <thetext>Hello wolthera,
this issue can be reproduced with 5.2.0 appimage. I&apos;m using Linux Mint 21.1.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2259868</commentid>
    <comment_count>3</comment_count>
    <who name="wolthera">griffinvalley</who>
    <bug_when>2023-10-18 17:25:52 +0000</bug_when>
    <thetext>Linux mint provides various flavours, is this for example cinnamon or gnome?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2259875</commentid>
    <comment_count>4</comment_count>
    <who name="">garuda1300</who>
    <bug_when>2023-10-18 17:58:26 +0000</bug_when>
    <thetext>Ops, sorry. It&apos;s XFCE.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2259970</commentid>
    <comment_count>5</comment_count>
    <who name="Bug Janitor Service">bug-janitor</who>
    <bug_when>2023-10-19 03:46:24 +0000</bug_when>
    <thetext>Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2374215</commentid>
    <comment_count>6</comment_count>
    <who name="Reinold Rojas">rojasreinold</who>
    <bug_when>2024-11-14 03:04:51 +0000</bug_when>
    <thetext>I can reproduce this on the krita Next 84484d65d1. I also tried to replicate this in my docker container build of Krita and I wasn&apos;t able to reproduce it there. It seems something happens when its in an appimage that causes this bug.

Reproduce steps:
1. Got to Image -&gt;rezise canvas
2. Press enter when the window appears (should close the window but nothing happens)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2374660</commentid>
    <comment_count>7</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2024-11-15 09:58:41 +0000</bug_when>
    <thetext>Hi, Reinold Rojas!

What desktop environment do you use? I seem to cannot reproduce the issue locally. 

The only way how I can reproduce the issue is when I click on any of the anchor buttons or on the lock buttons. Since these buttons are accessible using Tab-focus, they steal focus from the OK button until you click something else (e.g. the text spin-box). The only way we can fix that is by converting them into QToolButton, which would make then inaccessible from the Tab-focus. I&apos;m not sure if it is a desired behavior though.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2374661</commentid>
    <comment_count>8</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2024-11-15 10:07:42 +0000</bug_when>
    <thetext>Git commit 0b74dcd90886c2143d38e95359a0f1622bc7d598 by Dmitry Kazakov.
Committed on 15/11/2024 at 10:06.
Pushed by dkazakov into branch &apos;krita/5.2&apos;.

Fix focus issues in Canvas Size dialog

1) Make sure that anchor and lock buttons don&apos;t steal focus from the OK button
    (they should be available via Tab-focus only)
2) Change the tab-order of the widgets to be more consistent

M  +36   -1    libs/ui/imagesize/wdg_canvassize.ui

https://invent.kde.org/graphics/krita/-/commit/0b74dcd90886c2143d38e95359a0f1622bc7d598</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2374662</commentid>
    <comment_count>9</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2024-11-15 10:07:56 +0000</bug_when>
    <thetext>Git commit cd7b48348ce7bdad61a86b499410550acfa59062 by Dmitry Kazakov.
Committed on 15/11/2024 at 10:07.
Pushed by dkazakov into branch &apos;master&apos;.

Fix focus issues in Canvas Size dialog

1) Make sure that anchor and lock buttons don&apos;t steal focus from the OK button
    (they should be available via Tab-focus only)
2) Change the tab-order of the widgets to be more consistent

M  +36   -1    libs/ui/imagesize/wdg_canvassize.ui

https://invent.kde.org/graphics/krita/-/commit/cd7b48348ce7bdad61a86b499410550acfa59062</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>