473130 2023-08-08 02:47:55 +0000 Crash when undoing image color space conversion 2023-08-18 11:01:27 +0000 1 1 2 Applications krita Tile manager git master (please specify the git hash!) Ubuntu Linux RESOLVED FIXED release_blocker NOR crash --- 1 lynx.mw+kde dimula73 dimula73 https://invent.kde.org/graphics/krita/-/commit/665bf7ac7afc47e5e403f2b779ac3f68c201df9b 0 oldest_to_newest 2245121 0 160820 lynx.mw+kde 2023-08-08 02:47:55 +0000 Created attachment 160820 KCrash report SUMMARY Krita master, git commit 4b077697d0b5ecb2f45f79c86a1a48d36e57f423 Ubuntu Linux 22.04 This crash seems to require a decently large image (reproduced several times with 4096x4096, 2 paint layer), I couldn't reproduce with small ones. It may also require more than one layer, ond/or some editing like a simple brush stroke after the conversion, at least it seems to greatly increase the chance to crash for me. STEPS TO REPRODUCE 1. Open a decently large image (4096x4096, 2 paint layers in my case) 2. Convert image color space e.g. from RGB 8-bit to 16-bit integer 3. Undo the conversion OBSERVED RESULT Krita may crash instantly, see attached KCrash info 2247203 1 bug-janitor 2023-08-18 09:19:31 +0000 A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1905 2247205 2 dimula73 2023-08-18 09:43:18 +0000 Git commit d75c3eff6f861ebffe4667e0d44e525e1a98315d by Dmitry Kazakov. Committed on 18/08/2023 at 11:32. Pushed by dkazakov into branch 'master'. Fix Channels docker to generate thumbnails asynchronously Now the docker basically reuses the strategy used in Overview docker, so there should be no threading issues/crashes anymore. M +1 -0 libs/ui/CMakeLists.txt R +30 -26 libs/ui/KisImageThumbnailStrokeStrategy.cpp [from: plugins/dockers/overview/OverviewThumbnailStrokeStrategy.cpp - 056% similarity] A +72 -0 libs/ui/KisImageThumbnailStrokeStrategy.h [License: GPL(v2.0+)] M +6 -1 plugins/dockers/channeldocker/CMakeLists.txt A +56 -0 plugins/dockers/channeldocker/KisChannelsThumbnailsStrokeStrategy.cpp [License: GPL(v2.0+)] A +24 -0 plugins/dockers/channeldocker/KisChannelsThumbnailsStrokeStrategy.h * M +45 -40 plugins/dockers/channeldocker/channeldocker_dock.cpp M +7 -8 plugins/dockers/channeldocker/channeldocker_dock.h M +51 -88 plugins/dockers/channeldocker/channelmodel.cpp M +7 -6 plugins/dockers/channeldocker/channelmodel.h M +1 -2 plugins/dockers/overview/CMakeLists.txt D +0 -58 plugins/dockers/overview/OverviewThumbnailStrokeStrategy.h M +3 -3 plugins/dockers/overview/overviewwidget.cc The files marked with a * at the end have a non valid license. Please read: https://community.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page. https://invent.kde.org/graphics/krita/-/commit/d75c3eff6f861ebffe4667e0d44e525e1a98315d 2247215 3 dimula73 2023-08-18 11:01:27 +0000 Git commit 665bf7ac7afc47e5e403f2b779ac3f68c201df9b by Dmitry Kazakov. Committed on 18/08/2023 at 13:01. Pushed by dkazakov into branch 'krita/5.2'. Fix Channels docker to generate thumbnails asynchronously Now the docker basically reuses the strategy used in Overview docker, so there should be no threading issues/crashes anymore. (cherry picked from commit d75c3eff6f861ebffe4667e0d44e525e1a98315d) M +1 -0 libs/ui/CMakeLists.txt R +30 -26 libs/ui/KisImageThumbnailStrokeStrategy.cpp [from: plugins/dockers/overview/OverviewThumbnailStrokeStrategy.cpp - 056% similarity] A +72 -0 libs/ui/KisImageThumbnailStrokeStrategy.h [License: GPL(v2.0+)] M +6 -1 plugins/dockers/channeldocker/CMakeLists.txt A +56 -0 plugins/dockers/channeldocker/KisChannelsThumbnailsStrokeStrategy.cpp [License: GPL(v2.0+)] A +24 -0 plugins/dockers/channeldocker/KisChannelsThumbnailsStrokeStrategy.h * M +45 -40 plugins/dockers/channeldocker/channeldocker_dock.cpp M +7 -8 plugins/dockers/channeldocker/channeldocker_dock.h M +51 -88 plugins/dockers/channeldocker/channelmodel.cpp M +7 -6 plugins/dockers/channeldocker/channelmodel.h M +1 -2 plugins/dockers/overview/CMakeLists.txt D +0 -58 plugins/dockers/overview/OverviewThumbnailStrokeStrategy.h M +3 -3 plugins/dockers/overview/overviewwidget.cc The files marked with a * at the end have a non valid license. Please read: https://community.kde.org/Policies/Licensing_Policy and use the headers which are listed at that page. https://invent.kde.org/graphics/krita/-/commit/665bf7ac7afc47e5e403f2b779ac3f68c201df9b 160820 2023-08-08 02:47:55 +0000 2023-08-08 02:47:55 +0000 KCrash report krita-20230808-022432-undo-colorspace-conversion.kcrash text/vnd.kde.kcrash-report 5165 lynx.mw+kde QXBwbGljYXRpb246IEtyaXRhIChrcml0YSksIHNpZ25hbDogU2VnbWVudGF0aW9uIGZhdWx0Cgpb S0NyYXNoIEhhbmRsZXJdCiM0ICBzdGQ6Ol9fYXRvbWljX2Jhc2U8aW50Pjo6bG9hZChzdGQ6Om1l bW9yeV9vcmRlcikgY29uc3QgKF9fbT1zdGQ6Om1lbW9yeV9vcmRlcl9hY3F1aXJlLCB0aGlzPTB4 NDApIGF0IC91c3IvaW5jbHVkZS9jKysvMTEvYml0cy9hdG9taWNfYmFzZS5oOjQ3OQojNSAgUUF0 b21pY09wczxpbnQ+Ojpsb2FkQWNxdWlyZTxpbnQ+KHN0ZDo6YXRvbWljPGludD4gY29uc3QmKSAo X3FfdmFsdWU9PGVycm9yIHJlYWRpbmcgdmFyaWFibGU6IENhbm5vdCBhY2Nlc3MgbWVtb3J5IGF0 IGFkZHJlc3MgMHg0MD4pIGF0IC9vcHQvcXQ1MTUta2RlL2luY2x1ZGUvUXRDb3JlL3FhdG9taWNf Y3h4MTEuaDoyNTEKIzYgIFFCYXNpY0F0b21pY0ludGVnZXI8aW50Pjo6bG9hZEFjcXVpcmUoKSBj b25zdCAodGhpcz0weDQwKSBhdCAvb3B0L3F0NTE1LWtkZS9pbmNsdWRlL1F0Q29yZS9xYmFzaWNh dG9taWMuaDoxMTAKIzcgIFFCYXNpY0F0b21pY0ludGVnZXI8aW50Pjo6b3BlcmF0b3IgaW50KCkg Y29uc3QgKHRoaXM9MHg0MCkgYXQgL29wdC9xdDUxNS1rZGUvaW5jbHVkZS9RdENvcmUvcWJhc2lj YXRvbWljLmg6MTEyCiM4ICBLaXNUaWxlRGF0YTo6YWNxdWlyZSgpICh0aGlzPTB4MCkgYXQgL2hv bWUvbHlueC9jb2Rpbmcva3JpdGEva3JpdGEtZ2l0L2xpYnMvaW1hZ2UvdGlsZXMzL2tpc190aWxl X2RhdGEuaDo0MwojOSAgS2lzVGlsZTo6aW5pdChpbnQsIGludCwgS2lzVGlsZURhdGEqLCBLaXNN ZW1lbnRvTWFuYWdlciopICh0aGlzPXRoaXNAZW50cnk9MHg1NTgwMTlkMDlkNTAsIGNvbD1jb2xA ZW50cnk9MTEsIHJvdz0tNjA2NTg2MTc2LCByb3dAZW50cnk9MzUsIGRlZmF1bHRUaWxlRGF0YT1k ZWZhdWx0VGlsZURhdGFAZW50cnk9MHgwLCBtbT1tbUBlbnRyeT0weDApIGF0IC9ob21lL2x5bngv Y29kaW5nL2tyaXRhL2tyaXRhLWdpdC9saWJzL2ltYWdlL3RpbGVzMy9raXNfdGlsZS5jYzoyNwoj MTAgMHgwMDAwN2YwNmViMTYzYzU3IGluIEtpc1RpbGU6Oktpc1RpbGUoaW50LCBpbnQsIEtpc1Rp bGVEYXRhKiwgS2lzTWVtZW50b01hbmFnZXIqKSAodGhpcz10aGlzQGVudHJ5PTB4NTU4MDE5ZDA5 ZDUwLCBjb2w9Y29sQGVudHJ5PTExLCByb3c9cm93QGVudHJ5PTM1LCBkZWZhdWx0VGlsZURhdGE9 MHgwLCBtbT1tbUBlbnRyeT0weDApIGF0IC9ob21lL2x5bngvY29kaW5nL2tyaXRhL2tyaXRhLWdp dC9saWJzL2ltYWdlL3RpbGVzMy9raXNfdGlsZS5jYzozOAojMTEgMHgwMDAwN2YwNmViMTcyNzg4 IGluIEtpc1RpbGVIYXNoVGFibGVUcmFpdHMyPEtpc1RpbGU+OjpnZXRSZWFkT25seVRpbGVMYXp5 KGludCwgaW50LCBib29sJikgKHRoaXM9MHg3ZjA2OGM5Mjk3NTAsIGNvbD0xMSwgcm93PTM1LCBl eGlzdGluZ1RpbGU9QDB4N2ZmYzE5MWI5ZDkwOiBmYWxzZSkgYXQgL2hvbWUvbHlueC9jb2Rpbmcv a3JpdGEva3JpdGEtZ2l0L2xpYnMvaW1hZ2UvdGlsZXMzL2tpc190aWxlX2hhc2hfdGFibGUyLmg6 NDI5CiMxMiAweDAwMDA3ZjA2ZWIxOGJiZGYgaW4gS2lzVGlsZWREYXRhTWFuYWdlcjo6Z2V0VGls ZShpbnQsIGludCwgYm9vbCkgKHdyaXRhYmxlPTxvcHRpbWl6ZWQgb3V0Piwgcm93PTM1LCBjb2w9 MTEsIHRoaXM9MHg3ZjA2OGM5ZTA2MTApIGF0IC9ob21lL2x5bngvY29kaW5nL2tyaXRhL2tyaXRh LWdpdC9saWJzL2ltYWdlL3RpbGVzMy9raXNfdGlsZWRfZGF0YV9tYW5hZ2VyLmg6MTE2CiMxMyBL aXNUaWxlZERhdGFNYW5hZ2VyOjpnZXRUaWxlc1BhaXIoaW50LCBpbnQsIGJvb2wsIEtpc1NoYXJl ZFB0cjxLaXNUaWxlPiosIEtpc1NoYXJlZFB0cjxLaXNUaWxlPiopIChvbGRUaWxlPTB4NTU4MDEx Mjk4YWI4LCB0aWxlPTB4NTU4MDExMjk4YWIwLCB3cml0YWJsZT08b3B0aW1pemVkIG91dD4sIHJv dz0zNSwgY29sPTExLCB0aGlzPTB4N2YwNjhjOWUwNjEwKSBhdCAvaG9tZS9seW54L2NvZGluZy9r cml0YS9rcml0YS1naXQvbGlicy9pbWFnZS90aWxlczMva2lzX3RpbGVkX2RhdGFfbWFuYWdlci5o Ojk1CiMxNCBLaXNSYW5kb21BY2Nlc3NvcjI6OmZldGNoVGlsZURhdGEoaW50LCBpbnQpICh0aGlz PTB4NTU4MDIwYWUwMzQwLCBjb2w9MTEsIHJvdz0zNSkgYXQgL2hvbWUvbHlueC9jb2Rpbmcva3Jp dGEva3JpdGEtZ2l0L2xpYnMvaW1hZ2UvdGlsZXMzL2tpc19yYW5kb21fYWNjZXNzb3IuY2M6MTEz CiMxNSAweDAwMDA3ZjA2ZWIxOGMyYmUgaW4gS2lzUmFuZG9tQWNjZXNzb3IyOjptb3ZlVG8oaW50 LCBpbnQpICh0aGlzPTB4NTU4MDIwYWUwMzQwLCB4PTcwNCwgeT0yMjQwKSBhdCAvaG9tZS9seW54 L2NvZGluZy9rcml0YS9rcml0YS1naXQvbGlicy9pbWFnZS90aWxlczMva2lzX3JhbmRvbV9hY2Nl c3Nvci5jYzo4MAojMTYgMHgwMDAwN2YwNmViNDg0YzQ4IGluIGNyZWF0ZVRodW1ibmFpbERldmlj ZUludGVybmFsKEtpc1BhaW50RGV2aWNlIGNvbnN0KiwgcWludDMyLCBxaW50MzIsIHFpbnQzMiwg cWludDMyLCBxaW50MzIsIHFpbnQzMiwgUVJlY3QpIChzcmNEZXY9PG9wdGltaXplZCBvdXQ+LCBz cmNYMD0wLCBzcmNZMD0wLCBzcmNXaWR0aD00MDk2LCBzcmNIZWlnaHQ9NDA5Niwgdz0xMjgsIGg9 MTI4LCBvdXRwdXRSZWN0PS4uLikgYXQgL2hvbWUvbHlueC9jb2Rpbmcva3JpdGEva3JpdGEtZ2l0 L2xpYnMvaW1hZ2Uva2lzX3BhaW50X2RldmljZS5jYzoxNzA1CiMxNyAweDAwMDA3ZjA2ZWI0ODU4 MDggaW4gS2lzUGFpbnREZXZpY2U6OmNyZWF0ZVRodW1ibmFpbERldmljZU92ZXJzYW1wbGVkKGlu dCwgaW50LCBkb3VibGUsIFFSZWN0LCBRUmVjdCkgY29uc3QgKHRoaXM9dGhpc0BlbnRyeT0weDU1 ODAwZGQxODQxMCwgdz08b3B0aW1pemVkIG91dD4sIGg9PG9wdGltaXplZCBvdXQ+LCBvdmVyc2Ft cGxlPTIsIHJlY3Q9Li4uLCBvdXRwdXRUaWxlUmVjdD0uLi4pIGF0IC9vcHQvcXQ1MTUta2RlL2lu Y2x1ZGUvUXRDb3JlL3FzaXplLmg6MTM3CiMxOCAweDAwMDA3ZjA2YzE5ZjY1YTEgaW4gQ2hhbm5l bE1vZGVsOjp1cGRhdGVUaHVtYm5haWxzKCkgKHRoaXM9MHg1NTgwMDEyOTNhZDApIGF0IC9vcHQv cXQ1MTUta2RlL2luY2x1ZGUvUXRDb3JlL3FzaXplLmg6MTM3CiMxOSAweDAwMDA3ZjA2YzE5Zjg0 NzQgaW4gQ2hhbm5lbE1vZGVsOjpzbG90Q29sb3JTcGFjZUNoYW5nZWQoS29Db2xvclNwYWNlIGNv bnN0KikgKGNvbG9yU3BhY2U9PG9wdGltaXplZCBvdXQ+LCB0aGlzPTB4NTU4MDAxMjkzYWQwKSBh dCAvaG9tZS9seW54L2NvZGluZy9rcml0YS9rcml0YS1naXQvcGx1Z2lucy9kb2NrZXJzL2NoYW5u ZWxkb2NrZXIvY2hhbm5lbG1vZGVsLmNwcDoxOTEKIzIwIENoYW5uZWxNb2RlbDo6cXRfc3RhdGlj X21ldGFjYWxsKFFPYmplY3QqLCBRTWV0YU9iamVjdDo6Q2FsbCwgaW50LCB2b2lkKiopIChfbz0w eDU1ODAwMTI5M2FkMCwgX2M9PG9wdGltaXplZCBvdXQ+LCBfaWQ9PG9wdGltaXplZCBvdXQ+LCBf YT08b3B0aW1pemVkIG91dD4pIGF0IC9tZWRpYS9iaWdzdHVmZi9rcml0YS9idWlsZC9wbHVnaW5z L2RvY2tlcnMvY2hhbm5lbGRvY2tlci9rcml0YWNoYW5uZWxkb2NrZXJfYXV0b2dlbi9pbmNsdWRl L21vY19jaGFubmVsbW9kZWwuY3BwOjEwMAojMjEgMHgwMDAwN2YwNmU5Y2E0ZTllIGluIFFPYmpl Y3Q6OmV2ZW50KFFFdmVudCopICgpIGF0IC9vcHQvcXQ1MTUta2RlL2xpYi9saWJRdDVDb3JlLnNv LjUKIzIyIDB4MDAwMDdmMDZlYTdiODdhMyBpbiBRQXBwbGljYXRpb25Qcml2YXRlOjpub3RpZnlf aGVscGVyKFFPYmplY3QqLCBRRXZlbnQqKSAoKSBhdCAvb3B0L3F0NTE1LWtkZS9saWIvbGliUXQ1 V2lkZ2V0cy5zby41CiMyMyAweDAwMDA3ZjA2ZWMwZGJmOTUgaW4gS2lzQXBwbGljYXRpb246Om5v dGlmeShRT2JqZWN0KiwgUUV2ZW50KikgKHRoaXM9MHg3ZmZjMTkxYmFhMzAsIHJlY2VpdmVyPTB4 NTU4MDAxMjkzYWQwLCBldmVudD0weDdmMDY5NDNhNmRjMCkgYXQgL2hvbWUvbHlueC9jb2Rpbmcv a3JpdGEva3JpdGEtZ2l0L2xpYnMvdWkvS2lzQXBwbGljYXRpb24uY3BwOjc3MAojMjQgMHgwMDAw N2YwNmU5Yzc3NzhhIGluIFFDb3JlQXBwbGljYXRpb246Om5vdGlmeUludGVybmFsMihRT2JqZWN0 KiwgUUV2ZW50KikgKCkgYXQgL29wdC9xdDUxNS1rZGUvbGliL2xpYlF0NUNvcmUuc28uNQojMjUg MHgwMDAwN2YwNmU5YzdhODc3IGluIFFDb3JlQXBwbGljYXRpb25Qcml2YXRlOjpzZW5kUG9zdGVk RXZlbnRzKFFPYmplY3QqLCBpbnQsIFFUaHJlYWREYXRhKikgKCkgYXQgL29wdC9xdDUxNS1rZGUv bGliL2xpYlF0NUNvcmUuc28uNQojMjYgMHgwMDAwN2YwNmU5Y2QxNjU3IGluICAoKSBhdCAvb3B0 L3F0NTE1LWtkZS9saWIvbGliUXQ1Q29yZS5zby41CiMyNyAweDAwMDA3ZjA2ZTcxMjBkM2IgaW4g Z19tYWluX2NvbnRleHRfZGlzcGF0Y2ggKCkgYXQgL2xpYi94ODZfNjQtbGludXgtZ251L2xpYmds aWItMi4wLnNvLjAKIzI4IDB4MDAwMDdmMDZlNzE3NjI1OCBpbiAgKCkgYXQgL2xpYi94ODZfNjQt bGludXgtZ251L2xpYmdsaWItMi4wLnNvLjAKIzI5IDB4MDAwMDdmMDZlNzExZTNlMyBpbiBnX21h aW5fY29udGV4dF9pdGVyYXRpb24gKCkgYXQgL2xpYi94ODZfNjQtbGludXgtZ251L2xpYmdsaWIt Mi4wLnNvLjAKIzMwIDB4MDAwMDdmMDZlOWNkMGNhOCBpbiBRRXZlbnREaXNwYXRjaGVyR2xpYjo6 cHJvY2Vzc0V2ZW50cyhRRmxhZ3M8UUV2ZW50TG9vcDo6UHJvY2Vzc0V2ZW50c0ZsYWc+KSAoKSBh dCAvb3B0L3F0NTE1LWtkZS9saWIvbGliUXQ1Q29yZS5zby41CiMzMSAweDAwMDA3ZjA2ZTljNzYw YWIgaW4gUUV2ZW50TG9vcDo6ZXhlYyhRRmxhZ3M8UUV2ZW50TG9vcDo6UHJvY2Vzc0V2ZW50c0Zs YWc+KSAoKSBhdCAvb3B0L3F0NTE1LWtkZS9saWIvbGliUXQ1Q29yZS5zby41CiMzMiAweDAwMDA3 ZjA2ZTljN2U2NDQgaW4gUUNvcmVBcHBsaWNhdGlvbjo6ZXhlYygpICgpIGF0IC9vcHQvcXQ1MTUt a2RlL2xpYi9saWJRdDVDb3JlLnNvLjUKIzMzIDB4MDAwMDU1N2ZkOTg4MWZhYyBpbiBtYWluKGlu dCwgY2hhcioqKSAoYXJnYz08b3B0aW1pemVkIG91dD4sIGFyZ3Y9PG9wdGltaXplZCBvdXQ+KSBh dCAvaG9tZS9seW54L2NvZGluZy9rcml0YS9rcml0YS1naXQva3JpdGEvbWFpbi5jYzo3NDUKW0lu ZmVyaW9yIDEgKHByb2Nlc3MgNDg4ODEpIGRldGFjaGVkXQo=