<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>473103</bug_id>
          
          <creation_ts>2023-08-07 11:29:08 +0000</creation_ts>
          <short_desc>[Brush editor] Rotation -&gt; Drawing Angle -&gt; Angle Offset has no effect.</short_desc>
          <delta_ts>2023-08-07 15:05:05 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Brush engines</component>
          <version>git master (please specify the git hash!)</version>
          <rep_platform>Appimage</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>regression, release_blocker</keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="David REVOY">info</reporter>
          <assigned_to name="Dmitry Kazakov">dimula73</assigned_to>
          <cc>dimula73</cc>
          
          <cf_commitlink>https://invent.kde.org/graphics/krita/-/commit/272848ae5916e0b824694674e3834498f025a453</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2244909</commentid>
    <comment_count>0</comment_count>
    <who name="David REVOY">info</who>
    <bug_when>2023-08-07 11:29:08 +0000</bug_when>
    <thetext>Hi! 
The slider for &quot;Angle Offset&quot; in Rotation -&gt; Drawing Angle doesn&apos;t affect the rotation of the brush tip anymore in Krita 5.2beta1~appimage. It breaks one default brush preset in 5.2beta1 &quot;m) RGBa 02 Thickpaint&quot;, and some of my brush pack as well. 

Sorry Dmitry for not catching this bug during the Lager rewrite and tests on K-A :-) 

To reproduce:
============
1) Select the default brush &quot;m) RGBa 02 Thickpaint&quot;
2) Open Brush Editor, select Rotation, Drawing angle, and tweak the &quot;Angle Offset&quot; (90° for this brush)
3) Paint on the canvas or scratchpad while tweaking: no rotation is affected.

Expected:
========
The brush preset usually has its dab/brush-tip rotated 90°, making large brush strokes. With this bug, all its dabs are not 90° rotated, making them aligned in the continuity of the line (they should be perpendicular to the path, having an offset of 90°).

Workaround:
===========
Rotation of the brush tip can be compensated manually in the &quot;Brush Tip&quot; -&gt; Rotation. But it is a change at the root of the brush rotation and might affect other sensors using the brush tip.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2244953</commentid>
    <comment_count>1</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2023-08-07 15:00:33 +0000</bug_when>
    <thetext>Git commit 14649401ef18c7dbfa2876f9ec7f1c400c4053e5 by Dmitry Kazakov.
Committed on 07/08/2023 at 17:00.
Pushed by dkazakov into branch &apos;master&apos;.

Fix angle offset in Drawing Angle sensor

M  +1    -1    plugins/paintops/libpaintop/sensors/KisDynamicSensorDrawingAngle.h

https://invent.kde.org/graphics/krita/-/commit/14649401ef18c7dbfa2876f9ec7f1c400c4053e5</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2244954</commentid>
    <comment_count>2</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2023-08-07 15:05:05 +0000</bug_when>
    <thetext>Git commit 272848ae5916e0b824694674e3834498f025a453 by Dmitry Kazakov.
Committed on 07/08/2023 at 17:04.
Pushed by dkazakov into branch &apos;krita/5.2&apos;.

Fix angle offset in Drawing Angle sensor

M  +1    -1    plugins/paintops/libpaintop/sensors/KisDynamicSensorDrawingAngle.h

https://invent.kde.org/graphics/krita/-/commit/272848ae5916e0b824694674e3834498f025a453</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>