472730 2023-07-28 07:24:25 +0000 [5.2] Last preset isn't remembered when closing document 2023-07-28 08:05:02 +0000 1 1 2 Applications krita Resource Management unspecified Appimage Linux RESOLVED FIXED regression NOR normal --- 0 tomtomtomreportingin tomtomtomreportingin https://invent.kde.org/graphics/krita/-/commit/22b77302af9b7894fcb056d58a960b27b510076a 0 oldest_to_newest 2243195 0 tomtomtomreportingin 2023-07-28 07:24:25 +0000 SUMMARY Regressive behavior introduced with https://invent.kde.org/graphics/krita/-/merge_requests/1870. The last preset for the current stylus isn't remembered when closing a document, likely because KisViewManager neglects to write to the relevant config value on document close. The last preset is remembered properly when closing Krita entirely. STEPS TO REPRODUCE 1. Create a new document. 2. Select a new preset. 3. Close the document and create a new document. OBSERVED RESULT The preset from step 1 is used. EXPECTED RESULT The preset from step 2 should be used. SOFTWARE/OS VERSIONS Linux/KDE Plasma: Debian sid KDE Plasma Version: 5.27.5 KDE Frameworks Version: 5.107.0 Qt Version: 5.15.7 (appimage) 2243197 1 dimula73 2023-07-28 08:02:46 +0000 Git commit babfaf5b1b74559f77907231a54ac99359c94fc4 by Dmitry Kazakov. Committed on 28/07/2023 at 10:02. Pushed by dkazakov into branch 'master'. Revert "Ensure pen brush (opposed to eraser brush) is selected on new document" This reverts commit 6d7a8da6f7b7c35f5fd0fda49c7682b0cd67ac07. The patch causes a regression linked below. M +2 -7 libs/ui/KisViewManager.cpp M +0 -27 libs/ui/KisViewManager.h https://invent.kde.org/graphics/krita/-/commit/babfaf5b1b74559f77907231a54ac99359c94fc4 2243198 2 dimula73 2023-07-28 08:05:02 +0000 Git commit 22b77302af9b7894fcb056d58a960b27b510076a by Dmitry Kazakov. Committed on 28/07/2023 at 10:04. Pushed by dkazakov into branch 'krita/5.2'. Revert "Ensure pen brush (opposed to eraser brush) is selected on new document" This reverts commit 6d7a8da6f7b7c35f5fd0fda49c7682b0cd67ac07. The patch causes a regression linked below. M +2 -7 libs/ui/KisViewManager.cpp M +0 -27 libs/ui/KisViewManager.h https://invent.kde.org/graphics/krita/-/commit/22b77302af9b7894fcb056d58a960b27b510076a