<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>467118</bug_id>
          
          <creation_ts>2023-03-09 16:24:02 +0000</creation_ts>
          <short_desc>When pressing PrintScreen key to take new screenshot with main window open while using the &quot;printScreen key takes new screenshot&quot; setting, Spectacle closes</short_desc>
          <delta_ts>2023-03-31 15:57:03 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>Spectacle</product>
          <component>General</component>
          <version>22.12.3</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="David">david.cortes.rivera</reporter>
          <assigned_to name="Boudhayan Gupta">me</assigned_to>
          <cc>kde</cc>
    
    <cc>nate</cc>
    
    <cc>noahadvs</cc>
          
          <cf_commitlink>https://invent.kde.org/graphics/spectacle/commit/aef9e3a6a1df995e5f91dbdd922dc19d0f23b10f</cf_commitlink>
          <cf_versionfixedin>23.04</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2215180</commentid>
    <comment_count>0</comment_count>
    <who name="David">david.cortes.rivera</who>
    <bug_when>2023-03-09 16:24:02 +0000</bug_when>
    <thetext>SUMMARY
If I take a screenshot with spectacle, go to the annotation menu, and then press &quot;Print Screen&quot;, the new screenshot taken in that print screen will be lost.

STEPS TO REPRODUCE
1. Press &quot;Print screen&quot; to trigger spectacle.
2. In the spectacle window, click &quot;annotate&quot; (button in the bottom panel).
3. Press &quot;Print screen&quot; again.
4. Select some rectangle area and press Enter.

OBSERVED RESULT
New screenshot is lost.

EXPECTED RESULT
Should open a **new** spectacle window to deal with the new screenshot.

SOFTWARE/OS VERSIONS
Operating System: Debian GNU/Linux 12
KDE Plasma Version: 5.27.2
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8
Kernel Version: 6.1.0-6-amd64 (64-bit)
Graphics Platform: X11
Processors: 20 × 12th Gen Intel® Core™ i7-12700H
Memory: 62.5 GiB of RAM
Graphics Processor: Mesa Intel® Graphics
Manufacturer: SLIMBOOK
Product Name: Executive

ADDITIONAL INFORMATION</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2215957</commentid>
    <comment_count>1</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2023-03-13 19:06:09 +0000</bug_when>
    <thetext>By default, the Print Screen button takes a new screenshot, overwriting the current one. If you want it to open a new window instead, there&apos;s an option for this in the settings window.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2215958</commentid>
    <comment_count>2</comment_count>
    <who name="David">david.cortes.rivera</who>
    <bug_when>2023-03-13 19:06:57 +0000</bug_when>
    <thetext>(In reply to Nate Graham from comment #1)
&gt; By default, the Print Screen button takes a new screenshot, overwriting the
&gt; current one. If you want it to open a new window instead, there&apos;s an option
&gt; for this in the settings window.

If I configure it like that, the new window will not pop-up with a screenshot of the screen at the moment it was taken.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2215972</commentid>
    <comment_count>3</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2023-03-13 19:29:46 +0000</bug_when>
    <thetext>That seems like a bug; please submit a new bug report for it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2215980</commentid>
    <comment_count>4</comment_count>
    <who name="David">david.cortes.rivera</who>
    <bug_when>2023-03-13 19:39:47 +0000</bug_when>
    <thetext>(In reply to Nate Graham from comment #3)
&gt; That seems like a bug; please submit a new bug report for it.

I opened a new bug report: https://bugs.kde.org/show_bug.cgi?id=458713

But in any event, this is **still** a bug under the default configuration: it says &quot;While Spectacle is running&quot; -&gt; &quot;Press screenshot key to:&quot; -&gt; &quot;Take a new Screenshot&quot;.

In this case, if I press the screenshot key, it doesn&apos;t take a new screenshot like it would do if the annotation toolbox was closed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2216248</commentid>
    <comment_count>5</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2023-03-14 14:01:10 +0000</bug_when>
    <thetext>Oh, my mistake, sorry. I was misreading the original bug report. I can reproduce the issue with the upcoming 23.04 version too. I&apos;ll re-title the bug to be specific to what happens in the 23.04 version, since the 22.12 version won&apos;t be getting any more bugfixes and the code for is is substantially different (23.04 has a major rewrite of the app).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2219244</commentid>
    <comment_count>6</comment_count>
    <who name="Noah Davis">noahadvs</who>
    <bug_when>2023-03-30 01:26:43 +0000</bug_when>
    <thetext>Git commit 068c6f548688b3425a94786cacadbf5302a6e123 by Noah Davis.
Committed on 30/03/2023 at 01:24.
Pushed by ndavis into branch &apos;master&apos;.

Don&apos;t close all windows if activated by DBus with GUI and no CLI options

No options and having a GUI is a heuristic for activating Spectacle via
the PrintScreen key. Maybe we can find a better way to determine this
later, but I&apos;m trying to keep up with the release schedule for now.

M  +7    -3    src/SpectacleCore.cpp

https://invent.kde.org/graphics/spectacle/commit/068c6f548688b3425a94786cacadbf5302a6e123</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2219245</commentid>
    <comment_count>7</comment_count>
    <who name="Noah Davis">noahadvs</who>
    <bug_when>2023-03-30 01:45:19 +0000</bug_when>
    <thetext>Git commit aef9e3a6a1df995e5f91dbdd922dc19d0f23b10f by Noah Davis.
Committed on 30/03/2023 at 01:45.
Pushed by ndavis into branch &apos;release/23.04&apos;.

Don&apos;t close all windows if activated by DBus with GUI and no CLI options

No options and having a GUI is a heuristic for activating Spectacle via
the PrintScreen key. Maybe we can find a better way to determine this
later, but I&apos;m trying to keep up with the release schedule for now.


(cherry picked from commit 068c6f548688b3425a94786cacadbf5302a6e123)

M  +7    -3    src/SpectacleCore.cpp

https://invent.kde.org/graphics/spectacle/commit/aef9e3a6a1df995e5f91dbdd922dc19d0f23b10f</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>